Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 11 Dec 2023 20:01:59 +0000
From:   Mark Brown <broonie@kernel.org>
To:     David Hildenbrand <david@redhat.com>
Cc:     Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org,
        aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com,
        ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com,
        axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org,
        Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com,
        bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com,
        jdduke@google.com, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, kernel-team@android.com,
        John Hubbard <jhubbard@nvidia.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
Message-ID: <400c0342-bb28-4dd2-b132-9927c7babec4@sirena.org.uk>
References: <CAJuCfpHRYi4S9c+KKQqtE6Faw1e0E0ENMMRE17zXsqv_CftTGw@mail.gmail.com>
 <b93b29e9-c176-4111-ae0e-d4922511f223@sirena.org.uk>
 <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com>
 <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk>
 <CAJuCfpEcbcO0d5WPDHMqiEJws9k_5c30pE-J+E_VxO_fpTf_mw@mail.gmail.com>
 <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com>
 <1368c558-c58c-4574-907e-36b07dee31bb@sirena.org.uk>
 <6ee5d68a-fa54-4ed6-bc41-2bff0d9eb12f@redhat.com>
 <052dc756-cc05-4aa8-9724-14d42853089c@sirena.org.uk>
 <8a2ce635-58f4-44e1-a646-6527936c5836@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="v6cD9Anxo0FHLDGJ"
Content-Disposition: inline
In-Reply-To: <8a2ce635-58f4-44e1-a646-6527936c5836@redhat.com>
Precedence: bulk


--v6cD9Anxo0FHLDGJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 11, 2023 at 07:00:32PM +0100, David Hildenbrand wrote:
> On 11.12.23 18:32, Mark Brown wrote:
> > On Mon, Dec 11, 2023 at 05:53:59PM +0100, David Hildenbrand wrote:

> > > https://lkml.kernel.org/r/20231209020144.244759-1-jhubbard@nvidia.com

> > I mean, I guess people who don't want to install the headers are just
> > not going to be able to build a bunch of tests?  There definitely are a
> > bunch of tests where it's not needed so I can see why people would not
> > like being forced to do the headers step if they're only interested in
> > those tests.

> Yes. And before that, people mostly had no clue that headers had to be
> installed in order to compile successfully.

> So maybe a warning to give at least some hint might be reasonable.

That sounds sensible, especially if we could arrange to flag when the
specific tests being built need it.

--v6cD9Anxo0FHLDGJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV3arYACgkQJNaLcl1U
h9B1kwf9FSJkPhxe7Bh+LVMm9M/JwDNNcn4+8J9LLt5yC5m4APhXIPtgAzsQf7HZ
pA1lZh6HCE3f7G0WAFms4UkYnL4Sg+/5/1KIJmZZ8PiSelGBMEqQxhqJzWcI6za0
gZODJQZdI4yuMG7RLnVum7TzOenAd+7RpT8TOmcn/UM6BF8BWLg26DmB+Yf/Hf/f
gL0W3epHdBysAKO+esLc+6ifEBeokyHtETY9wNLHcKnA09K0YY0Jp55tfwbKvPgi
D8MyS+1kNPy2to2TMPGxhVilrB0zS0ifR8ELa+Dlnf3A0PfsBa2fdIeW2ARZ7+7C
UjMVDE+wbqAH29BU8bvGTEEha1jV1w==
=JgyN
-----END PGP SIGNATURE-----

--v6cD9Anxo0FHLDGJ--