Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <04d3806d-7d45-4166-917d-7250a2f5456f@amd.com>
Date:   Mon, 11 Dec 2023 13:12:38 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amd/display: Fix memory leak in dm_set_writeback()
Content-Language: en-US
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sherry Yang <sherry.yang@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sasha Levin <sashal@kernel.org>, Roman Li <roman.li@amd.com>,
        Claudio Suarez <cssk@net-c.es>, hongao <hongao@uniontech.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, error27@gmail.com,
        dan.carpenter@linaro.org
References: <20231208095825.1291730-1-harshit.m.mogalapalli@oracle.com>
From:   Alex Hung <alex.hung@amd.com>
In-Reply-To: <20231208095825.1291730-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmI5SUh1cm1OM2NqcTVzbWFXdkNpWmtLQ3lvOHdLa0g5YkJBT1dzS0czQTJS?=
 =?utf-8?B?akZFNHBQUitsU1pGeUdWY2xJNE5JNEt0THJIVjlRaTNkdG1wNzNtL2MrVlFl?=
 =?utf-8?B?V1pTYXhRbnlOYUxCV2Rpb2pSQnBhSGZEZ1JCR04zQ3NsV2tGMlNFNkZOQmJv?=
 =?utf-8?B?Y3dWWThPYWdjWmZ1OURUTVY3blJqL3J4eGt1SjhPNDVsdTY4ek1OTTdzd1Jj?=
 =?utf-8?B?U2M5S3poYnNmV1JqaDA0bm9obkt1MURidm9iQUE2UFlsaThjQWhZWS9XTmxU?=
 =?utf-8?B?aE9GYkR0eFg0TGR0T2RRQnBRMFA4cHZ5NzAzVzZ2SG05NlVmOGpmQTJKb0Zh?=
 =?utf-8?B?ZUwydnhDblZvSGJUQTNpUVpmVEU3L0FSSmNUbXNxWFBqWXpJRXZJT3RvR2pU?=
 =?utf-8?B?QTBRN25xWFg5aEtqVHBLRGRiV2s4dkFoYitXb0lhQUpDNWI2NWIyQXNVdXQ0?=
 =?utf-8?B?cEF1YXZHZWphYW1oTW1PZjhqOFlXOXNKbTFjclgzM2hwQ245RVFpM3Rwb01m?=
 =?utf-8?B?cU5DeTFVWnNBdHE2OWJKQ1g1Z1l2VjRhRDB1c2hoeC9yRkVrNXF0ZGdrY1Yv?=
 =?utf-8?B?elU1MlFDMDFJQmpma0dSV0pWL1A0U0J1M1NLQnRKSmR5QzhtK1NqTG9xTUNs?=
 =?utf-8?B?V1RDV1REL2VDS2lrK3VtVnh2dUNoeldtcVZtaWNOKzNkWU90Qkt5T0F4MGRo?=
 =?utf-8?B?b0M4b09pQ3FYQWNxOWt1MXlOdGw5M1dvVUdRcDZsZGlxTzM2aGN6UWFCUVd2?=
 =?utf-8?B?QnQ5cW4remM4ckMwTzRmZGlGU1kvRks2b1AvMkxlQ0d2M25hYTd1MTNLRVNG?=
 =?utf-8?B?akRudjlyWlhaZU1tbndsWG0wR3RZa2JzV1plK1k4M0JhellRS1AySEltUGJu?=
 =?utf-8?B?QlRwUnhjdmI2K0tQN0hkcmJwRFFZRHIxTWl0L3BzVXJnZUFHRnhzaS9IRHRj?=
 =?utf-8?B?ZUlVdW43WDhJY1BWNlRSRitrK2ZTcS9JZ2JCWVFHQStoQXgvYVNlN2dJSmE5?=
 =?utf-8?B?YzFabmk3eWRVVGdjbEcvU3hsdzRkZ2dVV3RDQ0M1aGVadVh1NitpUndNMEtR?=
 =?utf-8?B?V2s0NUQrY1M2ekNWZlgwdUgrd05YRzNUclF4MlVIdUU1b3lNZ2FEbGZrTjlS?=
 =?utf-8?B?T3dXUjVKVnVNeHl3Y1NSajRDdU54eDFwOFFCenRMcE4vWVV1NitYT3pJRnl4?=
 =?utf-8?B?cFY3bklUQWd4ZUVpRk85Z3B0UmpPRjRpUmhpMVl1bUhmVWdFZU5nMG5Pei9x?=
 =?utf-8?B?V1ZBRUJlOXFqdk1acUdmQ24reXQyb1JuMUpQenZ0UThXK2RXVGpoQU50VnNZ?=
 =?utf-8?B?YTFVTXFBdjdxemlIRUlnVFpVNGtOQjhiS0FTd3VrTGl3eWZVUm5adnYzSUxE?=
 =?utf-8?B?L1kyaDh3ZG9GL3J2V2ZkdVVBZUhvYVA2K0NWbHJ5SXE4WTROUWRhK1pGZVR3?=
 =?utf-8?B?cVFvelBEaGQya2ZkaTF1YkZMclNRTVRJL3JkSDU3WnRBRU1nSjgrQWRUYTBy?=
 =?utf-8?B?UmgwS0tXT1A3a1JvTmV1dXRsd1Bkb1dsRkZ1eEJwWlpuRDZ1bW8xZjFtbnhL?=
 =?utf-8?B?MVJlcitVV0RrcFhxVUhOSzlmMFE3Q2FtajUwM3d5WHBHclAvL1BpeHkrTXJO?=
 =?utf-8?B?bGs2ZEg3cW93a0ZLUVhIZmk0WGJ1VEJ3UXlOY1cyalgwRmtmMCtPVUxwdzFk?=
 =?utf-8?B?aGNqSkZPVUlkNmIyK3pqZ2pwVWliazlKb0VtaGcyQjZTVVdhT0EyQUliV2Rq?=
 =?utf-8?B?Z0s0T3R1d3BPQnRxdE9rMkpnTzR3Y055QXhuVUZFelJad0l2TDBIOGtySzVo?=
 =?utf-8?B?b0hqaG5PTmdzdkdvTldlV2FpT2Exc3hXWVhoNGtXZWhBZDNVTW9KekpIWHZZ?=
 =?utf-8?B?bVZqZEJLeC9LSkthT3VTazVNeWFaYnVCZnpzeHpLMUdZL1VXUTlqQVlkMXhT?=
 =?utf-8?B?VW4vc2N6WDQrOEJyQitBbEdKaEwvRVJvV2RaYzVnMVA3VGl6Z25PR29LS21G?=
 =?utf-8?B?clV1ZktUSUFQNFdtZTZYQjJJb0xDVGlYelcrTkRLR1JlYVVJMXJWc2JTZ0Vx?=
 =?utf-8?B?d2kyVG1IcWpSeEdhaEt4amVVZy9sRDhVL0Y1SUVnY0ZlODBSQldFejI1K1pu?=
 =?utf-8?Q?WiLaXQOICKcOYb2a8YqvAy11F?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 071ac3c3-351c-426c-ad40-08dbfa8589a7
X-MS-Exchange-CrossTenant-AuthSource: SA3PR12MB8802.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 20:12:45.1811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pSQvuIEn5JBwgP2Gm+0hbL+vn3ctFVUD7Kirt2rCVijjN4s3hF1wbnYVWZCwy7AUSuFopJnYfcgsIVggC4j5lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6754
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Dec 2023 12:12:55 -0800 (PST)

Thanks for catching this.

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 2023-12-08 02:58, Harshit Mogalapalli wrote:
> 'wb_info' needs to be freed on error paths or it would leak the memory.
> 
> Smatch pointed this out.
> 
> Fixes: c81e13b929df ("drm/amd/display: Hande writeback request from userspace")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis and only compile tested
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index afdcc43ea06c..333995f70239 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -8871,12 +8871,14 @@ static void dm_set_writeback(struct amdgpu_display_manager *dm,
>   	acrtc = to_amdgpu_crtc(wb_conn->encoder.crtc);
>   	if (!acrtc) {
>   		DRM_ERROR("no amdgpu_crtc found\n");
> +		kfree(wb_info);
>   		return;
>   	}
>   
>   	afb = to_amdgpu_framebuffer(new_con_state->writeback_job->fb);
>   	if (!afb) {
>   		DRM_ERROR("No amdgpu_framebuffer found\n");
> +		kfree(wb_info);
>   		return;
>   	}
>