Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Frank Li <Frank.Li@nxp.com>
To:     frank.li@nxp.com
Cc:     bhelgaas@google.com, conor+dt@kernel.org,
        devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org,
        hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de,
        krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
        l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        linux-imx@nxp.com, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, lpieralisi@kernel.org,
        manivannan.sadhasivam@linaro.org, robh@kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: [PATCH v3 10/13] PCI: imx6: Clean up get addr_space code
Date:   Mon, 11 Dec 2023 16:58:39 -0500
Message-Id: <20231211215842.134823-11-Frank.Li@nxp.com>
In-Reply-To: <20231211215842.134823-1-Frank.Li@nxp.com>
References: <20231211215842.134823-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jm2cUxnir1W/HaRcKKXDYx89XQDEHt3QSdI+Ih9JL0VUnNuiOkqNBX+AhJdP?=
 =?us-ascii?Q?QE/NyPBzb2P4l/JzczZV9PdjWPXsTUDJr24/mLYnzoTIfEZCnkszS+VLbhLU?=
 =?us-ascii?Q?NGZBb2CccxhjyqL7o05d2TFWBYJs6iyr/le6LhQwnTEi3T+Kn/TpZecE1h5z?=
 =?us-ascii?Q?U0J/6ZSW5w19rTCezg4a0x7bOgk5hfOByBfboNbVy71BxdDp1fYM0iEStTnp?=
 =?us-ascii?Q?fQHI7bJ7kb291W9I6rObIsotWoWYQE1W8nxibs5rbwYMH/ms+Vk9G3Vpe0u1?=
 =?us-ascii?Q?0hpggCwvP7IOMfTGamWlN9QJftCdHCAoFavPD++qxBxK1eaN+LizC5rqx+m0?=
 =?us-ascii?Q?L+V3pZfBnyu7ZNfYEa87ZUquL80bQ+ncoxz55W5AKAg+SAjTh+U793na1gx8?=
 =?us-ascii?Q?HjjYtWsZX6u4CngmBP8h0Sd9L2z2rJyLnG5ERIJm02E3GE1i+kQOeq2oJSsk?=
 =?us-ascii?Q?hq/QGOCzq1TFCHHVXJxRw/pJKz7Cp0Q+s+sqx3xJUIDx6JvMizeWk3pL1Q8t?=
 =?us-ascii?Q?R7ESDNihLCL/i2sfvX8slKCEoqpneAy87pyaqvWWYZ2SKlUdANl6PhdtLMGP?=
 =?us-ascii?Q?OU4DDJu4CJudCgfFfrsJUuuHw0Wu+YEHWVW7YwQRy0jWOILaBrOdztnCMKvH?=
 =?us-ascii?Q?MgPUC9gGdoYWUH9vcMbcFGZs82NrRoiU0qydpi4mCorZPRZTCeHnqHocu0qw?=
 =?us-ascii?Q?HnlD8mnlEMNxbNUF+L3TeHqe31m4nytkaTbpdA0bCCXI2tfKByHKGtz6oNDe?=
 =?us-ascii?Q?SU+mAB3C/DPGj1qp0xBC1QYWxaPIPVuBq5JZK/lxQihNDDoct8yn+rEyR2Ee?=
 =?us-ascii?Q?h2/Q8rKFPu22i/20qCehQChtDGylMJXrSUj3AKfi4j5D4NXhoqJ3yumRMUKi?=
 =?us-ascii?Q?hJjdh8BoLz7EmgO13XS6Ct/EgGpUIdLckShat/lBK2p3yqN4gDCM1fGrA2F2?=
 =?us-ascii?Q?WnQN/OmX5NtSUcqcsU+7utALSG3nUQ7I+SqZcaZ5M2VfQiYalhI5Pe5BIj4h?=
 =?us-ascii?Q?gAi+M++RQ2z6N9Jxk1muGRCBPKKXgmOk1GhHyFoxDV26lCejCphVNDJ/rrYs?=
 =?us-ascii?Q?uNRljlAUIKc1xlaIJaDTdCxstetTrw5E7Kx42TqWlB/zhW9AsFMWF1v6cmdT?=
 =?us-ascii?Q?C7/4mOAI9vjfrLHYes+mPAEMVw9FdCPc4LbAAB0lKmVSpCDX/IwShKwkUesW?=
 =?us-ascii?Q?vNYF505VgRy4pvY21pO/da5Pbxg6inLiqEDtCP+B9XqXhYneuEVOWD1gtyRu?=
 =?us-ascii?Q?7rGvQvPDhNOtCBXpOuDnMf3T2QfROdGUSdL04Vd/w4vgN5KJYb1QO7AghfJd?=
 =?us-ascii?Q?Ort2gx0WKD/JfQOnlLfTMvXF5qCs4kIz3CGK+nuQ3hSIK+ZoQLf5sycMwTNy?=
 =?us-ascii?Q?qClyCWpLckGJMPQBG0qW2LHhQF6RMw6O5i6Gqh6XMICKtSvgaybe0pCv28TT?=
 =?us-ascii?Q?dNOYa3YifWPDgLCKOdo5DD6nYPcqD/M/Bd0UbR7hEX/BWOJkXt28vK3Xq4V2?=
 =?us-ascii?Q?OJ83bvSL7G04GNx9OGGpT9RF6Y0ul9oGTSCEp0ThzTN7demHHnFgzShAGdZl?=
 =?us-ascii?Q?nIaDA3shAqyMywOzxD9kVMdYpCttheYKhK3zRnXj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1568c97e-dd86-4ad1-be57-08dbfa948da7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4845.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 22:00:14.5335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AwpIhNzJa4sG/ZNzpI9pEJstewcQiJH6ybOcWyKs7SC6mXFqWJnyYFs4LR/HXK/6r+prann2UJoRGY6A3ty5+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7569
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Dec 2023 14:01:12 -0800 (PST)

The common dw_pcie_ep_init() already do the same thing. Needn't platform
driver do it again.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v1 to v3
    - new patches

 drivers/pci/controller/dwc/pci-imx6.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 99022efe27334..eb4e954e3a167 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1116,7 +1116,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 	int ret;
 	unsigned int pcie_dbi2_offset;
 	struct dw_pcie_ep *ep;
-	struct resource *res;
 	struct dw_pcie *pci = imx6_pcie->pci;
 	struct dw_pcie_rp *pp = &pci->pp;
 	struct device *dev = pci->dev;
@@ -1135,14 +1134,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 		pcie_dbi2_offset = SZ_4K;
 		break;
 	}
-	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
-	if (!res)
-		return -EINVAL;
 
-	ep->phys_base = res->start;
-	ep->addr_size = resource_size(res);
-	ep->page_size = SZ_64K;
+	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
 
 	ret = dw_pcie_ep_init(ep);
 	if (ret) {
-- 
2.34.1