Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231208061407.2125867-1-yuzhao@google.com> <20231208061407.2125867-2-yuzhao@google.com>
 <20231208110011.102-1-hdanton@sina.com>
In-Reply-To: <20231208110011.102-1-hdanton@sina.com>
From:   Yu Zhao <yuzhao@google.com>
Date:   Mon, 11 Dec 2023 15:01:11 -0700
Message-ID: <CAOUHufacCTtUE6y1x5j+6Hp3SGtWu1-u38JHTR1z6JqU4cU8_Q@mail.gmail.com>
Subject: Re: [PATCH mm-unstable v1 2/4] mm/mglru: try to stop at high watermarks
To:     Hillf Danton <hdanton@sina.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Charan Teja Kalla <quic_charante@quicinc.com>,
        Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
        Kalesh Singh <kaleshsingh@google.com>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Dec 8, 2023 at 4:00=E2=80=AFAM Hillf Danton <hdanton@sina.com> wrot=
e:
>
> On Thu,  7 Dec 2023 23:14:05 -0700 Yu Zhao <yuzhao@google.com>
> > -static unsigned long get_nr_to_reclaim(struct scan_control *sc)
> > +static bool should_abort_scan(struct lruvec *lruvec, struct scan_contr=
ol *sc)
> >  {
> > +     int i;
> > +     enum zone_watermarks mark;
> > +
> >       /* don't abort memcg reclaim to ensure fairness */
> >       if (!root_reclaim(sc))
> > -             return -1;
> > +             return false;
> >
> > -     return max(sc->nr_to_reclaim, compact_gap(sc->order));
> > +     if (sc->nr_reclaimed >=3D max(sc->nr_to_reclaim, compact_gap(sc->=
order)))
> > +             return true;
> > +
> > +     /* check the order to exclude compaction-induced reclaim */
> > +     if (!current_is_kswapd() || sc->order)
> > +             return false;
> > +
> > +     mark =3D sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERI=
NG ?
> > +            WMARK_PROMO : WMARK_HIGH;
> > +
> > +     for (i =3D 0; i <=3D sc->reclaim_idx; i++) {
> > +             struct zone *zone =3D lruvec_pgdat(lruvec)->node_zones + =
i;
> > +             unsigned long size =3D wmark_pages(zone, mark) + MIN_LRU_=
BATCH;
> > +
> > +             if (managed_zone(zone) && !zone_watermark_ok(zone, 0, siz=
e, sc->reclaim_idx, 0))
> > +                     return false;
> > +     }
> > +
> > +     /* kswapd should abort if all eligible zones are safe */
>
> This comment does not align with 86c79f6b5426
> ("mm: vmscan: do not reclaim from kswapd if there is any eligible zone").
> Any thing special here?

I don't see how they are not: they essentially say the same thing ("no
more than needed") but with different units: zones or pages. IOW,
don't reclaim from more zones or pages than needed.