Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   =?UTF-8?q?Micha=C5=82=20Winiarski?= <michal.winiarski@intel.com>
To:     <intel-xe@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Michal Wajdeczko <michal.wajdeczko@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Javier Martinez Canillas <javierm@redhat.com>,
        =?UTF-8?q?Ma=C3=ADra=20Canal?= <mcanal@igalia.com>,
        =?UTF-8?q?Micha=C5=82=20Winiarski?= <michal.winiarski@intel.com>
Subject: [PATCH v3 3/3] drm/tests: managed: Add a simple test for drmm_managed_release
Date:   Mon, 11 Dec 2023 23:09:39 +0100
Message-ID: <20231211220939.215024-4-michal.winiarski@intel.com>
In-Reply-To: <20231211220939.215024-1-michal.winiarski@intel.com>
References: <20231211220939.215024-1-michal.winiarski@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VS9RaGRJQ28va3hwNjhRZTROVGdrRFcrM2ZENWhtdUsrTjBkWEFPYTFLdVVs?=
 =?utf-8?B?TkFJTVFINkh3dXVRYWRqZ214ZEUySm9JNlJkV2ZZYXVDSHdqN3RmUWM3TGhF?=
 =?utf-8?B?UGpoeWM1cjF4a0FKeFMya3d4TDJ4aUFoN1hpaFVxdm9nR2ZzRXFYa2lZRWZK?=
 =?utf-8?B?eXlxTVJUWmdHN3U5MEhEaVRld2pldG1kdStoL21veUhKeUpXNW94Vi91amha?=
 =?utf-8?B?OTVmM0RYc2ZYTU9Ia3V1S2hvVUlpOWF6V2Z6VmtuMDhnWWNBb0RjZUZWMWlu?=
 =?utf-8?B?TURwaFMxTUUrZUdmdGhtS2RBTzRmZHFGV3I3WGV2WFpiY0JkTFhvcFN6UXVU?=
 =?utf-8?B?MzlCWm13Q2hYeC9DNngwZlhJSThwdUt3Z3BjUG1tZVhKN04vTjBkRUlnN2Fn?=
 =?utf-8?B?UGNWMjJMNDd2Vjh5RlkvbkYvK2dkeWlRaVFUZjF6eXFFdVRvcjFkSjVaUmNp?=
 =?utf-8?B?MkJ3VlR0ZmFid1paaDJ1bUJyZFdsTGRIanJVbVI2M21pQnhhVlo2N21LZFhs?=
 =?utf-8?B?MzE3TW81UnJLeFR0Yjl6NE52OHpBSmo1V1V5UEl3TXdjbUZ5OU53bENmVldL?=
 =?utf-8?B?NjAwOXBMNjVYM1pndTZGYWR0MlBCeGpaNHppQTdnQzN0ZHdhemIyNXp0Wmxa?=
 =?utf-8?B?VEVZSklSSFVJdWRHQ2tpMWx6R0VyWVVSM2Rxb2lpN0FQN2hhMitDa3IxL0pP?=
 =?utf-8?B?V2Z0UjllM0ZyVWNzQUw5ZUNWZTdXeGFyTUl1MGpTVDgrNUYzaXM5TTNlN0N3?=
 =?utf-8?B?Vlg4Uit1dXBUVS9CYVVqdHhCajU2MEJ1RmNkYzdzczg3NUpiSUxjaUxQazZV?=
 =?utf-8?B?Z0RVREdJWlVzeWYxRlRZVGRZKy9IWGJNTXExUjBxTmNJTW52NlZyZ2tQc0Vi?=
 =?utf-8?B?T0pmNzg4cDBlQXNmSHMyT0VIZGl0YzVvNG5UeHJUTDU0WnphQ0xtMXZpc2g5?=
 =?utf-8?B?UFl3cjRTbFRFRGxzYVUwSnRvaDFVUEhiUkg3M3NkRGZWbHdUTmJnYTZjdDVQ?=
 =?utf-8?B?QlJtaHZPUTVqTTgxZG1IbFJxOENYZ0trTDc5MTl3QXA1UXRJcVBkQ2hXZUxq?=
 =?utf-8?B?czcrSDRSSmhnMGdHWGdJSkU0a1lqbnVUbyt6M3BqOGYxcXNEcDYxRzZsM0Vo?=
 =?utf-8?B?dDQxYzQ5bmFtaUxmdnBza3ZGK2xtbUtyemhuQ0piWlFWVnlubm94TkZ6dk9n?=
 =?utf-8?B?MVF3WVUxdjFRRTIwdEVNUmxFY1pKSUZQTEl2V3VCeXJPQURjTEJiMkFBTGdr?=
 =?utf-8?B?cGthSFMyWWRVVmhSeGIxUWs1ajVPNkUwUUx6anVTSDBhUzFQdThiTHU5WmUz?=
 =?utf-8?B?NDFYTWFmdm9YL3VkR1VaS2Y2RHBLMUJZQUJBcVE1SHk3dnhSVXlqa0k2OEZG?=
 =?utf-8?B?RkpvWUh1U1dyZmJyTnBqT29ETDNPUmtNUlh3TkZ6K0s0b0hzRVEzOXNlN2NY?=
 =?utf-8?B?cFhSK3JoN3djZ0pla3BCekFqMHFUQ0xiT0QyeUVVOTF2cHA0UWgyVTNQZVJ2?=
 =?utf-8?B?dXA4QXo1aUlHRDJyK0VTS2xMQWxOdTJPZkZyZWdNemRZUGo4Q0V5em92c1FH?=
 =?utf-8?B?SW9UOVp4RjRvNSszVW9qbVdJckJJTkw1cU9zTGs2bHNTdzRrYWxzbExURkhi?=
 =?utf-8?B?TTEzdlpUWFVFZmxLOXo1N2x1VDJJZkFGMzErd1B0YzlXVHJSdS9hcitkeFdF?=
 =?utf-8?B?VUpuNHBzWEtOWmlJcmh0QnYrSTBCNG1SbkdqTUEwWGhlUTVEWDJXMmNoTm9G?=
 =?utf-8?B?dXNHS2tPWVNTZWlWaXdRZ0lkZ0ZqdHpkRGMvK0VlYVJsZ1hpWU90SUZ4M2cx?=
 =?utf-8?B?aEVnZ201by9QUnE1L1NhRUQvb1pPZys3VE1EQjZlRXQxL3F0MFV1MU9IeGRk?=
 =?utf-8?B?dnZBcWtPbndsbmZocHRvYVd2Q05XdFlSaGRxVVJDTkdvSlBpZTc1ejg0MXo4?=
 =?utf-8?B?bmtzUGZXY3ZEQlpndWREMWlxYUtyM0xOeiswOFNZQnBPSndiYXhmQjkyYWN3?=
 =?utf-8?B?cW8wWGFUK295RmowRStncHYrQ2RWc2oyWkRhN0tDMXFRZlVlYndESXJ0c2dl?=
 =?utf-8?B?R08xVlcxaTBESnNxbGR0Z2EraUI4SkM1alF3TS8vbDc4ZEE3RytpNkxxbm5G?=
 =?utf-8?B?dlNNZThYRlpUaHFucVRLYTFGbHRrb0NZNGx1ZFBvYkZyMHNrSlNCSTVXRkRJ?=
 =?utf-8?B?anc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a2368c8-8bc4-47df-d741-08dbfa95e8c8
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 22:09:56.6894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ahbY00DytmGXK8nVU1RGxBMvjK8uoztiHm2PSRipO560a8g8/LWzjlW9TdWYAZ8EIXIWzGhf5QOKXx+O/8wVGiuTbn+QslZebnnzwLKD6ss=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8134
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 11 Dec 2023 14:10:38 -0800 (PST)

Add a simple test that checks whether the action is indeed called right
away and that it is not called on the final drm_dev_put().

Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
 drivers/gpu/drm/tests/drm_managed_test.c | 29 ++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c
index 15bd2474440b5..ef5e784afbc6d 100644
--- a/drivers/gpu/drm/tests/drm_managed_test.c
+++ b/drivers/gpu/drm/tests/drm_managed_test.c
@@ -48,6 +48,34 @@ static void drm_test_managed_run_action(struct kunit *test)
 	KUNIT_EXPECT_GT_MSG(test, ret, 0, "Release action was not called");
 }
 
+/*
+ * The test verifies that the release action is called immediately when
+ * drmm_release_action is called and that it is not called for a second time
+ * when the device is released.
+ */
+static void drm_test_managed_release_action(struct kunit *test)
+{
+	struct managed_test_priv *priv = test->priv;
+	int ret;
+
+	ret = drmm_add_action_or_reset(priv->drm, drm_action, priv);
+	KUNIT_EXPECT_EQ(test, ret, 0);
+
+	ret = drm_dev_register(priv->drm, 0);
+	KUNIT_ASSERT_EQ(test, ret, 0);
+
+	drmm_release_action(priv->drm, drm_action, priv);
+	KUNIT_EXPECT_TRUE_MSG(test, priv->action_done, "Release action was not called");
+	priv->action_done = false;
+
+	drm_dev_unregister(priv->drm);
+	drm_kunit_helper_free_device(test, priv->drm->dev);
+
+	ret = wait_event_interruptible_timeout(priv->action_wq, priv->action_done,
+					       msecs_to_jiffies(TEST_TIMEOUT_MS));
+	KUNIT_EXPECT_EQ_MSG(test, ret, 0, "Unexpected release action call during cleanup");
+}
+
 static int drm_managed_test_init(struct kunit *test)
 {
 	struct managed_test_priv *priv;
@@ -76,6 +104,7 @@ static int drm_managed_test_init(struct kunit *test)
 }
 
 static struct kunit_case drm_managed_tests[] = {
+	KUNIT_CASE(drm_test_managed_release_action),
 	KUNIT_CASE(drm_test_managed_run_action),
 	{}
 };
-- 
2.43.0