Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4290090rdb; Mon, 11 Dec 2023 14:59:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlLL6NP529kge8B70t+MkudsRlweuTRS255C7bELZo0/H9NMcV/M4BlJQQrecjbxDr9+CK X-Received: by 2002:a9d:7743:0:b0:6d9:eaa2:6e1 with SMTP id t3-20020a9d7743000000b006d9eaa206e1mr4936721otl.16.1702335596470; Mon, 11 Dec 2023 14:59:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702335596; cv=none; d=google.com; s=arc-20160816; b=C1r14lHpOFl5jXE6E5afka5DJVdKeSNKdTiBIzql7EaTuZtoVY5ZwQjMvGU7YOCNJ3 r0RyuTxkkAawapJPP/Pt+Nbnt84/yxnZNWneK6JYJN4b694s74WY4vnNOeZFFtLky2zE LwmxCyDE4SP34DidWd8CEHXDjiok6U9E+GTgnl92dTKVG+p3vDpTgXznzgPBqggpesX4 BzdUELaU42pddXxWF6H7Xe9VBaHo1Xe+OTDPXJkWGz4CMJI5lNnkqGrYHJe9veyw5J6j rHwV0DFopCu+bEHtFtDUT7ntnjHsmE4ftMaURqpAw+m2S0glcmWYgNn/vwjdao3T4UBK IMZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=cEg+1VeWVOypnlUa2QrN/Z1IX3hfyYm58Ri49DQ91RQ=; fh=q3yb125/9xRK/blaJjfFTp4bp4fmDd+c2N6BUJ4n4mQ=; b=y/4NA4oDSV4FZZaPA92oMnqRHvF/7koGYWi5UVzT922+0JTuBkOLn1UzhPLrZv1A+z e2pbMNjArbRfD4CjLW7kGxyaF1QAxnKXJJDaQWs7NUjD4W9WhCTDJlVSpCM43j+cMWdg 2ebxvNO0Ixlbmn5maJ9uLySKua8HrafbEcK9pHmeYdSGarCleXXGJ2pCS1lwNlhctVGW zlqOBibUUkE2eE2zlJGDi+/I/hr4ni5JezbZcfThNDBr4vg2T71zLpmYDsBZyUcF9xK0 N91rCRkMSvFqK8B7EAZbrhbCTb+U+l8bm3bi+PzJ2UE6Uvuz/D9WJcuc5wWZYN+GNbM0 CoDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="V/ayCjsP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id 19-20020a631753000000b005c668dc242asi6733927pgx.162.2023.12.11.14.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 14:59:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="V/ayCjsP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3CFE38057E7E; Mon, 11 Dec 2023 14:59:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345198AbjLKW7k (ORCPT + 99 others); Mon, 11 Dec 2023 17:59:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345166AbjLKW7j (ORCPT ); Mon, 11 Dec 2023 17:59:39 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B1E9A for ; Mon, 11 Dec 2023 14:59:46 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C5B7C433C8; Mon, 11 Dec 2023 22:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702335585; bh=t7nQKTTeGh65bU29w+Bc8SK2+uEhQ8nX0LrViq7JYqk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V/ayCjsP1FkvVFM17OEH03CfEKEOd2MP64ffO019moohHMBAdYMxM5wQ7lLiPowaw gxescu6QOlqk99izlWGLWswXQLkz5ItDrmoIvvWQodLnU/faMboH+eT+XG0OrS1Q2h tRi4+rt1enNLzJtYP+djQEOAHnND0Sz51/8/5xFqWeXdymJfoZ9AdvRT6fsuKu/EfF WLPhwPCLSMFAewuDZvjD4tNBsUa3gJpGoyIren8v1orQnVNzQnDK1BDCpiYv7in+2X sxXVAxPiGeW3FNMlzlnF2SAmfftk6XZwbbKVPltqcpp9HpRvIPK/zFqQpkdVC8UwhT hfmR1+icdW39A== Date: Mon, 11 Dec 2023 14:59:44 -0800 From: Jakub Kicinski To: Serge Semin Cc: Jianheng Zhang , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , "open list:STMMAC ETHERNET DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" , open list , James Li , Martin McKenny Subject: Re: [PATCH net-next] net: stmmac: xgmac3+: add FPE handshaking support Message-ID: <20231211145944.0be51404@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Dec 2023 14:59:54 -0800 (PST) On Mon, 11 Dec 2023 14:14:00 +0300 Serge Semin wrote: > Although in this case AFAICS the implementation is simpler and the > only difference is in the CSR offset and the frame preemption residue > queue ID setting. All of that can be easily solved in the same way as > it was done for EST (see the link above). > > Jakub, what do you think? Yup, less code duplication would be great. Highest prio, tho, is to focus on Vladimir's comment around this driver seemingly implementing FPE but not using the common ethtool APIs to configure it, yet :(