Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 11 Dec 2023 15:01:29 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Shiju Jose <shiju.jose@huawei.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 6/6] cxl/memdev: Register for and process CPER events
Message-ID: <657794c952e19_2090d82947c@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v1-0-d19f1ac18ab6@intel.com>
 <20230601-cxl-cper-v1-6-d19f1ac18ab6@intel.com>
 <657279a68c270_b991294e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <657371eec6ac5_1e7d272948d@iweiny-mobl.notmuch>
 <65738e9fc239a_45e0129476@dwillia2-xfh.jf.intel.com.notmuch>
 <65775c98e0b39_1f2db42944f@iweiny-mobl.notmuch>
 <65775ffa7e529_a04c52941d@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <65775ffa7e529_a04c52941d@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+7B2qvW1wy9r5u4Hg0m+JIRrqXuDlnNar5An6LkeIYwi3HLCtUUM+/UrB5r6?=
 =?us-ascii?Q?UK2wwlnen9OMAbSuEZljTk1grK+/Zx74ltWOAJGyfWznO7NALSaKKg08gc7K?=
 =?us-ascii?Q?i8zvDdnUMyoYKcVA25tXzcwzMtLC5GsmRff3QoBnL7FkKu9gXYgZoCNqoFI6?=
 =?us-ascii?Q?HX66oMIlbWAgQUwPhGHVbbtl6iPpFTmm444Zwa9RBa1W/VjCRqQ+jtnzjyVn?=
 =?us-ascii?Q?0crLSnIO9g+U46seokk6AgAITmpJlGdA96No4juBQuPqpN9iaaLvRcZ8PYoe?=
 =?us-ascii?Q?79IFRMkJHhChvw7b4WLir9szx1i+1lU0QjW5Sq16ZXSY+WF605MKRdWhu0dv?=
 =?us-ascii?Q?4IKylSk2ZDcQhb+PK780eizZz6m3quLr7Hyfv7wcOJ/7P/ZqY0HnWrguA8y0?=
 =?us-ascii?Q?+yxSd8sNufPTEKdrUD82k1xQzncWiF/QaRyApqhjChOb09s1twceWjqbNTBj?=
 =?us-ascii?Q?tUSZcCuVF8lRNfLV6Na1N80Z7DGBaKN7ujtRxU+XoQmxxt0aXW7r0xUDqp0T?=
 =?us-ascii?Q?6OPGhBijV+N7Sf0TY9aOGdlBedtsmkGtKyLMCJgJ+bV+kVc6tQqC0iZOmhoY?=
 =?us-ascii?Q?ohfmQRGN8xyQzucf/vB2GMk+tfae09/mzjNkZlOR43xdPe7YHoj29Le7DhAJ?=
 =?us-ascii?Q?i2uoMujCW03I4hsbdipAZxshZSNh3BeuOI0BVCy73dy9KSewrcZ05qPmL66e?=
 =?us-ascii?Q?1FW1sjfblprHDV12+CrK5mcCx+u9zAGM4Ypm3Dcy1LwrsUeJlU9VGq5yhRVp?=
 =?us-ascii?Q?JhshtRnZEmB21+tqSJd0HIY4RcPqfDuy0/dPIiP63G0S7W77jx6oPO3hD6Zm?=
 =?us-ascii?Q?J/4qbYA9wi+87X3sVvGFwQ6vJi/3Sjkzj9+DhaOS6VcmnDotJOtgyNlE+Kp9?=
 =?us-ascii?Q?+yRy/wNzyoeDRpAk7P3v+cbLIk8E8D4zzidqN3ZuVvqXqE/BLw3ahlohBgfW?=
 =?us-ascii?Q?U8fRldHLNxkv8PT0jeVaqCLalRZQQS56F7dXaifYEPS5ApVra+OTUyU3QaXA?=
 =?us-ascii?Q?1oh1OzadoecIzeixeTkW0zrf3+xmh70YaUxqlE7Zd8KDOcyTzMYrSFN9c9fP?=
 =?us-ascii?Q?3hwMzG4jecuJ5Ii+Zf1ojq9uTUaSAyJ5cSxrQrAtaQWoOcS0rIIbg8HC0qKx?=
 =?us-ascii?Q?/hVjSZBFDy1M+D1+kjj2k5XTK5q39m78d147ZMIlezIYxpwhsEd7IAlHk1QS?=
 =?us-ascii?Q?Sd5ROdF4nMASSJ6l31l2AzlMCXnJxjtUqnC0QWSQqH6ryln7dVI27ryHh9ik?=
 =?us-ascii?Q?Mqh531HmTUttwMrYWVO/8HzbOf7IYbAuntstyzEquLk9R893/Pl0sSakY9yK?=
 =?us-ascii?Q?n9S3Mvxf7yTlrr7oSHOA/IAw5jd68ewQIQtJJf9kRYiweWvM6OvppXvdHNh3?=
 =?us-ascii?Q?XcMHIHO6akJz4n5VL74NU08mz/vKZM9FPTwcYHgOxydj5dwYtlSIlUkHFcwC?=
 =?us-ascii?Q?ooxX/IC6Yggae5etRoYYKygfleIPRxrdTrRg+ho/twDszqnjVBXyQl8nlG6B?=
 =?us-ascii?Q?ysBwK4senu9oeLRyehnQ/bvVFWTQsmNe1oLXs6Yb6LTx6Sv6w0rJEy1eJNOK?=
 =?us-ascii?Q?UM2pcYJJGz6Bj3+P+IgFUksI3uLo9dRDy2as+GMR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ab346321-2471-447b-905d-08dbfa9d1e47
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 23:01:33.3563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8zSfkQPq0+L+cAwK7VVgtQyGHCnoAJWvGA0TTpQbUP9fWM2OQR5FsaFDtP/wniV34mQzgkuaMfSm1BAhyodFdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4813
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Dec 2023 15:01:49 -0800 (PST)

Dan Williams wrote:
> Ira Weiny wrote:
> > Dan Williams wrote:
> > > Ira Weiny wrote:
> > > > Dan Williams wrote:
> > > > > Ira Weiny wrote:
> > > > 
> > > 
> > 
> > [snip]
> > 
> > > 
> > > > #define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> > > > static void cxl_cper_event_call(struct cxl_cper_notifier_data *nd)
> > > 
> > > Is struct cxl_cper_notifier_data needed anymore, just pass the record
> > > reference?
> > 
> > I think so because the type of record is ID'ed by the GUID which is not
> > part of the common record.  So the notifier data adds the cxl_event_type
> > enum.
> 
> Ah, yup, but then I wonder if CPER can just do the GUID to type enum
> lookup and keep the CXL side GUID-free? I.e. just pass the type as a
> separate argument.

Just saw this after I sent V2.  Yes the CXL side is GUID free, has been
since an early RFC.  But the data structure has the event in it.

If you want I can change the callback signature but it seems reasonable to
me as it is in V2.

Sorry for not catching this before I sent it out,
Ira