Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4301453rdb; Mon, 11 Dec 2023 15:22:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrAkI2SE528Iud0jyWYWkb2E5Fc4JMa/W91Tfe8xBym4FTLtrZYkr7F5ap8TXRotAF2QAA X-Received: by 2002:a17:90a:744e:b0:285:9940:1bac with SMTP id o14-20020a17090a744e00b0028599401bacmr2109922pjk.2.1702336927363; Mon, 11 Dec 2023 15:22:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702336927; cv=none; d=google.com; s=arc-20160816; b=v2Rtr8lsUNeWP70NUUM8XuQmCEASheNTQlaNlkX7W0t46tUup59uNW2vuIxQQa0KaB 9erYAx8tnBYMDRNHkK8tsSANatddO4rgupLBZMmuNbtKDXTzTKW2n6FJTSGFXYJjK7pr JBdNoU08uxfe5rtN174yYzfj65pPh7/pgfCAHr36fHUgFWvb2jfd/8cyw8U6gO44kCYb i55jUX31nOKS+hl/yE6jYUWzLQQknw2T1XYJQHRZFRrnzQGKdLnLnfdb/SNsqX/wckW2 hRtk6HJ3QrXBqE8DUKB8eZ9un2TRALxG02VOTe2fjNAdA5SyvhyW1epePiQvuVbN5ygh F7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=RctkjfZ/uke+J5C79Z3MVEHpAx1sc8x3waMFXiBIDT4=; fh=vaHvuUcH3HmeAkXKsgPSnkfTzSQPpLrlAW0I1TORSQ8=; b=bevfUPRvo1Zt0jZpy5NUaI2fZp9vhwzi4BCeKvnuFMcoTazTYGnFKXZNGsWXOUKjN1 XuRUxGFjuGUAWzWEkPL4T4apQr5cQnKVW5qw7qt46toO7IVCTa0OJUkow+wp/VU5MMD9 CqO2un2VH0r2LeAtq7NPq8c2awlTL8qNdOVvFEglgVNCN6FwF9eMYp/7brLk14nTCtx6 86PkGnwZFuHjO+AeHFgCXU4bXKY3iYUEF/hcVf9BsdiolSYWLMg+vRyca4kbav+mnPEG +vGJ2D9wJ0t9WXKqXImtBzz1SyCt8+HY8UN9ZsJKK9UHw4TlEKImw4GIzzooCKF+cltj 5vog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codewreck.org header.s=2 header.b=JjIdSjMj; dkim=pass header.i=@codewreck.org header.s=2 header.b=Odnq8u7w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codewreck.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id gl8-20020a17090b120800b002887be71d7dsi8202148pjb.150.2023.12.11.15.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 15:22:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@codewreck.org header.s=2 header.b=JjIdSjMj; dkim=pass header.i=@codewreck.org header.s=2 header.b=Odnq8u7w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codewreck.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 593118090FBD; Mon, 11 Dec 2023 15:22:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345264AbjLKXV4 (ORCPT + 99 others); Mon, 11 Dec 2023 18:21:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345168AbjLKXVy (ORCPT ); Mon, 11 Dec 2023 18:21:54 -0500 Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E362BD1; Mon, 11 Dec 2023 15:21:58 -0800 (PST) Received: by nautica.notk.org (Postfix, from userid 108) id 6543DC01F; Tue, 12 Dec 2023 00:21:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1702336917; bh=RctkjfZ/uke+J5C79Z3MVEHpAx1sc8x3waMFXiBIDT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JjIdSjMjQL1JNut9IMYjBi4vvLTZvW49XIyfzyrcGkc9fQ85zliwL6U6rxPDPqMmb IXzxVpNzwNpm97PPSpYXVUZAE3dg0r0R71S9J6MmumATGg73Dqp/fygMtBgNfUjEs8 fgJqGNO9W20aCUKHSoh4ff0Yzkh40KTKGWPooQ9uLN91kHumfHfTt+Fzvqn8iW8mlJ MOqbA1mzfpFl5jxissQRMP6m+DtPkQxKmK2ACnZRe2QUuVhcLgYDzKP+4dAJzdtU2t 03DbS0O0ojMCYpD3yVAwIK27C1QvWqTXHGlK2crugSrn26iKGmIyoC7GYCHJ8HVIs0 aFmdgfL+pCmfg== X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 82DE3C009; Tue, 12 Dec 2023 00:21:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1702336916; bh=RctkjfZ/uke+J5C79Z3MVEHpAx1sc8x3waMFXiBIDT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Odnq8u7wg88pa7i3Cw+3L4vmH+F6XkDUyoXumbgLwUo0ceDH5mmCZKmL+hTZvzKe5 8bAGrTyAen597zv7HoUof6QTJhO05gha1cqezTNsi1RdU/ogMJaPdnYUZdySGfCApi fK3f9zVZGAVCVWOh2f70vqExnq1KfWQFQAskQnWYbfY+Zr8pTllIw42f7iPg3qdfVI Ed/m06uM6UwZdHHIIodZBe1uekJO/U4+jBw5N4h0YLJDb7WcPNhkfRjXw81x+Xj2IN uijtgLj1G550fCAoVd8OgoO+5cFpjGaZHNGoIDZy0+ETkig9erb0BiOGNkLtrG9VIt occqrp8xWhEuA== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id 4e583e84; Mon, 11 Dec 2023 23:21:45 +0000 (UTC) Date: Tue, 12 Dec 2023 08:21:30 +0900 From: Dominique Martinet To: Christian Schoenebeck Cc: Fedor Pchelkin , Eric Van Hensbergen , Latchesar Ionkov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , v9fs@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH v4] net: 9p: avoid freeing uninit memory in p9pdu_vreadf Message-ID: References: <20231206200913.16135-1-pchelkin@ispras.ru> <1808202.Umia7laAZq@silver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1808202.Umia7laAZq@silver> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Dec 2023 15:22:06 -0800 (PST) Christian Schoenebeck wrote on Thu, Dec 07, 2023 at 01:54:02PM +0100: > I just checked whether this could create a leak, but it looks clean, so LGTM: Right, either version look good to me. I don't have a hard preference here, I've finished testing and just updated the patch -- thanks for your comments & review (and thanks Simon as well!) -- Dominique Martinet | Asmadeus