Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Peng Fan <peng.fan@nxp.com>
To:     Kuan-Wei Chiu <visitorckw@gmail.com>,
        "abelvesa@kernel.org" <abelvesa@kernel.org>
CC:     "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clk: imx: scu: Fix memory leak in __imx_clk_gpr_scu()
Thread-Topic: [PATCH] clk: imx: scu: Fix memory leak in __imx_clk_gpr_scu()
Thread-Index: AQHaK40Eq3qRKXwHhEOi0TlJexr4/rCk0GPg
Date:   Tue, 12 Dec 2023 00:40:24 +0000
Message-ID: <DU0PR04MB9417FB5A373326F954EB7CC3888EA@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20231210171907.3410922-1-visitorckw@gmail.com>
In-Reply-To: <20231210171907.3410922-1-visitorckw@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OxWS0AzsKVackWPNU9bhAVmQ/fTx0DdkPyidJovEBQRgqaNLFmpmW5lGqtz5?=
 =?us-ascii?Q?PoSa5z+tCERShlHw6pmd2RqmxqXbqNlD9CBs0VwSH+L48qGSNzvKW0mKzcuf?=
 =?us-ascii?Q?aY60aG3ezaDxOg5dloeyXnOTqHP2fcwM9cuxVREtaHxr+NfmtdjuobzZXX8h?=
 =?us-ascii?Q?jMl7HjSAK5RhVEDNNI9XHi7PS9CPzN7c6Yf1qKKHwBaBrHajswsYR+PmX3Vx?=
 =?us-ascii?Q?zvUurMsZR2qYiwnetJWI5gc+A1tvb1dT2ESMlqU59I4U6sc3McVD+7ybsPQW?=
 =?us-ascii?Q?14R371IpKoG26JhlTz0c0EXhTEJ7UTDh7OAYGfIzs4E6woPbCylffM/yqttt?=
 =?us-ascii?Q?WZdcMwvZW/ZsKrUFxRDR6XQB5QqJ5WJA6P2SiT92h1Yx6kJmIBYrPVNnLSsf?=
 =?us-ascii?Q?oOq8rXzPJ7tB2pSUTpZpQZUpRunqQxuHDYIPPTqKRMxaPxGPJCX9i/y7+mOg?=
 =?us-ascii?Q?cL2apFUuiT7IbchyYB0PaRoScAzvn+IOOI/eYHpxMV4GHpfUETvcxkulOZbS?=
 =?us-ascii?Q?rkm8OceKADSKBjGbX3vVdwba7vvqXgIBK2iv2gDDdTiQYX47yWAQvY8kL8f/?=
 =?us-ascii?Q?c1qYOgRXgVQNLu7slZgTFSHkcnXZwn01YJpSUxaJSMt9S5rX9JciB/bAeKrt?=
 =?us-ascii?Q?VMlaohM2emDt3B34mAlyuQS8P/ynsHxKoQVj4QlZyiTL5mHeZroHGNV8nH1m?=
 =?us-ascii?Q?Qd8MEWhBZ1+o4NTUjUSyjQpzUHyiam6h17w92s1OAxOWhh+jh5+ubm83ANMs?=
 =?us-ascii?Q?tJXoFjTWNNFnKBZdAxSJKkrnWDAJFdfXZlm8LimS6tpFlgFp3AzcyXh+RvfC?=
 =?us-ascii?Q?vMQpT6FkWPw7wnHimozcjVJdpGTJcQyg7rS8PdTXt1AYFZxLW1szBz7OZPMc?=
 =?us-ascii?Q?5cAnLydRiMTKVGOaaOnsRLtSrQLh/aEoxlQT56U6CK5rWFX20EiCWOYJkhfa?=
 =?us-ascii?Q?SppEGZXRRSlSUzFwIcjiMapCV5ZfeGdplqS6URrym+YxxoUYk7QpL9ktKgz/?=
 =?us-ascii?Q?DzOTOthyyEepkzXCWu9Wv9iwjqbN+jtCXD1yFneGm9sruh3Ky4FeJBjbPqCO?=
 =?us-ascii?Q?/MtwsDG8DXWM1XosQtV248ai/24bsUIXNFXKt67BAdDE7AG6fu5rbabWONHf?=
 =?us-ascii?Q?uO31TJVuWaC8Mut5oicVYDOZXHdLd23E/FwQHHnhZ6CrwmPp+uxC4ku3cde4?=
 =?us-ascii?Q?bJ8hvl3zn9EYymMYwWt4gpJ70mEFGorLUEsVg8KSM+kMqHtsi6OR3xfd9wi1?=
 =?us-ascii?Q?iOkS0IyVguwXjFaA57iJonxCmRIZHxiC0KLDWinrzJcTTuyy32AsN+KwGiGx?=
 =?us-ascii?Q?Gydp2ni4XFNHtXw2UaK+ysSu8nEmrw/5lZRPt9iSn1HSmzcvzVZ5LOTi5x6A?=
 =?us-ascii?Q?ZJavlfv1tLrn41K2fJ+NTZUUT06GndkP5OrjOa6Mv9kYL6FfxU1NE10MAyow?=
 =?us-ascii?Q?jhgI4HzCG9gOAEortLkYT4ZnzPftQhu8zacszKNGO7qrDIdhIJgo5vi2bHsD?=
 =?us-ascii?Q?z9D/wZJQgzBH8VzUQVYnt9qtPrvlmvGLpBDPfUD4pbf7aH+13SH3UGTjKOkL?=
 =?us-ascii?Q?gBDWcLDxVSVYr+imoJ8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a38e68b8-806d-4924-df58-08dbfaaaedcd
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2023 00:40:24.3895
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Eu8YeBb23i67Xf06HxaJMRI+XJ40H6W1+GahLbpLzLRWm1tEDNANOsiKYPkMlJxtLeR46ujCCt+UpSST980tmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8956
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Dec 2023 16:40:37 -0800 (PST)

> Subject: [PATCH] clk: imx: scu: Fix memory leak in __imx_clk_gpr_scu()
>=20
> In cases where imx_clk_is_resource_owned() returns false, the code path d=
oes
> not handle the failure gracefully, potentially leading to a memory leak. =
This
> fix ensures proper cleanup by freeing the allocated memory for 'clk_node'
> before returning.
>=20
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>