Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Tue, 12 Dec 2023 09:03:36 +0800
From:   Philip Li <philip.li@intel.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>
CC:     kernel test robot <lkp@intel.com>,
        Dan Carpenter <error27@gmail.com>,
        <oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Luca Abeni <luca.abeni@santannapisa.it>
Subject: Re: drivers/video/fbdev/amifb.c:3375:32: sparse: sparse: incorrect
 type in argument 1 (different address spaces)
Message-ID: <ZXexaBTvLH9Espqn@rli9-mobl>
References: <202312051741.BVXr9CRP-lkp@intel.com>
 <b139b275-ee57-4026-83d3-7d49ae04ef49@suswa.mountain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b139b275-ee57-4026-83d3-7d49ae04ef49@suswa.mountain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gn03ijSQ+m/Vn/e+hAzXL+9m1zGfhjU1AsAspLqy7WpNAe6NqacOI+Ae84zK?=
 =?us-ascii?Q?4tDgm/fOCIeC5B5TUHmmgNMWFUmUPacxs1hZRjd0uZvq8OGQlMK/ZhRJGzoT?=
 =?us-ascii?Q?iS9rJt8AyFdC+/khz6ShJnOgvt4rN4LEjqIXsWp+AVmEmhSiN/44BulVHF8C?=
 =?us-ascii?Q?wNwiPe0L3I1ZayxvuUM1RSbGqz0l5y0LGKNiXAHaBHrhRO36Da87fYuK9t4l?=
 =?us-ascii?Q?uxnhy0K2iNR4wcqod1JnxXXws4sxkwvbHUHxUN8/pSczLUYZ7uuYOT4I1Sch?=
 =?us-ascii?Q?u7RZRoVyUZCfUdtQFtCXuZ/Mb3FLtIvfA9Cp/d1+iFmkBP+BQER5SSnlATS/?=
 =?us-ascii?Q?l0Ngmr6eg2DTTXv5CUzVDZL8Khs37gWFcDIvOk+2Upnw/98ae9cDEoqUuTBj?=
 =?us-ascii?Q?IgS1fai81itcZFyVoUIoN06WVT4ByttREBFGZvJUTfAxvwUdmM0m97pIlfsP?=
 =?us-ascii?Q?ijIZkMIQV0UjDa6Sm5wwuzforxfxjiz4midNh0BZJItvoqACSF8edfSlI+Gh?=
 =?us-ascii?Q?febxWrtbVTuSbSltyDRIRj6OqO2q/wKo4Wq2dw8YeRqrLS/udMckywBFcCvV?=
 =?us-ascii?Q?xUgysL5HE3CkOOE8OLXicVRQsSYBf1tQyw2B7WPYHC7hrUSwq1pREqMowS+V?=
 =?us-ascii?Q?e8EPHepQ3gYDTtEKQgG+QRG4Pwv6WkA1KCZJgflj9RNobLYAxyQ++d7Ksz7I?=
 =?us-ascii?Q?gc4kxwmb/A/Knz3yb4NLuvmCRAVr8elMHEE7FDL/oLOCpIBsb/43va63TyFc?=
 =?us-ascii?Q?qQMI0KoO0CGO/szygqfBA6TidVa+TLiE9c57X2paE0U0jLSft70Z84COPaVz?=
 =?us-ascii?Q?AwJlv1TjbCHF0y6x8iYxLk2sqeVupAGvgEjEooIdtmFuo7v0rGR8XOJtIiMn?=
 =?us-ascii?Q?XHzDir8lkE145Bqa1PIhGiRtxmeA8LELTzINkFe41J4ezpGY4KUt0DS9hg0d?=
 =?us-ascii?Q?mhMbo6Or4LJ6dsk9gV+vgl462cwcLyOz/0hMZSua6D9N2ljATrBeAtMvzWwn?=
 =?us-ascii?Q?+IfamYfceOW4jfh9dFTa8P1FB3eV6eZ8H7ufE3sjkwYDShwbXATok5n2WmxJ?=
 =?us-ascii?Q?go2yaH1SUlPq9IHr2H2TrETvSXaIWNJSXF+YtJklDGVs1E7+0oD6oUMQj4N4?=
 =?us-ascii?Q?6q23r+xHO27OGmI+puVd5bgJj5vz5I4MHYqoe0nzfGAYaYvqMU2od5/WHYLU?=
 =?us-ascii?Q?s0l6VnQudRhPky+fy+jO0Wfd52VVV5IU/HNvg7HjdQbhIX7Yd1auWDB4AHif?=
 =?us-ascii?Q?kTNjL/D2x9dUZ7kucRsatouf7677XV6rXrpZtgWH9kHlKK7EEZSyMhVguzN7?=
 =?us-ascii?Q?sAKB5IkEbEwXsXDzTPcpaPGCqdwsdbKpXGESFZTpOvifwJ72WOyoWFOS9Gxs?=
 =?us-ascii?Q?WMp6OlPQhxehhNila0ABDQWk4jHU77dUVVwmkvAEGDksr3qYTfunCvohcp22?=
 =?us-ascii?Q?bYyOX2WAdw/gXL38UY3v2wcyvOhbxDg3S+tssxRHcs4q5D6XHPjKczlgeStg?=
 =?us-ascii?Q?Dyx0Wo/ldLgUUm9ODjvpT7DIAWuD8NhBscfEjSFLgXE6/ZjHvT9uQPSFfiQT?=
 =?us-ascii?Q?pqwrUc+BVQZcqCP8VKLD3UiiH0DY2ozPFOXhVgiz?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a969241-cdba-480d-eb47-08dbfaae2ff5
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 01:03:44.2457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uR27jHfocS7y3amQK0xp6HZb34cmP69mE/a1iRwvHv/Ojk5T0h8YxAAzRtt19T7XoTlhXEPs2wmQWGjkSZeS4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6731
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 17:04:07 -0800 (PST)

On Tue, Dec 05, 2023 at 01:06:45PM +0300, Dan Carpenter wrote:
> Something went wrong with this git bisect.  The Sparse warning predates
> git.  The file was renamed at some point so I would have thought the
> bisect would point to that.

Got it, Dan, we will investigate why several reports are bisected to this commit.
Sorry about the false reports.

> 
> regards,
> dan carpenter
> 
> On Tue, Dec 05, 2023 at 05:50:23PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
> > commit: aa5222e92f8000ed3c1c38dddf11c83222aadfb3 sched/deadline: Don't use dubious signed bitfields
> > date:   6 years ago
> > config: m68k-randconfig-r131-20231129 (https://download.01.org/0day-ci/archive/20231205/202312051741.BVXr9CRP-lkp@intel.com/config)
> > compiler: m68k-linux-gcc (GCC) 13.2.0
> > reproduce: (https://download.01.org/0day-ci/archive/20231205/202312051741.BVXr9CRP-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202312051741.BVXr9CRP-lkp@intel.com/
> > 
> > sparse warnings: (new ones prefixed by >>)
> > >> drivers/video/fbdev/amifb.c:3375:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void *dst @@     got char [noderef] __iomem *screen_base @@
> >    drivers/video/fbdev/amifb.c:3375:32: sparse:     expected void *dst
> >    drivers/video/fbdev/amifb.c:3375:32: sparse:     got char [noderef] __iomem *screen_base
> > >> drivers/video/fbdev/amifb.c:3713:35: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected char [noderef] __iomem *screen_base @@     got char * @@
> >    drivers/video/fbdev/amifb.c:3713:35: sparse:     expected char [noderef] __iomem *screen_base
> >    drivers/video/fbdev/amifb.c:3713:35: sparse:     got char *
> > >> drivers/video/fbdev/amifb.c:3755:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __iomem *addr @@     got void * @@
> >    drivers/video/fbdev/amifb.c:3755:26: sparse:     expected void [noderef] __iomem *addr
> >    drivers/video/fbdev/amifb.c:3755:26: sparse:     got void *
> >    drivers/video/fbdev/amifb.c:3772:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __iomem *addr @@     got void * @@
> >    drivers/video/fbdev/amifb.c:3772:26: sparse:     expected void [noderef] __iomem *addr
> >    drivers/video/fbdev/amifb.c:3772:26: sparse:     got void *
> >    In file included from include/linux/workqueue.h:9,
> >                     from include/linux/srcu.h:34,
> >                     from include/linux/notifier.h:16,
> >                     from include/linux/memory_hotplug.h:7,
> >                     from include/linux/mmzone.h:780,
> >                     from include/linux/gfp.h:6,
> >                     from include/linux/umh.h:4,
> >                     from include/linux/kmod.h:22,
> >                     from include/linux/module.h:13,
> >                     from drivers/video/fbdev/amifb.c:43:
> >    include/linux/timer.h: In function 'timer_setup':
> >    include/linux/timer.h:159:30: warning: cast between incompatible function types from 'void (*)(struct timer_list *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
> >      159 |         __setup_timer(timer, (TIMER_FUNC_TYPE)callback,
> >          |                              ^
> >    include/linux/timer.h:126:39: note: in definition of macro '__setup_timer'
> >      126 |                 (_timer)->function = (_fn);                             29-      |                                       ^~~
> >    include/linux/timer.h: In function 'timer_setup_on_stack':
> >    include/linux/timer.h:167:39: warning: cast between incompatible function types from 'void (*)(struct timer_list *)' to 'void (*)(long unsigned int)' [-Wcast-function-type]
> >      167 |         __setup_timer_on_stack(timer, (TIMER_FUNC_TYPE)callback,
> >          |                                       ^
> >    include/linux/timer.h:133:39: note: in definition of macro '__setup_timer_on_stack'
> >      133 |                 (_timer)->function = (_fn);                             36-      |                                       ^~~
> >    drivers/video/fbdev/amifb.c: In function 'ami_decode_var':
> >    drivers/video/fbdev/amifb.c:1127:23: warning: variable 'vtotal' set but not used [-Wunused-but-set-variable]
> >     1127 |         u_int htotal, vtotal;
> >          |                       ^~~~~~
> >    drivers/video/fbdev/amifb.c:1127:15: warning: variable 'htotal' set but not used [-Wunused-but-set-variable]
> >     1127 |         u_int htotal, vtotal;
> >          |               ^~~~~~
> >    drivers/video/fbdev/amifb.c: In function 'ami_get_var_cursorinfo':
> >    drivers/video/fbdev/amifb.c:1848:19: warning: variable 'alloc' set but not used [-Wunused-but-set-variable]
> >     1848 |         int size, alloc;
> >          |                   ^~~~~
> >    drivers/video/fbdev/amifb.c: In function 'amifb_pan_display':
> >    drivers/video/fbdev/amifb.c:2540:34: warning: comparison of unsigned expression in '< 0' is always false [-Wtype-limits]
> >     2540 |                 if (var->yoffset < 0 ||
> >          |                                  ^
> >    drivers/video/fbdev/amifb.c: At top level:
> >    include/linux/module.h:131:13: warning: 'init_module' specifies less restrictive attribute than its target 'amifb_driver_init': 'cold' [-Wmissing-attributes]
> >      131 |         int init_module(void) __attribute__((alias(#initfn)));
> >          |             ^~~~~~~~~~~
> >    include/linux/platform_device.h:251:1: note: in expansion of macro 'module_init'
> >      251 | module_init(__platform_driver##_init); 58-      | ^~~~~~~~~~~
> >    drivers/video/fbdev/amifb.c:3786:1: note: in expansion of macro 'module_platform_driver_probe'
> >     3786 | module_platform_driver_probe(amifb_driver, amifb_probe);
> >          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    In file included from drivers/video/fbdev/amifb.c:53:
> >    drivers/video/fbdev/amifb.c:3786:30: note: 'init_module' target declared here
> >     3786 | module_platform_driver_probe(amifb_driver, amifb_probe);
> >          |                              ^~~~~~~~~~~~
> >    include/linux/platform_device.h:246:19: note: in definition of macro 'module_platform_driver_probe'
> >      246 | static int __init __platform_driver##_init(void) 68-      |                   ^~~~~~~~~~~~~~~~~
> >    include/linux/module.h:137:14: warning: 'cleanup_module' specifies less restrictive attribute than its target 'amifb_driver_exit': 'cold' [-Wmissing-attributes]
> >      137 |         void cleanup_module(void) __attribute__((alias(#exitfn)));
> >          |              ^~~~~~~~~~~~~~
> >    include/linux/platform_device.h:256:1: note: in expansion of macro 'module_exit'
> >      256 | module_exit(__platform_driver##_exit);
> >          | ^~~~~~~~~~~
> >    drivers/video/fbdev/amifb.c:3786:1: note: in expansion of macro 'module_platform_driver_probe'
> >     3786 | module_platform_driver_probe(amifb_driver, amifb_probe);
> >          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    drivers/video/fbdev/amifb.c:3786:30: note: 'cleanup_module' target declared here
> >     3786 | module_platform_driver_probe(amifb_driver, amifb_probe);
> >          |                              ^~~~~~~~~~~~
> >    include/linux/platform_device.h:252:20: note: in definition of macro 'module_platform_driver_probe'
> >      252 | static void __exit __platform_driver##_exit(void) 83-      |                    ^~~~~~~~~~~~~~~~~
> >    drivers/video/fbdev/amifb.c:2344:19: warning: 'amifb_setup' defined but not used [-Wunused-function]
> >     2344 | static int __init amifb_setup(char *options)
> >          |                   ^~~~~~~~~~~
> > 
> > vim +3375 drivers/video/fbdev/amifb.c
> > 
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3334  
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3335  
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3336  static void amifb_imageblit(struct fb_info *info, const struct fb_image *image)
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3337  {
> > 423a53086ce409 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3338  	struct amifb_par *par = info->par;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3339  	int x2, y2;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3340  	unsigned long *dst;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3341  	int dst_idx;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3342  	const char *src;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3343  	u32 dx, dy, width, height, pitch;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3344  
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3345  	/*
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3346  	 * We could use hardware clipping but on many cards you get around
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3347  	 * hardware clipping by writing to framebuffer directly like we are
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3348  	 * doing here.
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3349  	 */
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3350  	x2 = image->dx + image->width;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3351  	y2 = image->dy + image->height;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3352  	dx = image->dx;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3353  	dy = image->dy;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3354  	x2 = x2 < info->var.xres_virtual ? x2 : info->var.xres_virtual;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3355  	y2 = y2 < info->var.yres_virtual ? y2 : info->var.yres_virtual;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3356  	width  = x2 - dx;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3357  	height = y2 - dy;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3358  
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3359  	if (image->depth == 1) {
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3360  		dst = (unsigned long *)
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3361  			((unsigned long)info->screen_base & ~(BYTES_PER_LONG - 1));
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3362  		dst_idx = ((unsigned long)info->screen_base & (BYTES_PER_LONG - 1)) * 8;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3363  		dst_idx += dy * par->next_line * 8 + dx;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3364  		src = image->data;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3365  		pitch = (image->width + 7) / 8;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3366  		while (height--) {
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3367  			expand_one_line(info->var.bits_per_pixel,
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3368  					par->next_plane, dst, dst_idx, width,
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3369  					src, image->bg_color,
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3370  					image->fg_color);
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3371  			dst_idx += par->next_line * 8;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3372  			src += pitch;
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3373  		}
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3374  	} else {
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21 @3375  		c2p_planar(info->screen_base, image->data, dx, dy, width,
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3376  			   height, par->next_line, par->next_plane,
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3377  			   image->width, info->var.bits_per_pixel);
> > ^1da177e4c3f41 drivers/video/amifb.c Linus Torvalds     2005-04-16  3378  	}
> > ^1da177e4c3f41 drivers/video/amifb.c Linus Torvalds     2005-04-16  3379  }
> > f1cbb17ac73993 drivers/video/amifb.c Geert Uytterhoeven 2011-11-21  3380  
> > 
> > :::::: The code at line 3375 was first introduced by commit
> > :::::: f1cbb17ac73993225402d7e40a0694c502570876 fbdev/amifb: Reorder functions to remove forward declarations
> > 
> > :::::: TO: Geert Uytterhoeven <geert@linux-m68k.org>
> > :::::: CC: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>