Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Mon, 11 Dec 2023 18:21:34 -0800 (PST)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Robin Murphy <robin.murphy@arm.com>
cc:     will@kernel.org, mark.rutland@arm.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        jeremy.linton@arm.com, ilkka@os.amperecomputing.com,
        renyu.zj@linux.alibaba.com
Subject: Re: [PATCH] perf/arm-cmn: Fail DTC counter allocation correctly
In-Reply-To: <ed589c0d8e4130dc68b8ad1625226d28bdc185d4.1702322847.git.robin.murphy@arm.com>
Message-ID: <bf20c32f-6426-f4ba-3bcc-41aadd89968@os.amperecomputing.com>
References: <ed589c0d8e4130dc68b8ad1625226d28bdc185d4.1702322847.git.robin.murphy@arm.com>
Content-Type: text/plain; format=flowed; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H1VtinIbrHUC2uAP1HWuZKZNVhZozwPmqsL/h1u/eJTIycH3IVnJthnrwlPU?=
 =?us-ascii?Q?mRU+iuHPyHjDfspx2Q82X2YxG0K4e2QKny2L5o2GpQQP3Uc2yNklpqsNRO5P?=
 =?us-ascii?Q?RA7cgZcF67HsnCnzIV9NcwNfOptYSXPulsFothJi/hYnRLzwop/FA2x2mBaB?=
 =?us-ascii?Q?4bSCkX5ONBmAX44xjEbjX8eMWepXUk72Ju+HX3t9BKUGP97gLGPtqCEdqzfC?=
 =?us-ascii?Q?D8CrJcC2FLLmVpdINqjHQfdBWNweytToHfUJtDRACz0M7bQZ6rcgFvzdheMG?=
 =?us-ascii?Q?obn1agoZvBzpYMTw99zIHnHiyKkfPn+3rNcwMyK+StHhhU1/uUR9/qEKUpHf?=
 =?us-ascii?Q?6PwIyMJFqkXpBjZ8Ero3QM79qL7N9wF2azLn7khFxxUwYvbMqpkPu317bHQB?=
 =?us-ascii?Q?b6vufXOB8z1MnEW/RqAWlTABNVlVXSCYu/csMWGBdGxzBGZTpbVIzILo+zCn?=
 =?us-ascii?Q?IMDav3cASQYSzfhKD/hqhfqoYqY1XlvDAcyk5pIPywBOSgHttl40Bsu55qik?=
 =?us-ascii?Q?BQi5zuNalvOw16SfWjKMRExDgi/mTiVoGAvHdLOjIp67m1n5vPrYnGYyD4oT?=
 =?us-ascii?Q?n7CgneUMzml+7aeLLCYf4ait0evw/cVWYkRXtVLxRP6p42wB50/xD1aRd7vh?=
 =?us-ascii?Q?zmPKvN8LLzV4zIF24ilpUlYeOdKMvgawXFzuj3LRoodZJW2hH78UkgIWr/7i?=
 =?us-ascii?Q?1V/8299aasNVHqya32KdZbwJ2jD95FZMk/hpY4tO1EtRAXh02w2TVNFVVqf8?=
 =?us-ascii?Q?Ig36UYK+MZjsNngB1EeHnhUghINb13kUr6p2TwActhZccHO7q43VSWsYtCGT?=
 =?us-ascii?Q?deF1wWq4YoM9pAlcnWQT93oJCbsq27CzZTnJ4yy3U24gGdxi4HAIphxPxKLa?=
 =?us-ascii?Q?8eCx+HP6AckAh2r4NVRuohp1Ay2j6XRu9UIh6pSki2KXt2R1D1/iXQGi+jzb?=
 =?us-ascii?Q?0um1ARotB+p3LSu0dzyL77ZQJhS7jQjl4dy3w3rIFPCQZheV7IQgVSs+AY5A?=
 =?us-ascii?Q?m1tgUSrc2+a7ysq9SeCjnTqY2C4pVIm9hVMRYmMDlg4JyfrqAXxkFkuvjYe1?=
 =?us-ascii?Q?uA+QCHw5m5yuFB27ggyU9j/ieZxW1IDhp9PSdD7FbHU0QWNvyKlI43XpgFDG?=
 =?us-ascii?Q?IDrgk1JQcB7V9iWk+tnhF6ZKtMnH//kxMmZA2SFSxtlSLDN//8gKS5mRuG//?=
 =?us-ascii?Q?81BXGFmhbpEwWGacvZHYaCrPAfXobYASZzOIH88cfyPNmaFuKzUotnrIw1hP?=
 =?us-ascii?Q?p65b2jBWXMo7xPfXDt0S3FrSj4TSb8Jxk2pKtSckdBYfj00NP3wEYxCmb147?=
 =?us-ascii?Q?0ZEIZxH60trOgLL4jGJahCZjXsUOuqSe6PBIgqJRQUgBw33OoRlP930PuZ5C?=
 =?us-ascii?Q?jdVMAWdE5eKn9zvc8WruiF8CyqWlHq3ZNygzn9Iic3rTQ946xCDfF/CD6W2q?=
 =?us-ascii?Q?/CeuJXaX706RWflZrqIjUCQLGda6WRPtBUOERlJhSI2DMc9gj+FnzNAj/HoA?=
 =?us-ascii?Q?ntt36NLr0YvmvHHKzHKX1R4irdAu1J7JG8ZrofSobBNMjmqxBFQur3Q+scbS?=
 =?us-ascii?Q?wzZa/+PGY7pAo404aGM8P0XWZFQD8mlSN+5S4k9fMiwW7svDP3Ts/Z0Ytw5W?=
 =?us-ascii?Q?MLg6EvY/HK2JaCnS9kKOSKM=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf9aaeb4-d725-47de-f97e-08dbfab919d7
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 02:21:51.7943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sT3bFBXxrGXmH5W5Se4EeJoPtzGX3rZECP7ygniSdWo0zDvO3JyaxeoXxz5cwOl4ww34n6ICIGOxBMyBTYPxg6iyqL92QclDQuFHekmmdCbmncSAgYqEE11ACVNJ5XlX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6457
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 18:22:03 -0800 (PST)


On Mon, 11 Dec 2023, Robin Murphy wrote:
> Calling arm_cmn_event_clear() before all DTC indices are allocated is
> wrong, and can lead to arm_cmn_event_add() erroneously clearing live
> counters from full DTCs where allocation fails. Since the DTC counters
> are only updated by arm_cmn_init_counter() after all DTC and DTM
> allocations succeed, nothing actually needs cleaning up in this case
> anyway, and it should just return directly as it did before.
>
> Fixes: 7633ec2c262f ("perf/arm-cmn: Rework DTC counters (again)")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

That's a good catch.

     Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>

Cheers, Ilkka

> ---
> drivers/perf/arm-cmn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 86d970e74129..c584165b13ba 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -1816,7 +1816,7 @@ static int arm_cmn_event_add(struct perf_event *event, int flags)
> 			idx = 0;
> 			while (cmn->dtc[j].counters[idx])
> 				if (++idx == CMN_DT_NUM_COUNTERS)
> -					goto free_dtms;
> +					return -ENOSPC;
> 		}
> 		hw->dtc_idx[j] = idx;
> 	}
> -- 
> 2.39.2.101.g768bb238c484.dirty
>
>