Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4375548rdb; Mon, 11 Dec 2023 18:28:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEHe9O9LrcCIwj1gT06sfZUfRVVKYqlPP5SjEsKiQcJpocHAF52Uv3FAeDIF4RzU5q2GOrB X-Received: by 2002:a05:6870:4f13:b0:1fb:75a:de7a with SMTP id xi19-20020a0568704f1300b001fb075ade7amr6139570oab.104.1702348112455; Mon, 11 Dec 2023 18:28:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702348112; cv=none; d=google.com; s=arc-20160816; b=cRatCWk8C+3R+8X58fYkAxP7LRzf/auq91xM2bJ5+8aNBgfJ8KosKzDBL+qL/0xTHw 9pOEyS+c8wLJ/s2eRtpE6RHXIn/a5pT/yebaZQR9FnX2qKwfhWuruI7D3UrZegDMsGiR P0+/fL2Ed/ADOPAGsBDlL0e1xMWdhk6gWuLtk9VaqFZ8NELUoLyYnE1cqtTIkqwcn+Kk OC9B32BwGiz2pHwphewpO99cbkPu3HpVSe32TOm4YtGL8RCy8YE0VuSVUm+HD1On80N6 kny+McRjd0AOD57RgJIucw27fNvb/Y2RzAjD2seK8G2pBoj2EZQ4MwzzjaaOMO3GFosK iz2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6KOs5y8ihc64lpMASwFbDug7by8ZogxYD/q/FLr95ek=; fh=510GmgDurJ8LMglDMczzGPjUEOGekYg2nEbutXgjrK8=; b=XeynXvfXpPjS1q+yPa7hKA9xXS2+mZOfy507wNMMM1/C2ol+kar9BdE2xvOjnsVTVL v0eGSHfR6UJPaFH6pHd4YH+AhE/kNA2iNNnp1NM+b70nLLIwDJ0hS/kYqOI2TZhSVm6j d8cHtRsPTqYVIib5CMWP5+ZQLA8gKGTH1qKW69wKR5O9SReqDq88SkT2hpcvMxWzCVUq 96Jv1ZWOF7w1UFfvEnNSL1HBHIBF1mGEGubfbseNjPFsh3UukEq3uvl2PMDzM4PSpKJx JNotm4DYlkJIxdDiUdyVfwXmD6ABbl256mISb+CX6/t0ecfhGdnuxBJPL61F60Q+l/Ib H6VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RU+12PJJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id j20-20020a635954000000b005c1b322b3c1si7134938pgm.681.2023.12.11.18.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 18:28:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RU+12PJJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id ACE8C8074CE7; Mon, 11 Dec 2023 18:28:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbjLLC2P (ORCPT + 99 others); Mon, 11 Dec 2023 21:28:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345700AbjLLC2A (ORCPT ); Mon, 11 Dec 2023 21:28:00 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DEC6D1; Mon, 11 Dec 2023 18:28:06 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5d33574f64eso51853727b3.3; Mon, 11 Dec 2023 18:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702348085; x=1702952885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6KOs5y8ihc64lpMASwFbDug7by8ZogxYD/q/FLr95ek=; b=RU+12PJJdrYBX0rXfO+62RFHWxjl6wM4YG+N+3XElFV4uC8OHdEtOf75RGccwsu5Im jdEj53lrq3u1MRvtzW00Kl5a2DQTCXBlwHlcpF2kZEpI69MqotZPwKtdYBUW8l46LD1x umT/r3ATf6FORWmIQ1Rgb13WTHonAXDvkbmZZc3XeehLGz9/cPhC+i6aBSf5oJV/qi10 uHwv0HupD/bbRMnVVTQ9oTMGznKZSd4Gw//uGtVo8axIYysJnkgnMLPGuNXQHvkValC1 yrymUJhY62U9VC400oRojJ6XhaogdIAFhlb9hlA2YpXD9p9inH+UdwStDqbnNrVsO2D+ 9sKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702348085; x=1702952885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6KOs5y8ihc64lpMASwFbDug7by8ZogxYD/q/FLr95ek=; b=fliCjVpglKGZSh0oCjPdJtBE5K1aiDr6Lm/qRCVTUTwX4dp5YHSXILvoPfIuHeOMRD BtV3zMA0IphvfqR9t8bwx6kg0DzGp3+vW6eAD8/sBFB/weO0q8jDfqtEUexahtuKfYPi QkHe72sicNbdAmdee1oz87eQt2dl5tdwDpo1i+90N5068BABF+wWFCPF67UHJCHjF5Xm kFimfA+LnyFj58b9zWTA5BDpgrt9WpzdEpsDBGh7hQief92i9izkuxJ2QGVf8UYP68LN fBT/yI6cLLZcUDlxiINP7UGOoG12YzH5insdS+poE8n+ATCk4CIMnJCUUzBvVXpptxfN JCsw== X-Gm-Message-State: AOJu0YyoNbwao2c1rJA8veVf0xCPXIQDrb/c7UqBWQeVAO7qc1D8IR7K m6Jtez+qfb+cLvHxdPxuF+zUSo1NP+rBmQ== X-Received: by 2002:a0d:f881:0:b0:5d7:1940:b391 with SMTP id i123-20020a0df881000000b005d71940b391mr4788415ywf.93.1702348085065; Mon, 11 Dec 2023 18:28:05 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:38aa:1c88:df05:9b73]) by smtp.gmail.com with ESMTPSA id p194-20020a0de6cb000000b005956b451fb8sm3402858ywe.100.2023.12.11.18.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 18:28:04 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, "David S. Miller" , Rob Herring , Sam Ravnborg , Yury Norov , sparclinux@vger.kernel.org Cc: Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Andy Shevchenko , Maxim Kuvyrkov , Alexey Klimov , Bart Van Assche , Sergey Shtylyov Subject: [PATCH v3 07/35] sparc: optimize alloc_msi() by using find_and_set_bit() Date: Mon, 11 Dec 2023 18:27:21 -0800 Message-Id: <20231212022749.625238-8-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212022749.625238-1-yury.norov@gmail.com> References: <20231212022749.625238-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 18:28:29 -0800 (PST) alloc_msi() opencodes find_and_set_bit(). Simplify it by using the dedicated function, and make an nice one-liner. Signed-off-by: Yury Norov --- arch/sparc/kernel/pci_msi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/sparc/kernel/pci_msi.c b/arch/sparc/kernel/pci_msi.c index fc7402948b7b..91105c788d1d 100644 --- a/arch/sparc/kernel/pci_msi.c +++ b/arch/sparc/kernel/pci_msi.c @@ -96,14 +96,9 @@ static u32 pick_msiq(struct pci_pbm_info *pbm) static int alloc_msi(struct pci_pbm_info *pbm) { - int i; - - for (i = 0; i < pbm->msi_num; i++) { - if (!test_and_set_bit(i, pbm->msi_bitmap)) - return i + pbm->msi_first; - } + int i = find_and_set_bit(pbm->msi_bitmap, pbm->msi_num); - return -ENOENT; + return i < pbm->msi_num ? i + pbm->msi_first : -ENOENT; } static void free_msi(struct pci_pbm_info *pbm, int msi_num) -- 2.40.1