Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <aef69154-d46c-5947-1ad9-58418dc3947c@intel.com>
Date:   Mon, 11 Dec 2023 18:30:18 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v3 10/35] dmaengine: idxd: optimize perfmon_assign_event()
Content-Language: en-US
To:     Yury Norov <yury.norov@gmail.com>, <linux-kernel@vger.kernel.org>,
        "Dave Jiang" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>
CC:     Jan Kara <jack@suse.cz>,
        Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Matthew Wilcox <willy@infradead.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
        Alexey Klimov <klimov.linux@gmail.com>,
        "Bart Van Assche" <bvanassche@acm.org>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
References: <20231212022749.625238-1-yury.norov@gmail.com>
 <20231212022749.625238-11-yury.norov@gmail.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20231212022749.625238-11-yury.norov@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkZQc1U4Ym03TG1HTGYrT2hXVXJ3MHN2S1lycXczdCtyT1VSb2FQdkxHbkZl?=
 =?utf-8?B?b0ZyVGNpL3ROQ3hqc2l3OE8vM09iK2pQRTVuVmNWV3ptWmxuZ3FtUXRoZG5B?=
 =?utf-8?B?ZEkxVllGVkVCYnd6cjlDQ3ZzSThvZDU3R2liYitIQVZ6ZWIzaTFpdVFBd29H?=
 =?utf-8?B?Z1dlVXR0bWdkMHM0WFFIRlExVU9QYitWVG5URTAxbkplTFFCUUNtOXRXTEx4?=
 =?utf-8?B?V0IwUVF1c0IzZWNDN0cvbVYrTWt4VXY1K3dsdzJKSTNHUVVKeTJpRUNNS3JT?=
 =?utf-8?B?U2JwTFdjR0F3VmhQVmNWNWRjKzA1eFMyaXgwNVBkaS91M3FHS1hyOHBOYmlL?=
 =?utf-8?B?OEdtUWZ5N0VtNUFuOERQT0M0SmdsS2pTbVlHU0RCTzNITXU3clZIOHdVcEUv?=
 =?utf-8?B?UGp6cCtnVmt2SlVXbmduV3YrblBOQmNtV082OFk0d1NlWlA2OFljNndLU1ZI?=
 =?utf-8?B?UHlzYm8ya2J4eS9vamVPSG83Y2dwRnN5dkxKdWx0V3MxUVcrb1orbEpqNUJO?=
 =?utf-8?B?ZzVaUDFkcjFQc1BDemY0aS8vWHN3b3RrNmE0SXF5alcwTVB0OCtoeDFjdnpu?=
 =?utf-8?B?dHJXQk9NSitIa1EwQ0ErZlMrTFdiUk5qVFprNFgwbW5tL1Vad2Y1UXR1cmFW?=
 =?utf-8?B?RmNQNTVyUnYzU0lQVTJ0bHZEeE1PMUpmdm5taklYWEp6eHc4S0Rjbm50dGJt?=
 =?utf-8?B?eHNoVVA1S1NieC8vUmRrcmN6aXhhK2NnQ25EUUJXZlFYZHcwUnljUEhZWVl1?=
 =?utf-8?B?SHVKMkg3b3g2Ukp3dk1yUnFkMGR1SHdoTGxKZ2JpZGVzYWZvSnZ3a0tSVXZS?=
 =?utf-8?B?YmJ2YmxCRmcxTitYb0xLZUdTQTh0Z0p1Y25PNFJuek1GNnd1MlBZWVlXUnBT?=
 =?utf-8?B?aXBkaFBVcEdyMkVFNXo3YTdxK1RhdVBUbG5uaXIvSUdWOU1kVmpCY21oR0dk?=
 =?utf-8?B?a0dHMG02SkhZdmpDWUxGNThmSEtrK2xRUlFhUDQyeUZBTXYvdnhNZWQ0a3lr?=
 =?utf-8?B?K3dNRWVZV2RaNFU0QzEvM3d6eEhaL09qckpYUXFEcFNoYkZKR2F5bDF5Ukti?=
 =?utf-8?B?Q0QwbWlyT1dyMHo0YWZVUVhUVE02UXNJSlZpeEVKZTdxVGJSUisvRFp4bjhU?=
 =?utf-8?B?azB6UHdOdEh5emFZbENhM1ZucGpxZ3RVcTZyd3drbFp4UjNKM1hvb1ppRUdp?=
 =?utf-8?B?Skl3QmlUaGRMUzZCSEJvNXQrU1hXRlpMZWp6N0p3bHdrbW9PYXNaZlpKeTha?=
 =?utf-8?B?LzdkVERmWjFxZ2FWdnpmVmY4emYzUDBxRkNtOHB5cGoxbDloWlBEc3loRThw?=
 =?utf-8?B?a2ZJQ0FGc2poMkZMUDBYdTVtSm1jTmhCbXR0WjU2UzJhL0NrbUFFRTAyWGpL?=
 =?utf-8?B?ZmRubW5IMWZIam1MeHA0QmhDcnBUK01lYy9ic1RNaXIreVV0UmU4eVZzSDhY?=
 =?utf-8?B?czhWZzRwU0laeDAwMGpub01aSGRHREx3d2dvWjkwVFJ3Y3gvYUp5UUZsbldK?=
 =?utf-8?B?RlJwTUp4MU5rQ0g0WTlzQk5uVXo3L3dvdnM2bXoxVkxKZHZtTTl5SEFJakhY?=
 =?utf-8?B?bkV4N0hqZWc2cWxzWjJPM3MrRUo2UWxrZmNNQ1FscGMvcDZOVldNNFQ4b0Ru?=
 =?utf-8?B?MHBWUCthZS85a2VSWFkweHMzaHlpWE5oUlp6aWVWeWgrcFdXbVhSN0FXd0VI?=
 =?utf-8?B?OGdINUtFc1psTDZaZFNKclRUTFlJQWpXaUVsM1Z5ZU5jM0RxdzVmU0NFVW8z?=
 =?utf-8?B?Z2ZNZlI3Um1UMGdMTWk0ZERsTkFIUkNQUGFLZlBxRWN0NE4wNkN1Sms4Z2Fy?=
 =?utf-8?B?LzZ1Q0RySU5meFVnSFU1WjBrOGtNYVhDR0hIL1lrNkpNU2ppeWlOZXdlSVZE?=
 =?utf-8?B?N1NpYVd6cFc0NlUxYWljd1VpRlVabUYvdkViWE5hRzVyRzBOTDRvUjQxWFda?=
 =?utf-8?B?Yngwb3dyalJIZkdIbzA3TEhmbFFkRzFjRG1mQThXUDhXN3N4YVNZRUJLaUwy?=
 =?utf-8?B?UnlISmp0ZFNjVm04ekdXRjBUSFZ5eGJ2endOVUJ2b1hqMC9WemxMUDJUeXRB?=
 =?utf-8?B?QjZsS202MEVsNldKY1NzSHdLMWwxZkoxUEUvVVpsR1ZSajViL1RMdzN3WDZl?=
 =?utf-8?Q?A6ItztxrtkB0eg2oJtO4XdEdg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02d90a64-5f83-454e-776b-08dbfaba4dd8
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 02:30:28.1939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yFFChlP9NHWJ+gN0IhHXpAE+6NqcGweh+UkMzJonphzDzprbxRU9EzD2oZjnNq4Ge3326OUS07smyi7tqCJ1UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8021
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 18:34:21 -0800 (PST)


On 12/11/23 18:27, Yury Norov wrote:
> The function searches used_mask for a set bit in a for-loop bit by bit.
> Simplify it by using atomic find_and_set_bit(), and make a nice
> one-liner.
> 
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Acked-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua