Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4392163rdb; Mon, 11 Dec 2023 19:18:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiFdOknyCYpbnsvXLU68XxjTcICxEidfwUKw0RF/zRju4+tAW39u98EOuczNkbiDQKGp8E X-Received: by 2002:a17:902:bf43:b0:1cf:f7c3:1e32 with SMTP id u3-20020a170902bf4300b001cff7c31e32mr5025481pls.27.1702351089472; Mon, 11 Dec 2023 19:18:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702351089; cv=none; d=google.com; s=arc-20160816; b=fox96y3VcK0XxcrBujUIc0fqJjW9nOIi/Vrt3xuHH9AOU7dGnoTkvyybFQ9PYNwdVU BldYRgGVAPF9JPaxXk5wfldBv67lUyfJXkWIb9MK3UypEUiprYYWHsD6JYlURuLrePsR NtfBCAWtc0e4p4CZbiW52lek0HesO1SeI0z1FmgmONjaRev0BACnjlyqClMwXJtaBomC /K1S5Y/T8Pj97bn5Fydk5rs5mcaU5GVysUdclVBxvSFhQI2KsB9lLCRmmjGznit/p28j SLRiznvpm+MA4ss694UmiRcvS7//S/77ITY4Fhs2kGFL4FRsFlvBlaf6e0rcTi6Hm1/v JNdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=toTMviLqn3jRZGRTY8l7G5Ter1R3X3fmv5TS7VZ8JTc=; fh=FVlAo+Kemp7Y5tfkz+ZSf0TeqaOCGo+mZaG8e4BM8cs=; b=ejn7FKwAOID+UZiWTFmfvdx8h/RY7B0Bwz/u74pqO3PqsJKig6K9Mn1qkIsEQ+6Ept pLBo/W6Blt/9bG38vle4mjvNe3nI37EQva7nw24m4iZPfCKqfuI/rtwmCiFeAo1Jg1TF Z1zz/tEnetyuMYGp+I76Zk6m1C/aiMzf7FMNQ5m9I2gwORohFRQ9w17oy/v6pv38BV2g 9g4M+QYyhyh/Mazb17zG0Q6mgDfA8hw5hDEfvgMvIITda9crcApbmpFWylSvFWzCfQnt B5g0FcNKFVzGoQh0kRmnzx1lqx/BgobmWXNB6A5FVdasM3KYnteMAxQyg371lXLF/m/v GoPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WT11Gvho; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t9-20020a170902e84900b001cc31c32e0fsi7249082plg.91.2023.12.11.19.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 19:18:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WT11Gvho; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7B11E804E690; Mon, 11 Dec 2023 19:18:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345805AbjLLDR4 (ORCPT + 99 others); Mon, 11 Dec 2023 22:17:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjLLDRy (ORCPT ); Mon, 11 Dec 2023 22:17:54 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 553BABA for ; Mon, 11 Dec 2023 19:18:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4DDC433C8; Tue, 12 Dec 2023 03:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702351080; bh=duVtBYF9/uEhtteq5lUjxhQBMmTnPleG8zmcnq1CCxU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WT11GvhoK9rwieQoiDZI3rGVQKEHcQkthKU4+grqOG6ygOej/EE5+ycmUdj+Xp/Wl ftDXugi8mrCyiQy6Tq74fJsryOZtDnwLreEd4LV/DF5CC2Yy4vGiBD2TufgJU2YzIv g0r1yffPh61kYI99RVUcRG+WvHa4O6DxO5CvkKE53uBuZ+un7QvJWPExEVjeLeTn4b NoffrD6Tvt4PRx+Lnt5KN0i9YD/JeF2u9DUKrPGNmxktNm573spvyQjt1fFSsL0+fK 2ffRHS93QFdBR4+CIPi3ytSeqo7TGMye6/euxAE0a6WuU+88ePUFhxtef+zvswJPdF 1hQFLkJk8o6Kg== Date: Mon, 11 Dec 2023 19:17:59 -0800 From: Jakub Kicinski To: Jijie Shao Cc: , , , , , , , , , Subject: Re: [PATCH net-next 1/6] net: hns3: add support for page_pool_get_stats Message-ID: <20231211191759.61764363@kernel.org> In-Reply-To: <20231211020816.69434-2-shaojijie@huawei.com> References: <20231211020816.69434-1-shaojijie@huawei.com> <20231211020816.69434-2-shaojijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Dec 2023 19:18:08 -0800 (PST) On Mon, 11 Dec 2023 10:08:11 +0800 Jijie Shao wrote: > Add support for page_pool_get_stats, then the hns3 driver > can get page pool statistics by ethtool. Sorry, you're late to the party :( We have now added the ability to read page pool stats via netlink. The support was merged as a379972973a80924b1d03443e20f113ff76a94c7. If you use the page pools in your driver in a normal way (each page pool only used by one NAPI instance and one netdev) you should use that instead of dumping the stats into ethtool -S. -- pw-bot: cr