Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4393236rdb; Mon, 11 Dec 2023 19:21:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHzugwQqwCkC7WCN3qLDtNoBs5gSCSDQBRQklrBlO2w0UznI+1gjUgpAM5Q62NS5kLHkjt X-Received: by 2002:a17:90a:928c:b0:286:71c6:6b70 with SMTP id n12-20020a17090a928c00b0028671c66b70mr6724227pjo.43.1702351294927; Mon, 11 Dec 2023 19:21:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702351294; cv=none; d=google.com; s=arc-20160816; b=BHlOy8wU8hIPjmnRPXKq1KCYec38lX4O4X4gUW05SgTvsINCqNHOthQ2NUBPkYdqCb ovxXqegIGajDHIDD7BWCQwooucl06Ej3JINWOrLuNOozqt8YAoS/+fQZFBTTz8BN+f8I Wxhb/tTvTtXbNjrj05EFL72bqDbUS25rkov7KQYc8YcbYLllhb+wMZf8hY/jGUXgVVLV S9PnrxGc12g0G/02XrPUo+70WFKxLxFHxVdjw3i+I5M16f1soESlLvqQJe0n4pwq6W/6 Y4beEm0peMcj093XOzykmy5UvEZrtpp7YaGZYFZfTG3bFfIrimDvacuR34dhVOeycsA0 bnNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=wRPseFsynabFF6ox9cUgnxmV7l2w8DducyuqPfkFGTo=; fh=e7hRGszD5ROfoCNSZPVqlXmeafU9Fuw7cYF1OZeW/Yg=; b=dKVsRxwnK/e3zA2XQ392F/re97bK9b9Bb0I/RG+C47lHtNtvX71rLHdOUqc4bN6KRM Sp+x61iO+ZcJygHQl7WmT9ws9DO25GxOld1pugKSYwETP5khbU1jU9x3liiLpRa2BgyK tsYxOkhXcCEtq4lr6CGinzSJIKZ01T6qeY060SpzjWY4OW1I2G31lUINEUYx7bMESZga OaGRyGwnHq9Gb6/DFDzb6EQv1nyvyqeVH316IXL/B8yTQ5uUpN40O6jgFpe9T2Zxt/V3 TAHO4Q8cLtOt9szy6fUrHUHNM2uJUuWkuDJQALJAsYhqsLC+AoQloRb0sFfVrs+RkFiI Mw8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hWSo+D3s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id cv13-20020a17090afd0d00b00285177b43d3si8407874pjb.111.2023.12.11.19.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 19:21:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hWSo+D3s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 95F3F8068213; Mon, 11 Dec 2023 19:21:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345805AbjLLDVT (ORCPT + 99 others); Mon, 11 Dec 2023 22:21:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232156AbjLLDVS (ORCPT ); Mon, 11 Dec 2023 22:21:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5A2ABA for ; Mon, 11 Dec 2023 19:21:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C09BC433C8; Tue, 12 Dec 2023 03:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702351284; bh=wRPseFsynabFF6ox9cUgnxmV7l2w8DducyuqPfkFGTo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hWSo+D3sNzmsjgH0dbI8NyBUQ3biddHYlnS5fa1RbEQJtV3fl42MNBgUvaqgHp9oo QmYoultXA22eYUunYcfYlZiEKjza0Q7XnhvqVU7jEJONnFl5ssOgpRp1o6O3dXCFbR qlYZmXNF1PPVVWOIBMdStUbf6E3gNytZ1Nq/UDAFW7Yy7sFrBgy/4mhyS6aQRXhWGX 35eGZHhtYUF46f6u+Z4WfCNkorphg5gfkcyTQOBICnCNXxd0Dk4cb2IR6JrM5AKAtR kxV5o6M3EKWtGx4EzcRKQZsNfVy+YFZLdg63YP9VmGxFKZHvDgM1NMaYO7YNuXrRK9 owmsbHG8rIp7g== Date: Mon, 11 Dec 2023 19:21:22 -0800 From: Jakub Kicinski To: Jijie Shao Cc: , , , , , , , , , , Andrew Lunn , Ido Schimmel Subject: Re: [PATCH net-next 5/6] net: hns3: Add support for some CMIS transceiver modules Message-ID: <20231211192122.14da98f0@kernel.org> In-Reply-To: <20231211020816.69434-6-shaojijie@huawei.com> References: <20231211020816.69434-1-shaojijie@huawei.com> <20231211020816.69434-6-shaojijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 19:21:32 -0800 (PST) On Mon, 11 Dec 2023 10:08:15 +0800 Jijie Shao wrote: > Add two more SFF-8024 Identifier Values that according to the standard > support the Common Management Interface Specification (CMIS) memory map > so the hns3 driver will be able to dump, parse and print their EEPROM > contents.This two SFF-8024 Identifier Values are SFF8024_ID_QSFP_DD (0x18) > and SFF8024_ID_QSFP_PLUS_CMIS (0x1E). Hm, you don't implement the ethtool get_module_eeprom_by_page op? I thought for QSFP DD page support was basically required.