Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <25455a53-0437-4f84-98e5-0e744d46be72@intel.com>
Date:   Tue, 12 Dec 2023 11:53:45 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] vfio: Report PASID capability via VFIO_DEVICE_FEATURE
 ioctl
Content-Language: en-US
To:     Alex Williamson <alex.williamson@redhat.com>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
CC:     "joro@8bytes.org" <joro@8bytes.org>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-4-yi.l.liu@intel.com>
 <20231211110345.1b4526c6.alex.williamson@redhat.com>
 <SJ0PR11MB674458A8B7319F30A67FE55F928EA@SJ0PR11MB6744.namprd11.prod.outlook.com>
 <20231211203946.35552183.alex.williamson@redhat.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20231211203946.35552183.alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0toR2ZncHNzcGc4VmtmR2Y0cU5EY1N0YzVtYU1hOFVPbERDbkhXVG9aSVRq?=
 =?utf-8?B?dTBPSHdxbWdQQ0gwZGJjb0xYTE9HZlhYZGRKUXFoRk9yQWt1ZmhSNFoxblBV?=
 =?utf-8?B?VDkvNVhJd29rL1NVV2VvTnFZU3JRci93Q2tGak1EQmpwZ3ZKYnZsV3JFTjJU?=
 =?utf-8?B?UThBOGFTSk1aRlhYWlVyWVFVM3kwS0FkNHEzbWlLaWlOcWE4Y2NRYXBKYXJD?=
 =?utf-8?B?R2VSOFRIUEtscDlwM1pDaGNaUENCcGkreGdSQi9aMGdxcFR5aXRnQjM1VWl1?=
 =?utf-8?B?d04zQVBJV1cwVTd6cTA5UHNEUU9IU3RtUUoyc3pxWUd6aDcyRHlEVUZwQWlv?=
 =?utf-8?B?WVBsMjc3MHRVODdpODZ3c0M0LzhwV0hUZE5hZVJldGJnWWRDdTZ3ZnF0NEhH?=
 =?utf-8?B?d2lPSGVMM2ZodWlIeUQ5cjJ0UlRuZis3a3dzK09kckIrUXNMQWg0ci81RlhV?=
 =?utf-8?B?dW5ESTcwVnJ0YjVxMVQrd3NJSEVWREZaZ3Q2Q0ZMSzAyaXVsV245RGJQSDZu?=
 =?utf-8?B?NXJGbE8yRzRCYUMyY0c0RGZYNmFReExLQXhhRnlORlo5cDlBeTRzRWw5UTRX?=
 =?utf-8?B?Yzd3SVVPeEEwdkxXUUtWQllMWE1lYUt4SDR1dlYvWWdWbjhuQ0hONWIzZW9q?=
 =?utf-8?B?SlhzcS9YbkhrRm9ISDhZdFhMbm5uZFZOT09TLytHSzhFRE04N1RQTGgvbHBk?=
 =?utf-8?B?a3BvTEl4OGpkNDlvcC80d2FXY3NUTUJrek1vVXNkZVIramZvbjdObVN1UkMr?=
 =?utf-8?B?QXNKWm9LSlpSM2xEWmNUOEs2c25kbmE3eEdRV2lxa1NEeHFQQnd6ZkpPeWFL?=
 =?utf-8?B?REtCdFp1SzZoUEpLQ1pIdjRNVURYd2JBRlNDRU5mU3RqcVdhcDRpSGtISGo0?=
 =?utf-8?B?ZFZiL0pSTDBQM1dPV0tnMjhqOVhyMnNGb0dPUHBFNU9zTUxFWU9sTHJ0NlJh?=
 =?utf-8?B?T2NYTFVoMDlNODdMenlBNVFlTFZpbWNhVTU3VmloeVAxL3c5UVgzc1dYdFdG?=
 =?utf-8?B?MHNXMXlBa29xL3ZyVWtYVWE1RUlNL09LZDFIVkszSVNXY2VmeCtZUXozOGJW?=
 =?utf-8?B?UU1TdThka1VaRHJVU0tHMFFtbHBWWkpQZTRIVUZTS3hqWVNsQ2RPYURtQ3pW?=
 =?utf-8?B?S05hcjZZUGpIMFhERkZNZm9yN2w2QkQzRngrQ2FUUEdQQXBaR3grRlo2bnA5?=
 =?utf-8?B?Wm1icFYzUnZOb0JzZEhEZDlDWXZrQitIRW1sNys5WHo3SmUzZ3c4aHVDZFlJ?=
 =?utf-8?B?eFA5NmNzclMwMFJ6Ny9YWkxWMmxtY0JCdzVoRER5T0hiK0J2WkNTWURPSjRM?=
 =?utf-8?B?aFJLM2FKRjBZMng1N2tWMGtTbXJlamFiRStGSVJmOXhCcGpabXB4RER4dnBq?=
 =?utf-8?B?eUpubEhLMnpjYXh6T05HSHBudDVobG90QXFtUDlKdUZjN2dQZEVjd1lNWVps?=
 =?utf-8?B?SjEzTzU0SEhHaWVld1NjK3czbFptY3NsNFRqR1JHUDlwWUd6WmlMdDFCUXVl?=
 =?utf-8?B?V0JRV3V1WkMzSldqSUJMT2d0aG0vZG5IWVc4UnJrOGs0Wk8rOW14OGtMc01N?=
 =?utf-8?B?ZVhaS2UvMXVqdWprSkRuTXNRM2V6SnN4ZlY1bmRKUC9kNWg5Q2NoWTgvMlJv?=
 =?utf-8?B?cndyY2NVVGd1eTVPa0Zhb2NtdW92TTZxRit2MEdMZ1RsTnVhOFZPNVFnT0pW?=
 =?utf-8?B?MEU0VUM4MFBCT2l5bWcwWEtuellQcVNYaGJLZUdCU1NPUGxmOGpVTk5uUVNS?=
 =?utf-8?B?cUdUVks4a3ZYOVA1VDNqdzBKaVZPNDgyb3g4Y1lVVEF6eXd2cFFBYS9JZGRp?=
 =?utf-8?B?WDg4WG1uYVNtVWdxQWxzSzB3V042dG96QXl4MTM2eDFIVWtWNTBqN0VKNlcx?=
 =?utf-8?B?cllGYWgxaEJkSXRCV3hmdnlHWUJlcmh2MDVqRVErL3hXNEErZzdkR1l0eGVP?=
 =?utf-8?B?MUgxQkJxaCtyZ2oxY01IcmhmOVl2dXY3ZWxDelNPL2Fnc0V1SC91SUtqSHQv?=
 =?utf-8?B?R2hMVllOZGZZOUsza0pnMmpVa0NrUDhxa2ttcERzVkhLaWZCYnVySVRuZjM2?=
 =?utf-8?B?YjMvb0dFdWl1NHhCN0J0d0ZXOWRHNElOL1hSYnN2K0NYRmczb1d6WnBuMkM5?=
 =?utf-8?Q?ZVy7FYivMvdHcSJRd78JOZOeR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1f71a3e-5bfd-457f-2901-08dbfac596e0
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 03:51:15.4254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zvWROiF2EHd0Pw6JfUWo6AJs3HcPHw2q3WsnV1C/xJn1yVHhd0r02qDbHAbLo4rw1vv39h4ljCpEroxicGNf9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7631
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Dec 2023 19:51:55 -0800 (PST)

On 2023/12/12 11:39, Alex Williamson wrote:
> On Tue, 12 Dec 2023 02:43:20 +0000
> "Duan, Zhenzhong" <zhenzhong.duan@intel.com> wrote:
> 
>>> -----Original Message-----
>>> From: Alex Williamson <alex.williamson@redhat.com>
>>> Sent: Tuesday, December 12, 2023 2:04 AM
>>> Subject: Re: [PATCH 3/3] vfio: Report PASID capability via
>>> VFIO_DEVICE_FEATURE ioctl
>>>
>>> On Sun, 26 Nov 2023 22:39:09 -0800
>>> Yi Liu <yi.l.liu@intel.com> wrote:
>>>   
>>>> This reports the PASID capability data to userspace via
>>> VFIO_DEVICE_FEATURE,
>>>> hence userspace could probe PASID capability by it. This is a bit different
>>>> with other capabilities which are reported to userspace when the user
>>> reads
>>>> the device's PCI configuration space. There are two reasons for this.
>>>>
>>>>   - First, Qemu by default exposes all available PCI capabilities in vfio-pci
>>>>     config space to the guest as read-only, so adding PASID capability in the
>>>>     vfio-pci config space will make it exposed to the guest automatically
>>> while
>>>>     an old Qemu doesn't really support it.
>>>
>>> Shouldn't we also be working on hiding the PASID capability in QEMU
>>> ASAP?  This feature only allows QEMU to know PASID control is actually
>>> available, not the guest.  Maybe we're hoping this is really only used
>>> by VFs where there's no capability currently exposed to the guest?
>>
>> PASID capability is not exposed to QEMU through config space,
>> VFIO_DEVICE_FEATURE ioctl is the only interface to expose PASID
>> cap to QEMU for both PF and VF.
>>
>> /*
>>   * Lengths of PCIe/PCI-X Extended Config Capabilities
>>   *   0: Removed or masked from the user visible capability list
>>   *   FF: Variable length
>>   */
>> static const u16 pci_ext_cap_length[PCI_EXT_CAP_ID_MAX + 1] = {
>> ...
>>          [PCI_EXT_CAP_ID_PASID]  =       0,      /* not yet */
>> }
> 
> Ah, thanks.  The comment made me think is was already exposed and I
> didn't double check.  So we really just want to convey the information
> of the PASID capability outside of config space because if we pass the
> capability itself existing userspace will blindly expose a read-only
> version to the guest.  That could be better explained in the commit log
> and comments.

aha, yes. It was mentioned there, but seems not quite clear. Will refine. :)

  - First, Qemu by default exposes all available PCI capabilities in vfio-pci
    config space to the guest as read-only, so adding PASID capability in the
    vfio-pci config space will make it exposed to the guest automatically while
    an old Qemu doesn't really support it.


> So how do we keep up with PCIe spec updates relative to the PASID
> capability with this proposal?  Would it make more sense to report the
> raw capability register and capability version rather that a translated
> copy thereof?  Perhaps just masking the fields we're currently prepared
> to expose.  Thanks,

I have a minor concern on reporting raw capability register and capability
version. In this way, an old host kernel (supports version 1 pasid cap)
running on top of new hw which supports say version 2 pasid capability, the
VM would see the new capabilities that host kernel does not know. Is it
good?

-- 
Regards,
Yi Liu