Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <3c5840c1-7526-4275-becd-ad5af9fc78a5@intel.com>
Date:   Tue, 12 Dec 2023 11:59:26 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 3/3] iommu/vt-d: Add iotlb flush for nested domain
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>, <cohuck@redhat.com>,
        <eric.auger@redhat.com>, <nicolinc@nvidia.com>,
        <kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
        <chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
        <peterx@redhat.com>, <jasowang@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
        <suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <zhenzhong.duan@intel.com>, <joao.m.martins@oracle.com>,
        <xin.zeng@intel.com>, <yan.y.zhao@intel.com>
References: <20231117131816.24359-1-yi.l.liu@intel.com>
 <20231117131816.24359-4-yi.l.liu@intel.com>
 <20231206185657.GC2692119@nvidia.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20231206185657.GC2692119@nvidia.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFNnM0xGUTRieVYyR3dZSVlXSnZ2cmp5WnI3akpDQmZWQXRsSlNBOWtEQjZ5?=
 =?utf-8?B?eUdWVGlRY0xXbXNiYXlhYTJ6a3VlY1VJcXNyeFE0Sy9GOStha2krZ04zYTdh?=
 =?utf-8?B?UHV5T0RQOG9jZWEzQzBZbDhMNG5wVXNGNW5uTzBhNi96ZVRBZlNuQmRpZi9a?=
 =?utf-8?B?MHlZdmRQSHZDa2NVMW11VHo1YzdCaG55bjhzNFFQaUdjUzJYWEtybmYyYkJD?=
 =?utf-8?B?cXI1WlNicXk0L3RuU1gvaVNBS2FycHVkNDdQRU9CaTEwc2NOYkhmZ29pRWt6?=
 =?utf-8?B?bUM4Z3ZURlZYWWxLQ1gvQVpDbGtsVWNsWDdIN2JJcjR5bTRpaDlRMTM3R1Ji?=
 =?utf-8?B?Rk5zS2JwQXcyNi9JVWR5d0NoeWlSRXFTUnh2QTVtOEl6d0hyYkx3ejJ4ajRN?=
 =?utf-8?B?SEl2NkQ1ZHdoelJvRmRBTlZWY3VPdEhlV21LbHR2aGJMeGtNeEZBOTRrZUYy?=
 =?utf-8?B?Q3puY3JvN1dMZWs3VS9sUTBEYWdJMFgrbFNGYlIwVTNDc2ZPbkRPSDZEQ0xK?=
 =?utf-8?B?bm1yQ3laUEkvSVJnYXhmTzZkZDE1VzVqMGVZRlFVRDdVaWlPV3U0Mk1maFI0?=
 =?utf-8?B?N0ZXbFE0bzNSdFlrd1lFUEJ2b2crTWZjRWNvd1dCLzJIM1cxSmNuZnU5QUVt?=
 =?utf-8?B?RTQxOVUrSDd4aldvbE5vOGdQY1Q2RUtmcXBxK3V4Um9CcUE2NEcwTVRjaHZT?=
 =?utf-8?B?Q3FBRDFDUCt2dHYwaFFZcGtjQUZ1UHdFcTVYUmIwZkUrMnl2M3EvckpqcW1U?=
 =?utf-8?B?RGRYQVBvWjUwQU5QT01ucy9jcGtTSFhKdU1VczloVnVmcjFyYXlWVk9GUEZU?=
 =?utf-8?B?Nlo2cjl3c2dZRlBPdk1zd1ZLaUNBdmVFSTIzdm5OMDFUbkhQZHROTVRLQzRw?=
 =?utf-8?B?RmpnbkhzN3B1YzdlSmRkeHo3OVdmSE9uS2s3aEMza2hKcnhQRnRiQW1rR21V?=
 =?utf-8?B?QUxSSWw5SG9mY3hTMUlsK0YvcjNKZ1J4LzRkaFE0bDlBVWNiUS9HdkIwUEhC?=
 =?utf-8?B?eVg3RHpiQVprcGR0WnRadk5xZ3pKNFhuZWZLQUprT29QWXN5aElVM1BzMnQ4?=
 =?utf-8?B?MFZVMHFNTkN1M0wybm1uMVluMlBLSEtxRXY0cTRnbHV6VzVvMitKV3JXL25O?=
 =?utf-8?B?RXVQSSt0KytFZmhGbUNRTlAzWkM2VlMzeGNHbjY3Y2d5UGs2K2ZkT01ndm5D?=
 =?utf-8?B?T2IvL1dhOVREamNRSTdqYXJNN2V5VU5iMFMyRVlqRUFyUHdpTFlBbFZzOEtr?=
 =?utf-8?B?NVQrMnVKU1BMdWJhL0dNZkNTa3lsbmQvM2U0c1UzREUrTFUwc1U2QVhGV094?=
 =?utf-8?B?cFd4V3Fwd3F6YnlUL0NOZHBlN3hVOGFXalluZGRNaWU0ZTRjMzd0WEZmSGVB?=
 =?utf-8?B?NXd6RVFMOWpoSTByQ1ZhdWZLc2QrTUYzblFUZ1BmMnYycjVyOEFmSmhhc1o1?=
 =?utf-8?B?TUcrcENPNmJOZ2lYT1NBaVN3N3MyU3p3ajJoWFNmZURRT0lnNUJMVWdkT3Nq?=
 =?utf-8?B?YVJSVHIzRFFDbjNyN1dTa1ZydDRYRXU1SnF1KytCTUtpMjFSaDJEU3V5dmEz?=
 =?utf-8?B?SUNGQXhhNjkveHh4TnJOYmw3MHhCZ0d0NjV5YlAwNVdnWTduOE5zSHh3QS9B?=
 =?utf-8?B?a1VIdXFyeGIwM3A4OWxSRUxyVTd2OG1mRVlBRG51WVVrVkRRL0V0Ym1Ba1kv?=
 =?utf-8?B?aHNlYTgvRkoyLzhlN1ZSWG5tc2kzNUNsQzlVWktFM3Y1eXFxWURUd2RvSVlC?=
 =?utf-8?B?RlNCYlFqVVZsSm0valFPYWlyclhTVFZzM3EvalJhd3J2NEMrcUhwMTNCb05C?=
 =?utf-8?B?eTlZMzVENUdKbytnZ0xHaHVYNXNub3hwNUJkNGlTam5jek54WStZSk5sQjFk?=
 =?utf-8?B?R016ZzlhZjRuUE01QjJqNCtDUmJUSzhQamRjeW9Zai83QWkwbTBwTEVZaTNq?=
 =?utf-8?B?Y1RrdWhuVWRsN2V2NDhDUmlLWTYrWU1yd1p2OUp0MFVXc1Y0YktFY0pqUzhR?=
 =?utf-8?B?ZzJoNnpIRXU3R1NNWlJXc1lGeHZzYjcvUzdad2w3bFkxQnlNTTNLaW1YTzdz?=
 =?utf-8?B?VU1PM3Jnd0FuZzlyRndTeERjMmU3OFJrNVRocFRWdE5wWE5GSU5uVW5kQ0ly?=
 =?utf-8?Q?Ggwn+jHLXcnW2AQbZ06wUNxG4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 78bea3ed-fede-4c57-ce73-08dbfac65dda
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 03:56:49.1345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pb85pqasjCLlwtvvpJe0ryMgDgaJAxZmxQvkp8G9Lu6uW7y0sPDQDgiYx4MPd8ewSprqMv0YcQlg3Bd6pMV6+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7631
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 19:57:01 -0800 (PST)

On 2023/12/7 02:56, Jason Gunthorpe wrote:
> On Fri, Nov 17, 2023 at 05:18:16AM -0800, Yi Liu wrote:
>> +static int intel_nested_cache_invalidate_user(struct iommu_domain *domain,
>> +					      struct iommu_user_data_array *array,
>> +					      u32 *cerror_idx)
>> +{
>> +	struct dmar_domain *dmar_domain = to_dmar_domain(domain);
>> +	struct iommu_hwpt_vtd_s1_invalidate inv_info;
>> +	u32 index;
>> +	int ret;
>> +
>> +	/* REVISIT:
>> +	 * VT-d has defined ITE, ICE, IQE for invalidation failure per hardware,
>> +	 * but no error code yet, so just set the error code to be 0.
>> +	 */
>> +	*cerror_idx = 0;
>> +
>> +	for (index = 0; index < array->entry_num; index++) {
>> +		ret = iommu_copy_struct_from_user_array(&inv_info, array,
>> +							IOMMU_HWPT_DATA_VTD_S1,
>> +							index, __reserved);
>> +		if (ret) {
>> +			pr_err_ratelimited("Failed to fetch invalidation request\n");
>> +			break;
> 
> No error prints on ioctls!

ok, will remove it.

> 
>> +		if (inv_info.addr == 0 && inv_info.npages == -1)
>> +			intel_flush_iotlb_all(domain);
> 
> -1 is clearer written as U64_MAX - same remark for the comment
> documenting it.

sure.

-- 
Regards,
Yi Liu