Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4415369rdb; Mon, 11 Dec 2023 20:35:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvIY4xT/UcW3kgg0woSxszdawM95WaDQqSFMJUyGqDTAlWanqxu1FCM3hYRm8VdW4L04vx X-Received: by 2002:a05:6808:f91:b0:3b9:e2a0:16ac with SMTP id o17-20020a0568080f9100b003b9e2a016acmr7160444oiw.80.1702355753262; Mon, 11 Dec 2023 20:35:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702355753; cv=none; d=google.com; s=arc-20160816; b=Qcfe096eT5+W6aXhkOGDX0qNc86paqCVNohACxflfxWk8p2GOLP5+yfd8hWOpuYGOy z8P5dVOPryU6ZEOUFLRV0YSUzhhu3+xtHM6NnNkkop711TG6uNk+L4WkhKunZgWJq6Mx /AaUKcaVt5uzZ1iOB8moP5VoTXi3Tai9JOI/AuJNuUJsAwEXhH1O/aRVOxhuZFqGbtPE K/aOsvBwt1yu6EQ1kytbLrX2jMRdqW0b0UqAKC9lnxUxiN+yYIcs9ZXNKQqPVzvKaYYv X8j15M4irmUUabXfr7z3p+7ZHRiEn5QM1gJF8MKBPt6dNU4x0u3JQ9zVLOmckBXBZi5O D/YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8Bohq4tNCyiQrGKXtGrfyyoiXbOTbVug9mACSlB8jEE=; fh=StYLK4pwe90cKP8GhVW1J0PswBwVZXme3sTEOE5hGH0=; b=Bvv2VfJLGFbv4L3crKSZWHYHi9IQf+K7E2kM0GsTm2lalE/2/rzRBq/KKCEXis3Zvp ts9QG+qamRRg8HfvJvmXwTlpBOGv57L9UMUgiEuhrp1qbt+qmsVuj+JAFLG7cSSlRRFI 7yN/xHdr7IXvZlq7boNIkeefpK+kBKpduYrU42Jcb6VT7+lnzTOtqiAhg6ijs5E0iDke GJpfCRV0wh4+44RIgY0bGxykxtfMYwWoszo4d79aepqGXze+vimS7RzvJkVlrASsL6FV R87FwW9N9tysXIQflC3ttSKHhwoB7BX4LVGEHixAWGwNscmXa5Y/4Hycuvr4ABQRW+P4 S0uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wy92Xu0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id d18-20020a056a00199200b006cb997a7799si7223665pfl.67.2023.12.11.20.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 20:35:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wy92Xu0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D634D8057435; Mon, 11 Dec 2023 20:35:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229460AbjLLEes (ORCPT + 99 others); Mon, 11 Dec 2023 23:34:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjLLEer (ORCPT ); Mon, 11 Dec 2023 23:34:47 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAB1AA6 for ; Mon, 11 Dec 2023 20:34:54 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE29AC433C8; Tue, 12 Dec 2023 04:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702355694; bh=I4R2B+RBsqShG0X7SO/Qln27isb1UxQm2PVbMLk8OOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wy92Xu0GuNi3RkDwWZAuzbNoIjXotFScQWQgipvCy8rbWuwEtGNNfejlHjThN+JMl 47IMZuY5r71OZiQSS+oTobYoux2XYkkJGsTZmX2r4rwxhT5YW0upI5RB+2eYOqIAaq FrY7N19ZDQWDBgU79AkenynQOiD73Dn1ow0ZzAAtDfWD3dn21gS3fPLRSiy+PmD5eO CHNjFvcfPdIOf2/DXZDZornN/EJsnNiKYar/FWS2KQzm68Iiz1h6xNTZLcC1YE818F isoBWGEF1bIvYOpoykA83aW7SDPHzY4lV21NK4YH3U4Ak+PTDnucDx3jdwrZeQnrAr 2btfDRBwjS89A== Date: Tue, 12 Dec 2023 10:04:49 +0530 From: Vinod Koul To: Paul Cercueil Cc: Lars-Peter Clausen , Nuno =?iso-8859-1?Q?S=E1?= , Michael Hennerich , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] dmaengine: axi-dmac: Small code cleanup Message-ID: References: <20231204140352.30420-1-paul@crapouillou.net> <20231204140352.30420-2-paul@crapouillou.net> <3da88ffe37e1fa20918848fdef8f80e5ae49743a.camel@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3da88ffe37e1fa20918848fdef8f80e5ae49743a.camel@crapouillou.net> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Dec 2023 20:35:51 -0800 (PST) On 11-12-23, 13:15, Paul Cercueil wrote: > Hi Vinod, > > Le lundi 11 d?cembre 2023 ? 17:27 +0530, Vinod Koul a ?crit?: > > On 04-12-23, 15:03, Paul Cercueil wrote: > > > Use a for() loop instead of a while() loop in > > > axi_dmac_fill_linear_sg(). > > > > Why? > > Simplicity? Code quality? It would be great to mention the reason :-) right? -- ~Vinod