Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Jianheng Zhang <Jianheng.Zhang@synopsys.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "open list:STMMAC ETHERNET DRIVER" <netdev@vger.kernel.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        James Li <James.Li1@synopsys.com>,
        Martin McKenny <Martin.McKenny@synopsys.com>
Subject: RE: [PATCH net-next] net: stmmac: xgmac3+: add FPE handshaking
 support
Thread-Topic: [PATCH net-next] net: stmmac: xgmac3+: add FPE handshaking
 support
Thread-Index: Ador+H1+Z6wgRV0bTDW+VJMmnuYc6QAdKJ0AABefjtA=
Date:   Tue, 12 Dec 2023 07:22:24 +0000
Message-ID: <CY5PR12MB6372C8770900AFF821325400BF8EA@CY5PR12MB6372.namprd12.prod.outlook.com>
References: <CY5PR12MB63726FED738099761A9B81E7BF8FA@CY5PR12MB6372.namprd12.prod.outlook.com>
 <d202770a-3a3a-4ee2-b0de-b86e2f3e83ce@lunn.ch>
In-Reply-To: <d202770a-3a3a-4ee2-b0de-b86e2f3e83ce@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cOQ0FOXLoJ41cPNUp2P2X6K5ajH5YlzrtSlXqGKQIS1IxPnrOtePXf2rtKaG?=
 =?us-ascii?Q?xw560AR6u0C5WfPKnMMSixISwBoJAYGgvTTNgDMTTXmEWRggiIQLiiWbP41o?=
 =?us-ascii?Q?MOWJDYMONu//i21VIyuud+NK3RHJhAkKaVkpwbCY/4i84bSsKibRGpHQsok4?=
 =?us-ascii?Q?G23Jp+HkZctpavbsuaAfCO6VXPvgzUMEiXq2dZKor9idKKdGao6mEdL9IDBu?=
 =?us-ascii?Q?d2pb6BdIKzZNWBxre8YbgFvwpaqZ4FfluAtzdwo2xnR7tAYOY0gs+HFLWynE?=
 =?us-ascii?Q?DdKRiIdLmGMIJOgVu6cbRiegSSWWbLtGMlGjARYpKlc5iWckVlkw+TFHqmZv?=
 =?us-ascii?Q?Xo1JSzQrM4w3L2wAHkIO/HQfPdOpV4TOGqQZApDoOrzD/X2YldeItlM+mUoz?=
 =?us-ascii?Q?pJfq+v0difQKR5nxf3GQp/u9GUOsCSyUM+1wQ45I0VVyZPKVamhxQPgfyqey?=
 =?us-ascii?Q?2bYbv1B7d0GHZPoEX5MdNecdp+AQrNktkg4VPh8l4Gv048D0hMVa7ykDtehK?=
 =?us-ascii?Q?kwXBrWAtKB4Z+8Hqjw7RFvOtgTdqnqmvA4eEgwgj3MTAgLRD7RHP17vjih6d?=
 =?us-ascii?Q?r8Ggenbu6lUDB9uao8WeK/exRiXkaiGoEP3qgNGS/T7nnF7CicJy/I0ySgf7?=
 =?us-ascii?Q?I5HG0f2q/6/FO0W+4HbUoc6BeKq5l5JOczHu8YvGEOxSpc+UvFwLod1mFjRl?=
 =?us-ascii?Q?G4XDRnrd3m7LBu3RapHK3OENbkkJqNWeizidEAoQ1VcRtCsA9fbbV9grIyaj?=
 =?us-ascii?Q?N0VQ+jOfyknUeM1F0w2IWL8XdD5S8/03J2wjhq5DPYNUykgo/uSVexL2ytIw?=
 =?us-ascii?Q?xeAc2eaeZYXv6t6VODmtHF9WgMMyXbRzhyyZVrEnUDeycf9BcrlnasxkthLu?=
 =?us-ascii?Q?FE5FcFoaj6kLIQLWzIxVI0HESSrTVJn3QQT6/McMkoTeYkCQJNoWfaGJTxEu?=
 =?us-ascii?Q?MYIe+JUs27ELdI5f8g+Nt+OzM9aj1mi2ughsaFPDcAbRHD7OkPCg/HnExb+m?=
 =?us-ascii?Q?Wj1XeqVktaklBRdvlGOGg9/OfqQE74G/qltLQ9s38BPrF5qfHQflNN9hXuD9?=
 =?us-ascii?Q?v5uwEeOy9LTQBjwzYkeMEVMVjp6a1mOGxjFAL9buFNGiPd4K4m8xitn9S50y?=
 =?us-ascii?Q?kyktW4JU14WMg7kcpOuTP5vuUI17YLQi3FlB55hJcT/2Suc8UWVNQiZHRUVW?=
 =?us-ascii?Q?AH8f5mOvBbfd5xifv/IG11Pgq/g/hOhEFMX7R1CFqDwQCtsRS4Gh/PJIduOJ?=
 =?us-ascii?Q?iHVcN5Q0zn3JBHtZDyX60VaAVfKDQYXMucJlmfL3lCZOtEWnnFw6LtWq0SoW?=
 =?us-ascii?Q?Av8GvCkaVWdlv2Pvcx1hBUtEuAMwYYec7GNzuI9BPNLWJNV09poDz6enOrrw?=
 =?us-ascii?Q?SXHsDFBT1d70iS0OmNyHAdZEYyh8U0jLwUk/GyZ1rKC1R5UgNRXLZF1JCG6Y?=
 =?us-ascii?Q?87t1VNXusfU8jlQwP1DyF//TQU2+4BL8h6xvc5Kh9or8r3CPdGYuBQUnEG14?=
 =?us-ascii?Q?Fai7xJDWBdn8EXDE7CxlB6GWST5Clp/riQ41hoshDvOGnJHs1IN8LhiyrK20?=
 =?us-ascii?Q?vPbQWqXWpFwjIEYNR/jO7h/96eRkmvHwOryAcxJ9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?QTT8LpiYRR4xU8q/jim0e4SmoqnrikeG4xXmrz4GtpWaCa7EuC9/n8D3gU0b?=
 =?us-ascii?Q?OReFkKZKYO4BNmtKgE1mq2Hs3tTFsAqEA5ouvWzlNMpvuRMUTxsaV9dBJTHz?=
 =?us-ascii?Q?uRiv597gkyq8nGaEfcPygz207xEHpr7A14HZWiDxZ1nCsjAemssgrK0EBAIE?=
 =?us-ascii?Q?PfIW1mdf1YGwowGFqKz0wcui+WmSNbA+/hyi5/BbGE+GCdxEAyTpFTYn+T24?=
 =?us-ascii?Q?xGjgzKn7x4RH9yjq4f0gsrJz25C5YR/vQOAdeO4yApKXTr5gbAK4ma82U7bD?=
 =?us-ascii?Q?z4ACWbdDtPrLm7Xjwt8LmiDgPrZOMKEfy09UjqrYeSavInSw4MKHh//rZCdS?=
 =?us-ascii?Q?BRQte+uqrkjJe1HBh1oUi/SyZuhYVA0t6eKbzg0ZxHsj9XfmE92hArkYz6FY?=
 =?us-ascii?Q?7xoZgwe/H2UmdKtTJ1FSAm5hziKwzEv6eTzqiB9HSmEzmuqo/Ski3xfwryj/?=
 =?us-ascii?Q?yMmfMIFQdVtyn6M55Ea/cjvNzCeWRZkflrpMOG7LotbAg1qmwuj7hOcchX9s?=
 =?us-ascii?Q?x9iEAndJQgT3LweDvzL4b7lyyX8c7c/wEVm2U9jgXmDlDEmsE849gZNVuYb6?=
 =?us-ascii?Q?ZU2SUnGLQR7kDwUMkiaRMxeo+kPTnDngXlTboskjw6MLlRLPE+Pn/QvHuM6C?=
 =?us-ascii?Q?OyvFVEfhOF+ftlMCoDWxC79/FB6eUcv4Fb8gyV5b99RE+iKLVVqHqDfVNxz6?=
 =?us-ascii?Q?Psoc+pw4GzAbyzi7SKGHHlnVw70KhcRUU9vcnc2PrgNsuhtsnePAa31RX/9T?=
 =?us-ascii?Q?OwG4FodymY7QB+ppoxGL+RTW1s/ttqNeTPDeOxde60TuLOx85kZyb1301xQw?=
 =?us-ascii?Q?MvbzwGASMnwxzWyyrh0GmrBdwAWGZgeCKA1XKjLwHGIDC/gbvCwAjDymolVM?=
 =?us-ascii?Q?z4DYiRDLm8tapyBom1OWskfzYnfiFKRtJQRPYTd+2fNgpYaEA28RElQqx+Y/?=
 =?us-ascii?Q?/gATLI8IjBd8gBKf9jddDYOodCEJc5nx2fvpKM83r3BuRYqEVnCAg2asBnjF?=
 =?us-ascii?Q?NCvETHNDHMEdyRL5VGpiKouUiKhwdaplcJwlqGhAPuBQCqJnPklu/T8kUloe?=
 =?us-ascii?Q?ZIryXonJjXA2hu8SKVac4NB/Froy6hbb+bRQgfbe4Y8/0yELyFmER/xM8isb?=
 =?us-ascii?Q?XZb7OvWTg71fbp3A4a9OilMtW3cRlfOEOQ=3D=3D?=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6372.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a9284b9-ca2f-4a4d-ba56-08dbfae31670
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2023 07:22:24.3557
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uIyIrPzf+w50iY5oGJrOC0VnF/OKaSvD2lk5imWx+kZNKqawJ6DTa47UaxfAo9uDh4LGxDRAE9w7MZBlBU76xA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6905
X-Proofpoint-ORIG-GUID: IiDDxgEtJ20QjdUDUR16aPRV12E2Qbmz
X-Proofpoint-GUID: IiDDxgEtJ20QjdUDUR16aPRV12E2Qbmz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 mlxscore=0 suspectscore=0 mlxlogscore=762 impostorscore=0 malwarescore=0
 adultscore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 phishscore=0
 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.19.0-2311290000 definitions=main-2312120056
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 23:23:20 -0800 (PST)

Hi Andrew, =20

> > +static int dwxgmac3_fpe_irq_status(void __iomem *ioaddr, struct net_de=
vice *dev)
> > +{
> > +	u32 value;
> > +	int status;
> >
> > -		writel(value, ioaddr + XGMAC_FPE_CTRL_STS);
> > -		return;
> > +	status =3D FPE_EVENT_UNKNOWN;
> > +
> > +	/* Reads from the XGMAC_FPE_CTRL_STS register should only be performe=
d
> > +	 * here, since the status flags of MAC_FPE_CTRL_STS are "clear on rea=
d"
> > +	 */
> > +	value =3D readl(ioaddr + XGMAC_FPE_CTRL_STS);
> > +
> > +	if (value & XGMAC_TRSP) {
> > +		status |=3D FPE_EVENT_TRSP;
> > +		netdev_info(dev, "FPE: Respond mPacket is transmitted\n");
>=20
> netdev_info()?  Is this going to spam the logs? Should it be netdev_dbg()

Yes, netdev_dbg() should be better, let me fix it in the next patch.

Jianheng
>=20
> 	Andrew