Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4475248rdb; Mon, 11 Dec 2023 23:42:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGoR7XjB2woJu6SB6KJs7XRoAEuE9JuISmwaIrhcr0OuxJCy3WUHkt+yhavWjEHozwOh/h X-Received: by 2002:a05:6a21:1f20:b0:190:230:8ea2 with SMTP id ry32-20020a056a211f2000b0019002308ea2mr6009463pzb.62.1702366924144; Mon, 11 Dec 2023 23:42:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702366924; cv=none; d=google.com; s=arc-20160816; b=BXh4uj9VNEBZljnpixdMdBal+5bxYcgOspkvpM21PNYS2IsvtJMuTAlNEAAx7ygB2X MuyR+8G2lGkOO6JlDonSUf8jnKbDb3H+ejm1DNIaOwdCADfRB/4Uq+7k6hL2UqlD6m9d Cs6gvYQrgAyu65Tlj7An6qGmeDuroT25kykB5omOKSscb0edxIyKkvQW9gq5xVN1dNXF xTzfEFxPRpZXnWJYFwleoU7N+ZP32X6QRCPlUgJQUarZRiCqPCqlakkjyg9j3l00sgQ4 CIwFOguL3+IoaYL0TIO+88fH3rCoRSb4rzcEy3JT+CXCjCJABWXYnPaKE4Eg7I9B6JlA HQuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BR0GaKh1S4JeZ9xjnS0mdRlav8bDaJHAovNcXYJH2Vo=; fh=VVLKmls/+L0ZgwLTaAHTHwr1cUcmvPV9FxfM6mFcpYg=; b=f3vUywlYhBJ0r/kYW+05XQxh+mu1q+Jc5fW37I7P7weJa7jjgDXnnsN5fKeWz3/tjU yxHEYAnKNZIntV74EdW+gU9e8G9VPCUQTVqR00W+d3ndgRcolt7UvXH4dAsi5YhUn8C5 Ghisjkv7XUPEQL4pw1n0qbfL6TohJadWaUdcNrIvGW7D66WaAK2464lmHoNXV17ZLUHC GdQwd1hEo41XLD5XwTLygZxl+XypBUGwLPdBMykGoYgV0ON4m7rbjBkKmsFrloyiTt5a 0JItVC0RMLEHM+03nAp6wswHg/KfpcS/TJSTCmKQmnhZN+lyMUC9gkrhauMURVP3oD/P ZRuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=NwcMeZFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c32-20020a634e20000000b005bdfbf1d562si7258908pgb.192.2023.12.11.23.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 23:42:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=NwcMeZFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C9028809F39C; Mon, 11 Dec 2023 23:42:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbjLLHla (ORCPT + 99 others); Tue, 12 Dec 2023 02:41:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjLLHl3 (ORCPT ); Tue, 12 Dec 2023 02:41:29 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35DFC2; Mon, 11 Dec 2023 23:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BR0GaKh1S4JeZ9xjnS0mdRlav8bDaJHAovNcXYJH2Vo=; b=NwcMeZFZ0khJl1V+L+Wl4YRXrd SxUF0Pjlux4EICl+LyraoIkrBjSjaIKVORnpUeoanTFTkehRAb+zVFSXUB8k3Ua5JjkGxA8iHLqhy OCDQer6cxLVIbNo0Q9E4hzOnd08VpZQOZjXRXseM6DcueKjp1VTULYURG3ZFw5beS8MgE7XryCng2 ln8fm0nC01FYPjKzNFvgMDDaZNvUEu/lyG9ciDjbFaMHyB8kfkywdNLplSasCh649akcfoK4zSBN1 EkG7+GNhpYWi/KG34VHJ+X0frnW0GstEtJb0URpxq3BlXajIA1jbFk4k9EGfcVNjadjf7kRXaxMT+ 75zDTO2Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rCxOP-00Awjy-0d; Tue, 12 Dec 2023 07:41:25 +0000 Date: Mon, 11 Dec 2023 23:41:25 -0800 From: Christoph Hellwig To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Jonathan Corbet , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, kernel@quicinc.com, Greg Kroah-Hartman , Rob Herring , Carlos O'Donell , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Dodji Seketeli , Trilok Soni , Satya Durga Srinivasu Prabhala , Jordan Crouse Subject: Re: [PATCH v7 3/3] check-module-params: Introduce check-module-params.sh Message-ID: References: <20231212020259.2451253-1-quic_johmoo@quicinc.com> <20231212020259.2451253-4-quic_johmoo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212020259.2451253-4-quic_johmoo@quicinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 23:42:02 -0800 (PST) On Mon, Dec 11, 2023 at 06:02:59PM -0800, John Moon wrote: > One part of maintaining backwards compatibility with older > userspace programs is avoiding changes to module parameters. Really? I don't think module parameters are a UAPI in the traditional sense. Now if you break a heavily used one you got to fix it, but applying strict stability guarantees on module options which are not availble to normal users or even normal programs doesn't make a whole lot of sense.