Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4476868rdb; Mon, 11 Dec 2023 23:47:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnqivxvEL/8uiwc/tzP6ZbljUYngnL+B37/2bRezkto2x5j+qvgkpPpXepiinif/2aKTLr X-Received: by 2002:a17:90a:8cc:b0:28a:2696:20e8 with SMTP id 12-20020a17090a08cc00b0028a269620e8mr4278608pjn.91.1702367222586; Mon, 11 Dec 2023 23:47:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702367222; cv=none; d=google.com; s=arc-20160816; b=couW+bFgjt8ZQX3+RYPUEq2aL6wkfSU93dBknB9X9yLMwNqUzO5qpyyQML72JHDIW2 dHivbzGg8GBsfZZ1WvHBdRkjQO3zpxO00C3pA13tF0vW0fH3sPi78s6GyeiP5ixG4iYI obt0F88vBE8bRJKvdOb6jS6arbVrWQAZ8+qMNcruhJRbd5TKnnjxaZVxYNPszPT5Jeuf ALvCCfAlE9p2PS2D8wPzZ6bsfG1qmpiQGtFS1g5ix6A6usYVOu7C4YCpDXiZs7qQ21hN 5nGSiLlBaS1RK+5TnJjBC7u8AhBrfN1XfaHKUjLbCIcCCc0hYuqrIApbhHECKrb46UWV /tjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=J6zaba+ZbspiAFr2rLoUw0Ptxv3sCznX+1rQk4lFRlc=; fh=q80UBe27lrRLuLR0eCfzG/rPUaY9ohwSxxfUvE1W9UQ=; b=0ozPSGX0x2luam62nZ0JyBCXScDiaKXQhhIa70CmopHVINlj8k3qWfEytMsEHu5lZh cM8bFQcGDPo+gz+h9zbr//7MWhNWvS5107xWELy3kY39Px8jXZNo8Xm/rSmg0VS9UD9b 8l8sNpBZTcRRJyrsasGK0fDNriCVmcCAOvAKJUo5Syw/TbVayJ3JjRLZnPuiKwXeyrmG FuwPsMEqBy3CHXKjBArw9nApre+Uv+woyWfq/abaKq4MKpHsNX0EFElBpZrTcwjpvwZL h7LCbPk8pzrRSYzFCQ/eZ4Jp1E0V0whemBN7PwuNZBmtos8Gn2ItJkzXCi6kWfH/GpRy mRzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Q2uTqN/M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id z6-20020a17090a66c600b002866d8b14f9si8739001pjl.166.2023.12.11.23.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 23:47:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Q2uTqN/M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7077880A9D61; Mon, 11 Dec 2023 23:46:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345949AbjLLHqn (ORCPT + 99 others); Tue, 12 Dec 2023 02:46:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjLLHqm (ORCPT ); Tue, 12 Dec 2023 02:46:42 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B78EAB; Mon, 11 Dec 2023 23:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=J6zaba+ZbspiAFr2rLoUw0Ptxv3sCznX+1rQk4lFRlc=; b=Q2uTqN/MG8AV+qJ/pcL6OklThn w8Uyb/NKu9NzWDuS+QvzadqyZ3oENcv0mFAJDt27kI6CFb1Li2Irfbs/GGyLbUC6sg7HkfsG9OCbo eWNYx7ei6T9Bk4vAGAkAR8jG3ErhjKZ8o1o81LXnPWWsar2b+mZKqEPRjghnkNmlADH/f9Np3fIt5 qOf/sIQgfpKohW0GSK7V7aMbNWebHxu/cm7SKgdFsgBmMwItMjb6S7Y6Y6ydPy4hQQIcEDJq6q53b xPn/4J58MXAH/A+/veg2daBAnDFRiPHJ/P1ggPlgmihi084se87qDkuv46oCIH307vxuq3V49C9hf 20CIIhFQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rCxTV-00AxFB-1n; Tue, 12 Dec 2023 07:46:41 +0000 Date: Mon, 11 Dec 2023 23:46:41 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: David Howells , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 00/12] Convert write_cache_pages() to an iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <3130123.1687863182@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 23:46:59 -0800 (PST) On Wed, Jun 28, 2023 at 08:31:05PM +0100, Matthew Wilcox wrote: > On Tue, Jun 27, 2023 at 11:53:02AM +0100, David Howells wrote: > > Do you have this on a branch somewhere? > > I just pushed it out to https://git.infradead.org/users/willy/pagecache.git/shortlog/refs/heads/writeback-iter > > Running it through xfstests now. This includes one of Christoph's > suggestions, a build fix for Linus's tree, and a bugfix I noticed last > night, so it's not quite the same as the emails that were sent out in > this thread. I doubt it'll be what I send out for v2 either. So it turns out thіs version still applies fine and tests fine with latest mainline. I've put up a slight tweak here: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/writeback-iter this moves and documents the new fields in struct writeback_control and drops the iomap patch for now as it has conflicts in the VFS tree in this merge window. Do you want me to send this version out, or do you want to take over or is there a good reason not to progress with it?