Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <c4cf3924-f67d-4f04-8460-054dbad70b93@oracle.com>
Date:   Tue, 12 Dec 2023 07:46:51 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 0/7] ext4: Allocator changes for atomic write support with
 DIO
To:     Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc:     linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
        Ritesh Harjani <ritesh.list@gmail.com>,
        linux-kernel@vger.kernel.org,
        "Darrick J . Wong" <djwong@kernel.org>,
        linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, dchinner@redhat.com
References: <cover.1701339358.git.ojaswin@linux.ibm.com>
 <8c06c139-f994-442b-925e-e177ef2c5adb@oracle.com>
 <ZW3WZ6prrdsPc55Z@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
 <de90e79b-83f2-428f-bac6-0754708aa4a8@oracle.com>
 <ZXbqVs0TdoDcJ352@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZXbqVs0TdoDcJ352@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zlh5UWdYQWI5b0hSdlBRN3MvVi96ZytNRDRpWEdhOEVITjNEd0xqaXYwazI4?=
 =?utf-8?B?WEVHK2RUN3Y5YXltOExpRnJaNC8rWVErM2xFaXRhUmg2Q0xoOFhUTWhVVXV3?=
 =?utf-8?B?R2VQMmFsNGhXSTQ2RCtKaVVxN00wWnQ2UDdOMm9pLzBBWEFpZ1ozUDRDU09N?=
 =?utf-8?B?aE8xVktDcFRLckh2RXZtVXZlWFJZb0pUOTRYNHdYV0VscUcxMGRvem9DUVph?=
 =?utf-8?B?a3pLaFE2STBNSVQ3dE5UVDNxM0N2ZXptcHBEdEFZVHo3b0MxMDBmRDFtN2gy?=
 =?utf-8?B?UFRlV2h6VCt0S1pNZEFkTjRwTkpwMWNhV2Q5ckpacGhhM2h3S08rNWNXTzBm?=
 =?utf-8?B?ZDNCckFqVW1rY2dTNEowRWk1OXRNQWNhOXFiSC9EVHdBTE9UZy9VbHZzNm5x?=
 =?utf-8?B?ZlRXMUkwZnZIY3greE9XUkYyQWdoMlhyWG9EWHVOWm1EbGpRb2JaWjR6MzRs?=
 =?utf-8?B?V3RFRWEwL3JKT1RmSExjZmJXQzJEdXdEdWpCOGNiR1lKbXlEVXNCMlN3bWZW?=
 =?utf-8?B?RGJ2M3NKL1BXMWFxYkJxMGlBbXlvM09sU0Z6WUt2clY0QkFSUjRCMVZGU0t3?=
 =?utf-8?B?aFF0V2UxejVRTmE1YVVOUGE0TXA0cXZhcVlyN3JwK005Q1dYM0VZM0Y5eE1j?=
 =?utf-8?B?Rm54dWJscExEcUNraDhEanZXcXBuV0Q1MmUvMHM2MUZaZXRtR0JoYXRIcm5Z?=
 =?utf-8?B?YWVnWVNSYXZUcjlUa0VSUlBsa0QrS1hjYjd1bDlqTXo1VHZtTzJ4L0JWMzYv?=
 =?utf-8?B?WktGd1RPUDFqekF6THQrZXNFTGQrenV5aG5aY3N3eTdQZjZ5aHZnekJLb0JD?=
 =?utf-8?B?WWxvV1dMNWpKbDE5L3pucFRrdG1LcEtVSVNnNDMyZVpib21uS2U2SUF4OGFR?=
 =?utf-8?B?K05ERVJDWHNYMjRoVE9xUUdoWUZuUktVd3g1ZmswOXVtbW95Uy9NbGpMZ1Zl?=
 =?utf-8?B?V0ZpV3FqWlRyVlZ5QlRSRE5MdytrRWNjN2sxbzlYdXN1VDQxL3piWDZmY1VJ?=
 =?utf-8?B?dWZ0UVB2cXVyTmliUnRJb3VHWUI3WkRUT09GQWxIZWtlTlYrUC9LN3pYaWRS?=
 =?utf-8?B?aDFTdEFUUTl1RXZpUEh4OEhlK1FpNUc2UG9iZEljRVN6a0JhYVlUdUtHNWJC?=
 =?utf-8?B?SStqSUFEa2p2WjZLWVZRYkZXcWRvRUp5amVZMmpFTFE0QU42MDBLRjdGdFVT?=
 =?utf-8?B?T25laGs5U2FGUjhEUXgwVmluekRLVmwybFpLRkJpemJaVmV3MEZCd3UxOEpy?=
 =?utf-8?B?QXZjRW1rVndsQWN5NC84MUtMVjBaV0xPK1EyZzM5RW5MbGpVbVA5TjJYL25K?=
 =?utf-8?B?Z2M3T2F1eHNBMGNuYjVEUkhEdjJYRGIweWdYa0N4am1FTXp6VzZEVWFWV2pH?=
 =?utf-8?B?aGhaVkU5NFU3V2NxbHVneWp1SUtGaTNYenAzd1RFQm9sTitWbnMwSEMvV3lW?=
 =?utf-8?B?NFo0cVRPczNCN0pzTGpjMDZUREtuUzdUVXgrdDFOSkJXUFA5L1lBN21UUkgv?=
 =?utf-8?B?SUVya2RxVkNlYm4wVEhSdlBydWp4Uldwd1hsSUwrWHhFUXh5UTRkZlByY2l2?=
 =?utf-8?B?UXBCWmV1bkxOelBiMTcyZkNnaTZhRVg3eFpMK0I0NzJKd05WUWlMQUFuUWp1?=
 =?utf-8?B?WG1nVUR0bFpheER2RkVDY1k2M3ArS1JxZHRNS1luWm9CTFpEQUtSQ3Fzc2VB?=
 =?utf-8?B?L1I1bE5Ld1dOMzVOWVR6QjY4S0ZIZCswSElKTEJjZUs2dldMNTBwdnlFSW41?=
 =?utf-8?B?dFY1NGhvRFNTQXlKckdaNC96VFFhb0Jycmw1L0t0NG9rekRqTzhRSWViU1VZ?=
 =?utf-8?B?dmcrRXNWa2FRVEhndTRCQ0RCMVNYSDE4RFluNkdCRUtTb1hMK29ERVI4TEc4?=
 =?utf-8?B?WXVqSVRPeUpDUDNPbS8wMjQzUGpDZ1BpSmw3OEswUmdyZkVSTXdwQ2Vlc21J?=
 =?utf-8?B?R2M5b0tDdFFGSFpsVUpuTUk4cEhvL2pNQTVIWlpCNUkzYk41eXo3R3JLV1lZ?=
 =?utf-8?B?aFB3TW1DODBZa2NXb2pPK0pheGJ1aEVFSVhSNlhPVHM1WWh6cjgwcG0xY1BY?=
 =?utf-8?B?RHBmdDA5K0xhMnpiNFFNdm9jVVNndmJ4R2lKS0RHVVFRdGhYUFZ2ZjljaE1B?=
 =?utf-8?Q?SX9USGreRLmDqqwVEc8jj/5D4?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eo+C6VdPE3Z/HfuQ6RiTJjJF3HtrFGM5EBqDfntbxhmsrHsfaOseUS6vt4Fih3K6ls/xmiTWBv1hXxCIKtnmd9FAUklvOrkL7Uezu0r2PNLXC0pO2FTTn98sczjv2W8s8bYlLrFgqhVuGXtvyggJQewh2aL7GZ71B33p1pvc+sK3qS138Adp94UYR1UcQTlHEo2vhSFclf8R3aLE0SSQ2L7mdMVBYUZ5f/OxEjzFySEr6d1tmRyu/5mt2I+/RqSDwGQPU3PuJkq93CkLQ6HLdCaw/m8odXjaG9YvJGKiID8QyEDKBDDzkFY1wt8WxJuRvc6BzDxki9lWWBb2fciOU/MGbR/MifU45QMtv5swIpWtbEVIhtEGBQ8/o6PkpT/V8g3DJm5V55hVHsf9Sle70xVh8RNC3wHtA/R2poigP+fxqYKM1B3G9udK+L4eL3iN91AZZwrw4nuQClYblRZ1T1j+4BvObhTtkbeUSD7bijueKApR8W4oOLc90eIqz+C0CQpO9js35WFlg5Y0dEHMPaS9YtSdmXy7PFV5c0LaXSUxTpCNFZvKSdnxF7UqRJg0VrRpoeDUGuWI1F+6WLe6n8mp2HqAXolOef+v5HsnCN2ttD+QBglVoXfFxtK+XJSETO+D8aqp8oiUV4057NT3Ws5FqY4aWLso5ACJ7YKIREA0GFUbBTd/aNZTapAjTmxft3rhB9/kGqTpXufOli8nLCQ27V9k8rZrA0iAeKaJ0yhnMLKBvUQoP6C1mJKJG4PM3zPXhA2jaQ0umLu2UL5osvhWGdsjQ3Vv16NU5Q0V4DLH7+VZWfPWbtXWqT01T0RW3Ap6ysNrb5yUptv5vEkZBQyVZ0bYBHl+0q3qLtWWawlsEhUnUTlf+l+t/PlyYiXYWQkJSm247++f40x89PoeOVMcDDAZ1MRkI4VkqDChWAg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0699aff5-8c0f-4c3a-43ff-08dbfae68330
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 07:46:55.5759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUPuLCr5f6k82auMvpXUxZEsRO8BImt+Sa8ldSf5+ve0FPhUhooAEmCoDiTz/ZZXzgQo9ukcAjjnipk5igWd8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5615
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-12_02,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=869 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312120060
X-Proofpoint-GUID: V3GPE70KL6D4XoLPtR_qhKRayaFdmtp9
X-Proofpoint-ORIG-GUID: V3GPE70KL6D4XoLPtR_qhKRayaFdmtp9
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Dec 2023 23:47:22 -0800 (PST)

On 11/12/2023 10:54, Ojaswin Mujoo wrote:
>> This seems a rather big drawback.
> So if I'm not wrong, we force the extent alignment as well as the size
> of the extent in xfs right.

For XFS in my v1 patchset, we only force alignment (but not size).

It is assumed that the user will fallocate/dd the complete file before 
issuing atomic writes, and we will have extent alignment and length as 
required.

However - as we have seen with a trial user - it can create a problem if 
we don't do that and we write 4K and then overwrite with a 16K atomic 
write to a file, as 2x extents may be allocated for the complete 16K and 
it cannot be issued as a single BIO.

> 
> We didn't want to overly restrict the users of atomic writes by forcing
> the extents to be of a certain alignment/size irrespective of the size
> of write. The design in this patchset provides this flexibility at the
> cost of some added precautions that the user should take (eg not doing
> an atomic write on a pre existing unaligned extent etc).

Doesn't bigalloc already give you what you require here?

Thanks,
John