Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4492087rdb; Tue, 12 Dec 2023 00:26:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdmjnQoVWKx6e3N7Ihbsk6NKvx1iGC6no7R/5KiRWcRyngo7dvaAZ0rGJB5kOdmfXkcpcf X-Received: by 2002:a05:6870:ac29:b0:1fa:2b7a:9ece with SMTP id kw41-20020a056870ac2900b001fa2b7a9ecemr6891755oab.46.1702369586539; Tue, 12 Dec 2023 00:26:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702369586; cv=none; d=google.com; s=arc-20160816; b=kDCnXM2XtOoQhmFoFKclGHcdgUoQ3mVlHHvlBSHQ4KnavrX0ihQYbK1ILxuQtiOZZp ZaE9BDY8XuLKdg57fuJXb1rT9yrHlWV8j6E0lsI8Ol5QG8JwMXDFUuAOH2KdkRlmCaVh 6zM3coCEtWWEvNaHbJ2KuyqMmOGcqQpcBLQIWMXtxrTsdMCrECVo0EcHATEwQCS5WTit yXEWPeaNwoUpoNoPsknnNSG6O0YDiv5+AS1/4or4KcDtedi4A/A7fVxEWbsAMr/Doa1R WBZe+OK0Qbe1oDrl/m76k+Pu9rBmRzEmSC+dGjpkAJI2Z48nTbaZd1qzNn+O50RV9/Q6 V7rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:reply-to:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=6fz4nAb8nUGS3ArYDNs/vK4sV0nt1WOaAjlJfmTKO4Y=; fh=vf5GOZLB+4FiUlQEO9Y2tQOsRQZjzOclLIPhhXvgWuw=; b=0Tkd1HDPPHrO36vJNk2ghsyJVLfEM2RhV6XHGTtr0rUZScRU6KgssUk42mPVsfj1Iw nDQ46RB0gUVEe2LxdM3W7zKTC3JYWMweq/8v8It0/DQOE6cl4HgOgQJVf3AGzqhO1yqW 0EG7+5WBZA8blXgev1MpUbFL6zlBtd/e53WDClsr542IEHmeba8yUK1t9/cug2vAVU6Z V0MGKHrQ6pwdI+YibeD00SA2raxCyMaQUVoMmgm28rUxy1hgvNlsYqbQ7PDJFFliVqF/ oFzEP08S+5mjqWNJmAUYva2JJvpxNeXMLARAyn4SxWmyBt1Jwl9oZklhEpjKDMsA07zO Mz1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qHOE+M+h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id y9-20020a63e249000000b005b9377ee20csi7388829pgj.701.2023.12.12.00.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 00:26:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qHOE+M+h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 25D06808000B; Tue, 12 Dec 2023 00:26:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346288AbjLLIYe (ORCPT + 99 others); Tue, 12 Dec 2023 03:24:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346096AbjLLIWH (ORCPT ); Tue, 12 Dec 2023 03:22:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19479E4 for ; Tue, 12 Dec 2023 00:22:10 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4C6B4C3278B; Tue, 12 Dec 2023 08:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702369326; bh=DflKtxiquDEx3JXqmcKbb67lqiUQbgB8jU7D9d8ZNHc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qHOE+M+hi47XBFdzl8m8q3GBw3r3z0OA/D2a7WcpT9XoDEOWfaUOUpas66YnmLuBm ND56a4P7aws152giMjxsenX1vxkqOlsLkUK+OAuS2GOASyGR2f2ghAE1SNyAkwPdEM BMDUW0QnnXZaRbGivg23Ndtrqg8NHmivPZytNL2ye1GdNd83iE897JcrTKgMrqqmZo KnsV83asl8EiZdFo7tKyGHSuUfGb4Sxh2+9GVyEeBJPvSOXLtgV+sFL2iToHuo6yYk mssQ3YIwuNW/FlOBZJVoYD324j1CCHmC75in86hSA5//p7L9n1aNnAR5uqrWctPSip yatFif9u3mLOw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A22CC4332F; Tue, 12 Dec 2023 08:22:06 +0000 (UTC) From: Nikita Shubin via B4 Relay Date: Tue, 12 Dec 2023 11:20:52 +0300 Subject: [PATCH v6 35/40] pwm: ep93xx: drop legacy pinctrl MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20231212-ep93xx-v6-35-c307b8ac9aa8@maquefel.me> References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> In-Reply-To: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> To: Hartley Sweeten , Alexander Sverdlin , Russell King , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Nikita Shubin , Linus Walleij , Sergey Shtylyov , Damien Le Moal , Andy Shevchenko Cc: Dmitry Torokhov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Arnd Bergmann X-Mailer: b4 0.13-dev-e3e53 X-Developer-Signature: v=1; a=ed25519-sha256; t=1702369322; l=4445; i=nikita.shubin@maquefel.me; s=20230718; h=from:subject:message-id; bh=tSyTdrp7//2OjFOMIVbVHelp0wtoGfTsYEGK5AUgdH0=; =?utf-8?q?b=3DIKYj4xKxM/87?= =?utf-8?q?kCEcPyTuQcaSg+ue8qlALGZOptHYVgfFwOYyahnA16J2MlJiIPReeM9j9lNAS9S4?= D+Hv2iulAqd6/xrAHrGm31bl4aInH2hYdjm8lS2svdl3vRz47FXK X-Developer-Key: i=nikita.shubin@maquefel.me; a=ed25519; pk=vqf5YIUJ7BJv3EJFaNNxWZgGuMgDH6rwufTLflwU9ac= X-Endpoint-Received: by B4 Relay for nikita.shubin@maquefel.me/20230718 with auth_id=65 X-Original-From: Nikita Shubin Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 12 Dec 2023 00:26:09 -0800 (PST) From: Nikita Shubin Drop legacy gpio request/free since we are using pinctrl for this now. Acked-by: Uwe Kleine-König Acked-by: Thierry Reding Acked-by: Linus Walleij Signed-off-by: Nikita Shubin --- arch/arm/mach-ep93xx/core.c | 42 --------------------------------------- drivers/pwm/pwm-ep93xx.c | 18 ----------------- include/linux/soc/cirrus/ep93xx.h | 4 ---- 3 files changed, 64 deletions(-) diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c index b99c46d22c4d..4ddf1a4cba33 100644 --- a/arch/arm/mach-ep93xx/core.c +++ b/arch/arm/mach-ep93xx/core.c @@ -577,48 +577,6 @@ void __init ep93xx_register_pwm(int pwm0, int pwm1) platform_device_register(&ep93xx_pwm1_device); } -int ep93xx_pwm_acquire_gpio(struct platform_device *pdev) -{ - int err; - - if (pdev->id == 0) { - err = 0; - } else if (pdev->id == 1) { - err = gpio_request(EP93XX_GPIO_LINE_EGPIO14, - dev_name(&pdev->dev)); - if (err) - return err; - err = gpio_direction_output(EP93XX_GPIO_LINE_EGPIO14, 0); - if (err) - goto fail; - - /* PWM 1 output on EGPIO[14] */ - ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_PONG); - } else { - err = -ENODEV; - } - - return err; - -fail: - gpio_free(EP93XX_GPIO_LINE_EGPIO14); - return err; -} -EXPORT_SYMBOL(ep93xx_pwm_acquire_gpio); - -void ep93xx_pwm_release_gpio(struct platform_device *pdev) -{ - if (pdev->id == 1) { - gpio_direction_input(EP93XX_GPIO_LINE_EGPIO14); - gpio_free(EP93XX_GPIO_LINE_EGPIO14); - - /* EGPIO[14] used for GPIO */ - ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_PONG); - } -} -EXPORT_SYMBOL(ep93xx_pwm_release_gpio); - - /************************************************************************* * EP93xx video peripheral handling *************************************************************************/ diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c index 7cf05d0b78fb..0d17dbe10fcf 100644 --- a/drivers/pwm/pwm-ep93xx.c +++ b/drivers/pwm/pwm-ep93xx.c @@ -27,8 +27,6 @@ #include -#include /* for ep93xx_pwm_{acquire,release}_gpio() */ - #define EP93XX_PWMx_TERM_COUNT 0x00 #define EP93XX_PWMx_DUTY_CYCLE 0x04 #define EP93XX_PWMx_ENABLE 0x08 @@ -45,20 +43,6 @@ static inline struct ep93xx_pwm *to_ep93xx_pwm(struct pwm_chip *chip) return container_of(chip, struct ep93xx_pwm, chip); } -static int ep93xx_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) -{ - struct platform_device *pdev = to_platform_device(chip->dev); - - return ep93xx_pwm_acquire_gpio(pdev); -} - -static void ep93xx_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) -{ - struct platform_device *pdev = to_platform_device(chip->dev); - - ep93xx_pwm_release_gpio(pdev); -} - static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, const struct pwm_state *state) { @@ -157,8 +141,6 @@ static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, } static const struct pwm_ops ep93xx_pwm_ops = { - .request = ep93xx_pwm_request, - .free = ep93xx_pwm_free, .apply = ep93xx_pwm_apply, }; diff --git a/include/linux/soc/cirrus/ep93xx.h b/include/linux/soc/cirrus/ep93xx.h index ea2b2c1074e4..fc4a2f9d4729 100644 --- a/include/linux/soc/cirrus/ep93xx.h +++ b/include/linux/soc/cirrus/ep93xx.h @@ -37,8 +37,6 @@ struct ep93xx_regmap_adev { container_of((_adev), struct ep93xx_regmap_adev, adev) #ifdef CONFIG_ARCH_EP93XX -int ep93xx_pwm_acquire_gpio(struct platform_device *pdev); -void ep93xx_pwm_release_gpio(struct platform_device *pdev); int ep93xx_ide_acquire_gpio(struct platform_device *pdev); void ep93xx_ide_release_gpio(struct platform_device *pdev); int ep93xx_i2s_acquire(void); @@ -46,8 +44,6 @@ void ep93xx_i2s_release(void); unsigned int ep93xx_chip_revision(void); #else -static inline int ep93xx_pwm_acquire_gpio(struct platform_device *pdev) { return 0; } -static inline void ep93xx_pwm_release_gpio(struct platform_device *pdev) {} static inline int ep93xx_ide_acquire_gpio(struct platform_device *pdev) { return 0; } static inline void ep93xx_ide_release_gpio(struct platform_device *pdev) {} static inline int ep93xx_i2s_acquire(void) { return 0; } -- 2.41.0