Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   "xiaowu.ding" <xiaowu.ding@jaguarmicro.com>
To:     viresh.kumar@linaro.org, Tushar.Khandelwal@arm.com,
        jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org
Cc:     xiaowu.ding@jaguarmicro.com
Subject: [PATCH] mailbox: arm_mhuv2: Fix a bug for mhuv2_sender_interrupt
Date:   Tue, 12 Dec 2023 17:31:47 +0800
Message-Id: <20231212093147.773-1-xiaowu.ding@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AeFbooiVm7FQwkF6wHFPnTyS3DuUdxVV+jWYBowdEX3ISILbYLhEQKEEQsCQ?=
 =?us-ascii?Q?xTygiVoxGSDgCejDVb07WBXmM5SA+TOse/EDF1XfskkZbyQcCfveMNBywFSG?=
 =?us-ascii?Q?y1TKQRmQYzAw5Soy1LlO+N0gQXhM8RYGKyC1mTp+jloxrsfMS9g9TdqeP8fp?=
 =?us-ascii?Q?CIvZKtMYIx1Ev9gOinOjcvud6J8dw1M/vsJaON+eoILXDOwqzsHkhRvyf/Yi?=
 =?us-ascii?Q?jKmtP0vhzzqu0ZT5nqpgULDFC7AYWPTyi3n/lD8v340iivz+pPffDS/8lfs8?=
 =?us-ascii?Q?BngHsstDJ2FUrWJsnFBnNt99JPyfThfGBNkHiBkT5nuGraFgLlVsA3iKU0tt?=
 =?us-ascii?Q?uYTDFtKpNMRbFMYMAzXUa2P9u3uVWuLzErMeBFgZzjEI7hNyLJidbZ9tG7Fr?=
 =?us-ascii?Q?PkDmstTT2h3iCx2He4fGC090I0ZFBzgHh/MJ68NxLO5ODrF/zmhi3Aqgz28i?=
 =?us-ascii?Q?P88iliO7mOG0gd5AiLfnPpEI/CQ+/ImxdcSyXb/JeRazf287S2e+JpwHKcX3?=
 =?us-ascii?Q?WLSi73Og9FxjNdmoFSsAzaODIYziQ6jSVQQAG46DHghAgeudRygKpmiDxQAQ?=
 =?us-ascii?Q?+osG1P8xklzsJsYBEOZ7890HTSaS/Q5DL4b/6PY3LVdhio8AbP0gzYIPPRLU?=
 =?us-ascii?Q?iyqvFbVuY1y8+jeixT+US2hPMV+48Se8wNDI6Gw6Vjyg+NGvZ1XuyosKpM1v?=
 =?us-ascii?Q?6wugx6XRJdkBvtHZb28uf5mPbBtdFNi7L1eU3W0UkLiXXp4qMqD/QLX26YDL?=
 =?us-ascii?Q?nB76JsvbqPasfTVAR/qp2mY3fTlL/x+IG6RtLk5VnjbOpQm8QahvymHz4UDd?=
 =?us-ascii?Q?47xuQZjRxVxB1IyeIZ0Hx3+SZjKdcdYZgwDaQoQqD+4UvpMcfIrr36rgFtM9?=
 =?us-ascii?Q?LR08wIRoL6LePkKtmZEYsazyXFPhk8nKQXNEJMWox1A4BCofJZ6sXakmDvfF?=
 =?us-ascii?Q?U+2GLv6BRTy5fKXkKS7PrILRRSuFdLRPykzWZCACXrZlgXvCGZUVU07T2+Up?=
 =?us-ascii?Q?ssRfOaD1OHtgiDY1RXPbTlV/gqTRoDctAjA6SF6hLeVUrDjTcxOSwezXEE48?=
 =?us-ascii?Q?DVLFnqo1XJGNir9OyuQfxm80hmr8p13y8EjfE/m7gmEkTSVZuJMJWtSA6mGm?=
 =?us-ascii?Q?7cJpYqqbiK+4YYBfgL5bY4NHrQ6Yl5M3Z8N80UXL38Srmuyg1UI3B6vpeOLv?=
 =?us-ascii?Q?zf0xlHLxRpnO9RUUZncAjJ4TWrVhFA9XyyrxJN4YLKllpDXKcE1C4SY7WTZe?=
 =?us-ascii?Q?M5WiJj3PniAtjM4nzSRb1Wo5dYCfe+XYHL1Q6yNyfwvCkavHyqYXH/LcOLi6?=
 =?us-ascii?Q?M9PKg85FvJUBtDH/+eyKAThXpZETeeVGz1yQVabzYg5GIhIHWNBzKSxMMvxA?=
 =?us-ascii?Q?mzv2IDD3PqHIu/kfIuzgcdBH9xE8HYTvJtUyQbhI4a1jN1pLeS4gmX04RZ5R?=
 =?us-ascii?Q?m3XBSewcwqbUASHtFlrgQgmahtiiqX+KlePNRSxcwG8FOQIlVM6z5I7iBUn4?=
 =?us-ascii?Q?ZoCB2ChUBLllJRc0UAoMdOgWnCoNhCNgc9g245P8XdHfgCJ1fFb7TvtybumV?=
 =?us-ascii?Q?wGZpSoCF/xNjJMHCSe5DK/fOSfyGUbm1w4hWimY6vnQO9VImvWrEYeSvQtzU?=
 =?us-ascii?Q?rA=3D=3D?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b95f12b1-b664-4c09-b459-08dbfaf53616
X-MS-Exchange-CrossTenant-AuthSource: PS2PR06MB3432.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 09:32:10.4272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dM569DGNFfo5g8I0y48fVrKacXQNvJL3+XUn0Z9T7bpzbEbSmqUoHVcsFQCSgt9QIcgqsljkATDYuCjntrMCbHgu7Lm7Y7sK49XR4Wz+3l0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4007
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 12 Dec 2023 01:32:33 -0800 (PST)

From: "Xiaowu.ding" <xiaowu.ding@jaguarmicro.com>

Message Handling Unit version is v2.1.

When arm_mhuv2 working with the data protocol transfer mode.
We have split one mhu into two channels, and every channel
include four channel windows, the two channels share
one gic spi interrupt.

There is a problem with the sending scenario.

The first channel will take up 0-3 channel windows, and the second
channel take up 4-7 channel windows. When the first channel send the
data, and the receiver will clear all the four channels status.
Although we only enabled the interrupt on the last channel window with
register CH_INT_EN,the register CHCOMB_INT_ST0 will be 0xf, not be 0x8.
Currently we just clear the last channel windows int status with the
data proctol mode.So after that,the CHCOMB_INT_ST0 status will be 0x7,
not be the 0x0.

Then the second channel send the data, the receiver read the
data, clear all the four channel windows status, trigger the sender
interrupt. But currently the CHCOMB_INT_ST0 register will be 0xf7,
get_irq_chan_comb function will always return the first channel.

So this patch clear all channel windows int status to avoid this interrupt
confusion.

Signed-off-by: Xiaowu.ding <xiaowu.ding@jaguarmicro.com>
---
 drivers/mailbox/arm_mhuv2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/arm_mhuv2.c b/drivers/mailbox/arm_mhuv2.c
index c1ef5016f..9191c5b69 100644
--- a/drivers/mailbox/arm_mhuv2.c
+++ b/drivers/mailbox/arm_mhuv2.c
@@ -542,7 +542,7 @@ static irqreturn_t mhuv2_sender_interrupt(int irq, void *data)
 	struct mhuv2_mbox_chan_priv *priv;
 	struct mbox_chan *chan;
 	unsigned long flags;
-	int i, found = 0;
+	int i, j, found = 0;
 	u32 stat;
 
 	chan = get_irq_chan_comb(mhu, mhu->send->chcomb_int_st);
@@ -553,7 +553,8 @@ static irqreturn_t mhuv2_sender_interrupt(int irq, void *data)
 	priv = chan->con_priv;
 
 	if (!IS_PROTOCOL_DOORBELL(priv)) {
-		writel_relaxed(1, &mhu->send->ch_wn[priv->ch_wn_idx + priv->windows - 1].int_clr);
+		for (j = 0; j < priv->windows; j++)
+			writel_relaxed(1, &mhu->send->ch_wn[priv->ch_wn_idx + j].int_clr);
 
 		if (chan->cl) {
 			mbox_chan_txdone(chan, 0);
-- 
2.34.1