Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4523050rdb; Tue, 12 Dec 2023 01:45:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEd5YcJAISr++dI2xYjeErhznprk+Mt8sQKAO2EPZ4giXLMu46PJ9nJRd5TlbYV99xZ6mMq X-Received: by 2002:a05:6870:c10c:b0:1fa:f7a7:bcb4 with SMTP id f12-20020a056870c10c00b001faf7a7bcb4mr7396840oad.59.1702374344050; Tue, 12 Dec 2023 01:45:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702374344; cv=none; d=google.com; s=arc-20160816; b=JRPoB4woRSrbIWP5FVmjyMjHFZuU6vmlbAmYjIzNd7oK50+3j1iLKY6IGTCddv9MmJ 3F8vVwkq3KAk+7ffy1+KqOLs/sPSyZ9bLrn/yJdQNRndJ1KL4iHS36E1jJLMIPMdg9MY wbuHaB77Hurnd9jQyvjuPwN3TUzmy5pEjaNUNvJPI+u6Q92DLvSDMrCFXRcdN5f1WTsG zb4yJYMCKTrVYuLvGnwPB9l3YZa9/YP3Uje+4L7W5YBJhXKSVdy7a+cGM4rqJi22I4Bv fZHpQOhAPg0PgcnFQjtaDlegmXDLKP5N0oxhOszKO4BrCuUhdo5XXUzf5A9uA5/45VVq ymPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=94p+UQZSMr4vzrhrrlgBDh7qA10Ar2gYNehd9t2N1t8=; fh=5rpSDkUIIXgwxC1G4GaToNjaOCiFVnLKPoXaOkvGD04=; b=MGptozoQY1fGF/dJUBfhbl36B7aRw7zJVKyJ9Q5oDtsdW3rtSDd2VVwEPRCB9Mr/iQ dxs7+OlIaAhg2hZ905JrvbsDliddKlvx8G8zFcZlF26celCmsaaCdNeKOLVJmLD9ebXW 6QJN3+SAKainKXcnx9QDnr2vqaWI67IuB/rEwmdnHK+f/dXjBDMoS5xdaVDp4pfx7Jf+ zqvbkpmHCoEE5YvmTdsaY5BSjF8W8FG/0VvvLHDGn+fBYfLeFI4fU9LEfMZldqNe9Ncs gzMx5DuYVtcGHJPNHzRG35fDSP7WrpRcQUZd9Nfk7I+E2N+w74yoarzIeXU1h3OybrJu sbzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XT5Mbyv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id 6-20020a630d46000000b005b7d9aace9dsi7679331pgn.46.2023.12.12.01.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 01:45:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XT5Mbyv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 50F7D80811D7; Tue, 12 Dec 2023 01:45:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbjLLJov (ORCPT + 99 others); Tue, 12 Dec 2023 04:44:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjLLJou (ORCPT ); Tue, 12 Dec 2023 04:44:50 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B2DD2 for ; Tue, 12 Dec 2023 01:44:57 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-54cb4fa667bso7753888a12.3 for ; Tue, 12 Dec 2023 01:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702374295; x=1702979095; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=94p+UQZSMr4vzrhrrlgBDh7qA10Ar2gYNehd9t2N1t8=; b=XT5Mbyv3Zr8jBCPH77HUVad5JJ2aJClR4nXggTqY94575sE3gWwxauF2ib2G6PJDT6 heUFan95Sc443e2CjghYszkYjqPBNMHC5a860wvgFOUB3btwn4sb+wMBCeCQxnJzujQ0 M+NznvZKI4GuzdwgwhIAP+AR+DBj+UAr7/Ejc3ng6S5uMfs4MtJZYNESkjnSJylGjord jHM/lWxN5omIJtlYc+kml4DmAgK1wOAfzcc/jDtHjCPneVrSyIw3GSQMj/9btVQOCg+b WGUX1qXyMfJ4qkZmwmTLLiikBJwxoZ0AeVzQv8+0AgwdiHDcuMIgDShxfhPDwKXIhOv4 9wmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702374295; x=1702979095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=94p+UQZSMr4vzrhrrlgBDh7qA10Ar2gYNehd9t2N1t8=; b=J7+9nwwyyx7WGJrVK4EmNWAHNPP5IBrgAa0GmkARQ0MG5esFn0dG9nzeZAZ6XunRc0 e6WMdrzTpcHS/iyFuQmxVTgSqVb+60peNZrIhKBRTztRwxVeiYkKsguT+Jw6ziFz8uSc nRZPvSeBhkGZLWbmvZfEii5yPhQeU7DKTOprv2q7nq7Jv5rtvEjUchZk7ljB+4bPluOW EGDjjDvAY+0DJpqSLmGjuotHJBjjr0TBgp21jMjq2VfAApVNusD85PoGM+SuoU7B6brF U0DLqBstn+C3E8LPgoJf50HaweZB44XN8sgNhbr+6M3PKgK2bdhNAzxlsz469nC4uHqn Qo4Q== X-Gm-Message-State: AOJu0YyAdYU9m4h3h/FQCKI8uZe1gipyOuT+vYDewq+1tFNEJUDaOEeg TukdYg+s2969B79mjy6dlXD8ig== X-Received: by 2002:a50:cbc1:0:b0:54c:ac4d:f4b7 with SMTP id l1-20020a50cbc1000000b0054cac4df4b7mr3111551edi.1.1702374295419; Tue, 12 Dec 2023 01:44:55 -0800 (PST) Received: from localhost (h1f2c.n1.ips.mtn.co.ug. [41.210.159.44]) by smtp.gmail.com with ESMTPSA id o29-20020a509b1d000000b0054ca1d90410sm4773417edi.85.2023.12.12.01.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 01:44:55 -0800 (PST) Date: Tue, 12 Dec 2023 12:44:51 +0300 From: Dan Carpenter To: Philipp Hortmann Cc: Tree Davies , gregkh@linuxfoundation.org, anjan@momi.ca, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] Staging: rtl8192e: Remove variable bFirstSeg Message-ID: <347fe54e-d8fe-438e-a1ec-37900ca41f51@suswa.mountain> References: <20231210193705.2131807-1-tdavies@darkphysics.net> <20231210193705.2131807-2-tdavies@darkphysics.net> <2cdb678d-b784-411e-8913-eb7666e08ccc@suswa.mountain> <20793387-da59-4192-bb86-b20aeb127a65@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20793387-da59-4192-bb86-b20aeb127a65@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Dec 2023 01:45:08 -0800 (PST) The struct talks about firmware and it has reserved bits so that's what confused me. You know this code better than I do so since you're fine with it, then I'm fine with it. regards, dan carpenter