Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063AbXLEQj1 (ORCPT ); Wed, 5 Dec 2007 11:39:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751714AbXLEQjU (ORCPT ); Wed, 5 Dec 2007 11:39:20 -0500 Received: from mx1.redhat.com ([66.187.233.31]:59140 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbXLEQjT (ORCPT ); Wed, 5 Dec 2007 11:39:19 -0500 Date: Wed, 5 Dec 2007 08:39:25 -0800 From: Pete Zaitcev To: npiggin@suse.de Cc: akpm@linux-foundation.org, paolo.abeni@email.it, linux-kernel@vger.kernel.org Subject: Re: [patch 12/18] usb: mon nopage Message-Id: <20071205083925.c4a8ca64.zaitcev@redhat.com> In-Reply-To: <20071205071628.007537000@nick.local0.net> References: <20071205071547.701344000@nick.local0.net> <20071205071628.007537000@nick.local0.net> Organization: Red Hat, Inc. X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 852 Lines: 28 On Wed, 05 Dec 2007 18:15:59 +1100, npiggin@suse.de wrote: > Convert USB mon driver from nopage to fault. > if (offset >= rp->b_size) > - return NOPAGE_SIGBUS; > + return VM_FAULT_SIGBUS; > chunk_idx = offset / CHUNK_SIZE; > pageptr = rp->b_vec[chunk_idx].pg; > get_page(pageptr); > - if (type) > - *type = VM_FAULT_MINOR; > - return pageptr; > + vmf->page = pageptr; > + return 0; Looks like a trivial change, I ack this. It's a rarely used API, I have to run tests to see how it works. I'll collect any failing pieces later if any. Signed-off-by: Pete Zaitcev -- Pete -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/