Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Julian Stecklina <julian.stecklina@cyberus-technology.de>
To:     kvm@vger.kernel.org
Cc:     Thomas Prescher <thomas.prescher@cyberus-technology.de>,
        Julian Stecklina <julian.stecklina@cyberus-technology.de>,
        Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] KVM: x86/emulator: emulate movbe with operand-size prefix
Date:   Tue, 12 Dec 2023 10:59:37 +0100
Message-ID: <20231212095938.26731-1-julian.stecklina@cyberus-technology.de>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h5OyoDre7f9HIreByZbZw6j1JDC5BzpBXkdA6GDrZycgvghravkYTKU/mGKC?=
 =?us-ascii?Q?9dQTMFlSik065woUtsWErx4+u3CTGxUDgocqtFzNnyjHTsz+3Fd/DPmCnZ9o?=
 =?us-ascii?Q?lhF51B+q8+YOKtBbLVGDLWE7I6puNeXtG0Xll/5naCWNsldA/Qj2Lc9Wu7he?=
 =?us-ascii?Q?BypLc+eTTYY/Q/IvJ90ZjLMovaiCSpnsIrk8UYZFLnikmtPwbKA0j8XjlTh3?=
 =?us-ascii?Q?2svQLyT3OI82XBsIqoH/WkZhEQIW00Yt4XsAm708U57mh/qzckD+RIzRww53?=
 =?us-ascii?Q?hG2HANSA8y8RjGy/SQ6NKbXILOzS26GOnMpSBm1lYFlSler98nH4wwsjKYVg?=
 =?us-ascii?Q?7RtkoOi3q9MkLPgBAoTI4NPUfYKaYOgMLaFGb6hmTk2aO4FzIXf+TD8j18Zw?=
 =?us-ascii?Q?NQgPG6LSOThILARrOjdkz7hHY9nTuLiuEz2WQ0IkoyoGHUZ4jESsHd+9MwXg?=
 =?us-ascii?Q?i+DcDqwOJeNy+6t4QxlEuW3bsrwrD9m4ziYk49hT4Yc4ZL2o5wlD5+hiql79?=
 =?us-ascii?Q?oHcM2asmIkwdVZLzAVi0VCVQapo4IO/AbB2RnEsSUvV/jVsBVsd5+P1BA0zV?=
 =?us-ascii?Q?UHQ1IWCscWrl5DDUVTkCJjCA2PsvNLbQa2Z8oudVz9Rz5/GTCADYBiaIXmi3?=
 =?us-ascii?Q?51iJVl//ESnqRqi4S2ELf5OHOXrT8PwGrcSVlPY4VO7u77AvRtUKkuHPmzuI?=
 =?us-ascii?Q?/tf6x+W+tbbJ/NputV2nm2G5tqaieRVkbrlMqv6xiJsgL1P/dUCufsH+yxtu?=
 =?us-ascii?Q?WWzvqGmWOXlOd2wnkDoU8kVtjc4E9TuBbbwiqhK4TIPkrfU8FXUh9B6+p87I?=
 =?us-ascii?Q?qXVtwchfIxlH3Da4dVz6nz9nE/2BlCS7cEZcI3xEMrwR6McLc7lbXKFpK4Sz?=
 =?us-ascii?Q?sgzKxkXclyHJA8Tpc9nCjbHVeRlpPjeAKtd6IS/5uyq1qqBuBE/DpNQC6plB?=
 =?us-ascii?Q?RgISEY5+n0dqTjupBJrk4dilHWb8uQbiy4VX+25+7etdDyrU0V4k18jKjwo4?=
 =?us-ascii?Q?cQ/409Xd756dBT8ZEs8CIitSzrbVQzxztJF2q5qbd2YMJyV1c50QWAY7WRyt?=
 =?us-ascii?Q?l4VBJX2yGX2sZN8QU+MDj0VZRj4uaP1OLrrpf6t5SXUTLS0aHILyZO0AtzcA?=
 =?us-ascii?Q?TcHHU7QsHniU0cBMUgxmJqD6fVTbak7jsMKHVAgIRRz8+OKPkMk/MsZ0oAV3?=
 =?us-ascii?Q?7mDH0JhbbA0YEBHkxguVtQgwRb+R/00Z/b49/brWXqKH0hEzjl7HRHnpWLAq?=
 =?us-ascii?Q?aWlCWsfw5FpjZpUvWwwSsejg6yyWqxU1AEAFPITam3qJTKvSH5sriEURLERv?=
 =?us-ascii?Q?6qhrA2EtQxHWvbSxcjdihiKQ2LYlnqAsU6Z1TQELa76zb87jW/blETXMJEBs?=
 =?us-ascii?Q?GF+5SUF7S4Nc2PCbPEjFNP5jQajkhWODie2OJTyjdqeOxN6cMjZkaMFa8atC?=
 =?us-ascii?Q?BUGWlYxzyaD8EtC2fze0SzpCIL/jPelep92hSN36MP4h8eWukN3xDOlTKpuG?=
 =?us-ascii?Q?ffEaUCbG8E6RojCvtSN9TDZD6xXK5dO+OhZHTxmbDE5SmeaUnrdvQS5LcsfF?=
 =?us-ascii?Q?gKTDXcOSb98ASAUjgkemWUCQeFA7fsLyRVIYrgdszg/g0xAxBNm83RCwT/K8?=
 =?us-ascii?Q?8Wcfym2GIzsbj+gu22UZoC6s+sgBmj7Z9CBLgJ5AOJKKyn/ExecRq4tW6b3V?=
 =?us-ascii?Q?A2nqzc0AN8I0dijUWoPMHt2bHyqGcA5ftfQfBXknEXyGbUHt?=
X-OriginatorOrg: cyberus-technology.de
X-MS-Exchange-CrossTenant-Network-Message-Id: fcfb2943-21f2-4369-45c5-08dbfaf91c15
X-MS-Exchange-CrossTenant-AuthSource: FR3P281MB1567.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 10:00:02.9170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f4e0f4e0-9d68-4bd6-a95b-0cba36dbac2e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0p8YRguIZMAI69uniNRCUdiJmKX23DOKZ7oERcRGt7obp7kpMe0xzPp6FjseB5g7q9PiwIHGIeTYr96yDXSua7yDLWZycLbCMLhNAZQCXJWLFHKytCwloqlHlTKPkH6w
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR0P281MB1754
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Dec 2023 02:00:23 -0800 (PST)

From: Thomas Prescher <thomas.prescher@cyberus-technology.de>

The MOVBE instruction can come with an operand-size prefix (66h). In
this, case the x86 emulation code returns EMULATION_FAILED.

It turns out that em_movbe can already handle this case and all that
is missing is an entry in respective opcode tables to populate
gprefix->pfx_66.

Signed-off-by: Thomas Prescher <thomas.prescher@cyberus-technology.de>
Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
---
 arch/x86/kvm/emulate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 2673cd5c46cb..08013e158b2d 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -4502,11 +4502,11 @@ static const struct instr_dual instr_dual_0f_38_f1 = {
 };
 
 static const struct gprefix three_byte_0f_38_f0 = {
-	ID(0, &instr_dual_0f_38_f0), N, N, N
+	ID(0, &instr_dual_0f_38_f0), ID(0, &instr_dual_0f_38_f0), N, N
 };
 
 static const struct gprefix three_byte_0f_38_f1 = {
-	ID(0, &instr_dual_0f_38_f1), N, N, N
+	ID(0, &instr_dual_0f_38_f1), ID(0, &instr_dual_0f_38_f1), N, N
 };
 
 /*
-- 
2.42.0