Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <955d390c57a93406d40985fbd1856bd1c500d75c.camel@redhat.com>
Subject: Re: [PATCH net-next v14 08/13] rtase: Implement net_device_ops
From:   Paolo Abeni <pabeni@redhat.com>
To:     Justin Lai <justinlai0215@realtek.com>, kuba@kernel.org
Cc:     davem@davemloft.net, edumazet@google.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        andrew@lunn.ch, pkshih@realtek.com, larry.chiu@realtek.com
Date:   Tue, 12 Dec 2023 11:09:26 +0100
In-Reply-To: <20231208094733.1671296-9-justinlai0215@realtek.com>
References: <20231208094733.1671296-1-justinlai0215@realtek.com>
         <20231208094733.1671296-9-justinlai0215@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-12-08 at 17:47 +0800, Justin Lai wrote:
> +static netdev_features_t rtase_fix_features(struct net_device *dev,
> +					    netdev_features_t features)
> +{
> +	netdev_features_t features_fix =3D features;
> +
> +	if (dev->mtu > MSS_MAX)
> +		features_fix &=3D ~NETIF_F_ALL_TSO;
> +
> +	if (dev->mtu > ETH_DATA_LEN)
> +		features_fix &=3D ~NETIF_F_ALL_TSO;

This latter condition is strictly more restrictive than the previous
one, you can drop the latter. Also could you please drop a note about
the why of it?

Cheers,

Paolo