Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 12 Dec 2023 11:16:30 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Gan, Yi Fang" <yi.fang.gan@intel.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Javier Martinez Canillas <javierm@redhat.com>,
        John Stultz <jstultz@google.com>, Jens Axboe <axboe@kernel.dk>,
        Andrew Halaney <ahalaney@redhat.com>, Lobakin@kroah.com,
        Aleksander <aleksander.lobakin@intel.com>, Gan@kroah.com,
        linux-kernel@vger.kernel.org,
        Looi Hong Aun <hong.aun.looi@intel.com>,
        Voon Weifeng <weifeng.voon@intel.com>,
        Song Yoong Siang <yoong.siang.song@intel.com>, Lai@kroah.com,
        Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net-next 1/1] driver.h: add helper macro for
 module_exit() boilerplate
Message-ID: <2023121245-unspoiled-aging-214d@gregkh>
References: <20231212094352.2263283-1-yi.fang.gan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212094352.2263283-1-yi.fang.gan@intel.com>
Precedence: bulk

On Tue, Dec 12, 2023 at 05:43:52PM +0800, Gan, Yi Fang wrote:
> For the modules need a module_init() but don't need to do
> anything special in module_exit() might need to have an empty
> module_exit(). This patch add a new macro module_exit_stub() to
> replace the empty module_exit(). The macro is useful to remove
> the module_exit() boilerplate.
> 
> Signed-off-by: Gan, Yi Fang <yi.fang.gan@intel.com>
> ---
>  include/linux/device/driver.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Why would we take a macro that no one actually uses?

Please submit this with a user, you all know that this is the case, how
did it pass your internal reviews (hint, I don't think it did...)

thanks,

greg k-h