Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4546293rdb; Tue, 12 Dec 2023 02:41:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPKYNt5P+gA8Av0In02o6qeyE8ha/ia56Eh4kGRKh8jPtkeRaP1AEWt6Rzi/k9f2UN7ocv X-Received: by 2002:a17:902:ab1a:b0:1d3:3efc:44d6 with SMTP id ik26-20020a170902ab1a00b001d33efc44d6mr298313plb.5.1702377671962; Tue, 12 Dec 2023 02:41:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702377671; cv=none; d=google.com; s=arc-20160816; b=0az358ewnKRSyiCw1CjQyKJdON67uIZBro2Y6qYaN6rOLG/jEKEvN1YpqSqvrucAG3 gocLQ8SUbNK+PMgbX6B0xP8VfXi7yYzNaSv238z1XqPUvRi3dxcoX+H39gXbKARY5PEn mejk4HfXCdoFAPgHSELJ6nnQfpFuKgK6bkhtYiCRq2NY9UCsnzUo2V/JjsnRv0gu/TtP 082EIPvP7DZ93N3BBaD28FSxrcWKBMoGkV0/p0iuyxQPraaFeAQsCTHRIvfv+Dooug/J A4Krc4Arm364snf8EoDgq0vVBc4ttlwTPNXel0J0Uwq9hXbOjfzefSRc08IzI4gsQnt/ 05dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=I2o3mvTs9Het5RaaKKlRK99SUQDSevRQx5L/hK4iyKE=; fh=Nrpij1sCo2zlsbiJN/G3ObxyQsjzK2D3NtGDLmCy5nA=; b=kWlp0bIU9sO0TBWwPgI+yti7qdzba55BLrC2CCLYCegkkHePzWcgTIkZ678ig4LWIY X1PbSJju4u//nZmqaJbGIlZW5Z4xlMvR7PVtmkIryo98nbDQ7YGR/lVV909K27Wd/pp3 7RqNP/CPLoXocME1NRq2q3Yg1/sCo7lAYSDvOMxq+bkdZdkubDVr6vIGhilUoPQ/k5ZF 6lBSg2y/s/ar0aKlCP5C13tJ5op4ZW+ZeKSTvFguGJBo+L0rrnOUOsuX6ZQ8It/R0cYQ uainLbuFNtNCw1VgLV9AchQh89gtkX8Vml0KgV6txJyGKi0iKgFd0DyV/k//GNFaklYr YXbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YeUfoA7R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id jn3-20020a170903050300b001d04dd7cd12si7439373plb.194.2023.12.12.02.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 02:41:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YeUfoA7R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 16F0D8076D04; Tue, 12 Dec 2023 02:40:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346185AbjLLKkT (ORCPT + 99 others); Tue, 12 Dec 2023 05:40:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjLLKkS (ORCPT ); Tue, 12 Dec 2023 05:40:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C3D99F for ; Tue, 12 Dec 2023 02:40:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 2C390C433C9; Tue, 12 Dec 2023 10:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702377624; bh=bNZFXT6uE4NzbeIp42aj++88Ef7ZPb0Co0gmFlN7Hz8=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=YeUfoA7RbtZqZNIm0pyXM/cz0+LtFHXinS+bxpAoD1UAmAxBm5wJ6P1fon3FKq1an fRKWKXzGy/l3AezkYKC0HmAwXAQpxZDxsgYCHPDtVjSvfmuq6PL+vVX88NroEy3uHl HMUHk8m8DI0jyaRHJd2vkhiOk5+LFc0/KkQjGIkhaxDiEBQP3DYguF0kK/INn184EB 84guqI2a0BXGdfR64grRIcck29y5zdt38zYHEv2S3J6iU772+Z35gcK9TUUh+C/sMS og2oeNZ/HAab9QuAjGVEN6O/AMg+Xg9FtIrXdNdQeCs8ulkmIiIoUVzlFOEG+12sQ+ WJaXnVoF8R3SQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 146E7DFC907; Tue, 12 Dec 2023 10:40:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v1 1/1] net: dl2k: Use proper conversion of dev_addr before IO to device From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170237762408.11960.6180714999579283849.git-patchwork-notify@kernel.org> Date: Tue, 12 Dec 2023 10:40:24 +0000 References: <20231208153327.3306798-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20231208153327.3306798-1-andriy.shevchenko@linux.intel.com> To: Andy Shevchenko Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lkp@intel.com X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Dec 2023 02:40:35 -0800 (PST) Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Fri, 8 Dec 2023 17:33:27 +0200 you wrote: > The driver is using iowriteXX()/ioreadXX() APIs which are LE IO > accessors simplified as > > 1. Convert given value _from_ CPU _to_ LE > 2. Write it to the device as is > > The dev_addr is a byte stream, but because the driver uses 16-bit > IO accessors, it wants to perform double conversion on BE CPUs, > but it took it wrong, as it effectivelly does two times _from_ CPU > _to_ LE. What it has to do is to consider dev_addr as an array of > LE16 and hence do _from_ LE _to_ CPU conversion, followed by implied > _from_ CPU _to_ LE in the iowrite16(). > > [...] Here is the summary with links: - [net-next,v1,1/1] net: dl2k: Use proper conversion of dev_addr before IO to device https://git.kernel.org/netdev/net-next/c/68cbdb150d55 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html