Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 12 Dec 2023 13:17:45 +0100
From:   Tommaso Merciai <tomm.merciai@gmail.com>
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     laurent.pinchart@ideasonboard.com, martin.hecht@avnet.eu,
        michael.roeder@avnet.eu, linuxfancy@googlegroups.com,
        mhecht73@gmail.com, christophe.jaillet@wanadoo.fr,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Alain Volmat <alain.volmat@foss.st.com>,
        Paul Elder <paul.elder@ideasonboard.com>,
        Gerald Loacker <gerald.loacker@wolfvision.net>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Daniel Scally <djrscally@gmail.com>,
        Nicholas Roth <nicholas@rothemail.net>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v15 3/3] media: i2c: Add support for alvium camera
Message-ID: <ZXhPabGpUDJNSgiZ@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
References: <20231204094719.190334-1-tomm.merciai@gmail.com>
 <20231204094719.190334-4-tomm.merciai@gmail.com>
 <ZXhGQuqTZogWTJ42@kekkonen.localdomain>
 <ZXhHrhNQfn0uJMjk@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
 <ZXhIaB_NTDtSJmj5@kekkonen.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZXhIaB_NTDtSJmj5@kekkonen.localdomain>
Precedence: bulk

Hi Sakari,
Just a clarification about the following warnings:

Fixed on my side with:

CHECK: Assignment operator '=' should be on the previous line

-       alvium->is_mipi_fmt_avail[ALVIUM_BIT_YUV420_8_LEG]
-                                 = avail_fmt->yuv420_8_leg;
+       alvium->is_mipi_fmt_avail[ALVIUM_BIT_YUV420_8_LEG] =
+                                 avail_fmt->yuv420_8_leg;

CHECK: line length of 81 exceeds 80 columns
#1085: FILE: drivers/media/i2c/alvium-csi2.c:1085:
+		if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])

CHECK: line length of 81 exceeds 80 columns
#1102: FILE: drivers/media/i2c/alvium-csi2.c:1102:
+		if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])


Fixed on my side with:

        /* Create the alvium_csi2 fmt array from formats available */
        for (fmt = 0; fmt < ALVIUM_NUM_SUPP_MIPI_DATA_FMT; fmt++) {
-               if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
+               if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt]
+                               .fmt_av_bit])
                        continue;

Can be ok for you?
If yes I'm going to prepare the patch on top of your media_tree/master
branch.

Thanks & Regards,
Tommaso

On Tue, Dec 12, 2023 at 11:47:52AM +0000, Sakari Ailus wrote:
> Hi Tommaso,
> 
> On Tue, Dec 12, 2023 at 12:44:46PM +0100, Tommaso Merciai wrote:
> > Hi Sakari,
> > 
> > On Tue, Dec 12, 2023 at 11:38:42AM +0000, Sakari Ailus wrote:
> > > Hi Tommaso,
> > > 
> > > On Mon, Dec 04, 2023 at 10:47:16AM +0100, Tommaso Merciai wrote:
> > > > The Alvium camera is shipped with sensor + isp in the same housing.
> > > > The camera can be equipped with one out of various sensor and abstract
> > > > the user from this. Camera is connected via MIPI CSI-2.
> > > > 
> > > > Most of the camera module features are supported, with the main exception
> > > > being fw update.
> > > > 
> > > > The driver provides all mandatory, optional and recommended V4L2 controls
> > > > for maximum compatibility with libcamera
> > > > 
> > > > References:
> > > >  - https://www.alliedvision.com/en/products/embedded-vision-solutions
> > > > 
> > > > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > > 
> > > Could you run
> > > 
> > > 	./scripts/checkpatch.pl --strict --max-line-length=80
> > > 
> > > and address the issues in a patch on top of this set?
> > > 
> > 
> > Yes ofc.
> > You need also the following?
> > 
> > --- a/drivers/media/i2c/alvium-csi2.c
> > +++ b/drivers/media/i2c/alvium-csi2.c
> > @@ -2426,8 +2426,8 @@ static int alvium_probe(struct i2c_client *client)
> >                 goto err_powerdown;
> > 
> >         if (!alvium_is_alive(alvium)) {
> > -               dev_err_probe(dev, ret, "Device detection failed\n");
> >                 ret = -ENODEV;
> > +               dev_err_probe(dev, ret, "Device detection failed\n");
> >                 goto err_powerdown;
> >         }
> > 
> > Let me know. Thanks for your work.
> 
> Thank you, but I've already addressed that in my tree.
> 
> -- 
> Sakari Ailus