Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 12 Dec 2023 12:34:49 +0000
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Tommaso Merciai <tomm.merciai@gmail.com>
Cc:     laurent.pinchart@ideasonboard.com, martin.hecht@avnet.eu,
        michael.roeder@avnet.eu, linuxfancy@googlegroups.com,
        mhecht73@gmail.com, christophe.jaillet@wanadoo.fr,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Alain Volmat <alain.volmat@foss.st.com>,
        Paul Elder <paul.elder@ideasonboard.com>,
        Gerald Loacker <gerald.loacker@wolfvision.net>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Daniel Scally <djrscally@gmail.com>,
        Nicholas Roth <nicholas@rothemail.net>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v15 3/3] media: i2c: Add support for alvium camera
Message-ID: <ZXhTaaXZf2WMkAgr@kekkonen.localdomain>
References: <20231204094719.190334-1-tomm.merciai@gmail.com>
 <20231204094719.190334-4-tomm.merciai@gmail.com>
 <ZXhGQuqTZogWTJ42@kekkonen.localdomain>
 <ZXhHrhNQfn0uJMjk@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
 <ZXhIaB_NTDtSJmj5@kekkonen.localdomain>
 <ZXhPabGpUDJNSgiZ@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZXhPabGpUDJNSgiZ@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
Precedence: bulk

Hi Tommaso,

On Tue, Dec 12, 2023 at 01:17:45PM +0100, Tommaso Merciai wrote:
> Hi Sakari,
> Just a clarification about the following warnings:
> 
> Fixed on my side with:
> 
> CHECK: Assignment operator '=' should be on the previous line
> 
> -       alvium->is_mipi_fmt_avail[ALVIUM_BIT_YUV420_8_LEG]
> -                                 = avail_fmt->yuv420_8_leg;
> +       alvium->is_mipi_fmt_avail[ALVIUM_BIT_YUV420_8_LEG] =
> +                                 avail_fmt->yuv420_8_leg;

This one seems good.

> 
> CHECK: line length of 81 exceeds 80 columns
> #1085: FILE: drivers/media/i2c/alvium-csi2.c:1085:
> +		if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
> 
> CHECK: line length of 81 exceeds 80 columns
> #1102: FILE: drivers/media/i2c/alvium-csi2.c:1102:
> +		if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
> 
> 
> Fixed on my side with:
> 
>         /* Create the alvium_csi2 fmt array from formats available */
>         for (fmt = 0; fmt < ALVIUM_NUM_SUPP_MIPI_DATA_FMT; fmt++) {
> -               if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
> +               if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt]
> +                               .fmt_av_bit])

I wouldn't introduce a line break in these two cases.

>                         continue;
> 
> Can be ok for you?
> If yes I'm going to prepare the patch on top of your media_tree/master
> branch.

Ack.

-- 
Sakari Ailus