Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Tue, 12 Dec 2023 14:44:41 +0200 (EET)
From:   Kai Vehmanen <kai.vehmanen@linux.intel.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
cc:     lgirdwood@gmail.com, broonie@kernel.org,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: hdac_hda: Fix NULL pointer dereference when hda_pvt
 is not set
In-Reply-To: <20231212064533.233748-1-kai.heng.feng@canonical.com>
Message-ID: <alpine.DEB.2.22.394.2312121441490.14041@eliteleevi.tm.intel.com>
References: <20231212064533.233748-1-kai.heng.feng@canonical.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi,

On Tue, 12 Dec 2023, Kai-Heng Feng wrote:

> Kernel splat can be found on boot:
> [    7.906438] BUG: kernel NULL pointer dereference, address: 0000000000000078
> [    7.906449] #PF: supervisor read access in kernel mode
> [    7.906455] #PF: error_code(0x0000) - not-present page
[...]
> This is caused by attempting to dereference hda_pvt, so check if it's
> NULL before using it.
> 
> Fixes: a0575b4add21 ("ASoC: hdac_hda: Conditionally register dais for HDMI and Analog")

can you try this fix already merged to Mark's tree (merged on 7th Dec):

"ASoC: SOF: Intel: hda-codec: Delay the codec device registration"
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=ce17aa4cf2db7d6b95a3f854ac52d0d49881dd49

Br, Kai