Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4645335rdb; Tue, 12 Dec 2023 05:45:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlCnz7vtsem2c2tyyP7TIhrYpsMFAwAjW6O6PYWP5jx47d0pYjwLL9rxQ5gNecywFZFY28 X-Received: by 2002:a05:6358:7e92:b0:170:5223:442d with SMTP id o18-20020a0563587e9200b001705223442dmr1970179rwn.32.1702388717691; Tue, 12 Dec 2023 05:45:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702388717; cv=none; d=google.com; s=arc-20160816; b=znymopUn8AOHLPBKN2WS2co6ztBk/rv6htji6DFjHUVi3Eo42A7+NECAYPevfffwn9 VjlRJfWwZYQ61oLCwO7gN4OvUh3cB0oA73rGqNnwvuBthACK/z9Hf7kJC3X0YpmmTWBl 48h2oWN+xuQehWfJ7LhbjG2HzWYA3mj4zzcvE9lae0ci6vYqbydSfSI9ORLyETNzlu4L BLcNyHqyfKRhbkNrsdBh+qao22+eK1g6HtyIjQoY9QZvP6qVUAkP7PPSDPWO5yQOZL3c Y6ddGxKYlDOxUuuV//dMa0PVsP9u6heWfe5w7NbAz6urTbBPpIwzRkPlRd/UGq1ucWXV dDjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=At4U+IknDT1i6i4Mb1MbZCkX8udrvzNQY8bCVKs+uFg=; fh=dJukztSS+APvLpN6QR1cNhy7RO46D45kkbc/OJdzGAk=; b=HscL2wwh5JOHpg4LsfDyS/M1Q9IdgFoHEQtRPzinhc+TdO+b3I2FmzwI96xdSSQqbo /bSTNLkF8cB5wNAeJttiHysofL4D8YKRWUVXZe9XJvFWhvXzECt45Wf7FWfwf6xsA5xn ZE4F1hLhwBwmUZno/CCQjG2ng5tIWw9D687i4OhivVa4ARLo7xqnQIdQ9p8kWri8g6+C inUb8t2UoUclKbW4R6c5RsDwVU5DanMl1SDL1FQWkCS4kwkiHeAihmb4zY3N3g14xPar q/2tMgWvJSDnRRsvayBA6YanOfjCwmuzNZkhYaqO0i/yDRq1bxi/WOEqDmGXgjMJb1DO arIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id b13-20020a630c0d000000b005bda77217eesi7853662pgl.209.2023.12.12.05.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:45:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EEE1D8079B12; Tue, 12 Dec 2023 05:45:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346612AbjLLNov convert rfc822-to-8bit (ORCPT + 99 others); Tue, 12 Dec 2023 08:44:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346604AbjLLNot (ORCPT ); Tue, 12 Dec 2023 08:44:49 -0500 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E237ED; Tue, 12 Dec 2023 05:44:56 -0800 (PST) Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6d9db2f1ddfso768771a34.0; Tue, 12 Dec 2023 05:44:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702388695; x=1702993495; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0FHgQG76vAAELXoJjrX/NTMafjPLo+txhiRxr9Qp8Mo=; b=auhaQSOmRO15IqW30H7nLcbtcNzirH7c7LM9JZWZbNOIdBLSvE8GAWFh/FqwUOnFB9 342Uy9vG3KAL0PnE7JTTj0cdHurd1S6Cs9SZ4mUWA+AwFE7H2cWYeGcs1feVip8UR5ZV qCfzFUoSeK/C9AXBTq8ItriCkswolLVyx3BYzb72hoO68ZFyS1INq/IFchzrGZ1gAINJ Gh5k2z6pYEVueosbPQxVqUoN6MzVjCqj/3iJoV6DPwsoHqw9cclrvDCXX1dLANTVHGYj WQzqmZEXuLNgZmUcy9SDpzRr1Rw32yd5emKKKzulfwSHJlMLnoKjftF3CqM4NLu1JBc2 wfqw== X-Gm-Message-State: AOJu0YxMJ+Ls/1W5H3xs9cFefrJ36Ny/SoXs/rruCRXMqVRuALmPRQY4 U4o0ypEmYV0g1Zbj+fuapSpWBxjpnsICxtY5P2I= X-Received: by 2002:a05:6820:220d:b0:58d:5302:5b18 with SMTP id cj13-20020a056820220d00b0058d53025b18mr12613201oob.1.1702388695286; Tue, 12 Dec 2023 05:44:55 -0800 (PST) MIME-Version: 1.0 References: <20231205063537.872834-1-li.meng@amd.com> <20231205063537.872834-2-li.meng@amd.com> In-Reply-To: <20231205063537.872834-2-li.meng@amd.com> From: "Rafael J. Wysocki" Date: Tue, 12 Dec 2023 14:44:44 +0100 Message-ID: Subject: Re: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion. To: Meng Li Cc: "Rafael J . Wysocki" , Huang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Shimmer Huang , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , Oleksandr Natalenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 05:45:05 -0800 (PST) On Tue, Dec 5, 2023 at 7:38 AM Meng Li wrote: > > amd-pstate driver also uses SCHED_MC_PRIO, so decouple the requirement > of CPU_SUP_INTEL from the dependencies to allow compilation in kernels > without Intel CPU support. > > Tested-by: Oleksandr Natalenko > Reviewed-by: Mario Limonciello > Reviewed-by: Huang Rui > Reviewed-by: Perry Yuan > Signed-off-by: Meng Li > --- > arch/x86/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 3762f41bb092..3e57773f946a 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1054,8 +1054,9 @@ config SCHED_MC > > config SCHED_MC_PRIO > bool "CPU core priorities scheduler support" > - depends on SCHED_MC && CPU_SUP_INTEL > - select X86_INTEL_PSTATE > + depends on SCHED_MC > + select X86_INTEL_PSTATE if CPU_SUP_INTEL > + select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI > select CPU_FREQ > default y > help > -- This needs an ACK from the x86 maintainers.