Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4646344rdb; Tue, 12 Dec 2023 05:47:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaXw74oHXQkwh1JrJZFW0NCdsI+oMKQD9ycw5qzt+H3Fwkm30GqaNAFTinPOMpvjpSPVI6 X-Received: by 2002:a17:902:728e:b0:1d0:6ffd:836d with SMTP id d14-20020a170902728e00b001d06ffd836dmr2416169pll.120.1702388832366; Tue, 12 Dec 2023 05:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702388832; cv=none; d=google.com; s=arc-20160816; b=g/NIa3tFsXq0yNMEeu2b9TUdsYdQzPdcCoS8rYMqc/knzmUuAy60WOECXAXRfG7Aog 1lYStDgP43OFxDQFa2bsmpe7ZwtWYbuLUqc8XVZz+qRqkUriPlxswKU7IPTLsqj1IaxM 7/jgKQuOcJ9ceR/0sm/hNpVZmPp6ClEMqeTltYKh1HaKMMurhXHPRlxHSDUMhEpMONfU lFcrCqKAz8z2j+h17khyG32X+m/e4L+ZgZoekOzkvMFvgGxEWHDv36WmLruyB8EgotVP cIZ1KFBYjzEh/aNjIvPBDXPjnSDo6akZ8t61jV9pof2u6k+OKWrWP3HljPXVxjykSDHV Ua8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=set8A6teARcsNtBGcuLjtfBXq8qCzPkVvltgaHAyICs=; fh=VTc5iK0v/oMDhzodHvJKcSL+kwgFOP0XqIuOY4sBCTc=; b=DMV4plB5A6H5TyczjoSten+753bxUcjFKlKIB32grOSXVJU2igIxvgsOIYWbCVOH40 9V1hbD20sHFmpdLeGQ9wiaNbMsB8pYOGbiEQuY15F+kMS+AOkCQ2P5VaY7x39hCD/CVq 1fSXc7wW9LsSqoM6CkGer0cFs7Cc77mlDpQGm+47VnxZV2WHLiDan0bpjDnC+qcWkjR9 MFlWlrjP49QYCq/wuddQmbUl6paVA6Ca7uirjPocaubba0KUqduJ9ze3eTpgHrBimFxg lOTZ/yANfGyhrgSEF51h7AnLv+JawtpbhVB0s4DIaLsoE3+v4HqDJnjS3Tzurzx4kmWt xB+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UPDizaqp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id w18-20020a170902e89200b001d0a084b012si7788273plg.558.2023.12.12.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:47:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UPDizaqp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 2773380ACFDD; Tue, 12 Dec 2023 05:47:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376276AbjLLNq4 (ORCPT + 99 others); Tue, 12 Dec 2023 08:46:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346662AbjLLNqz (ORCPT ); Tue, 12 Dec 2023 08:46:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9137A1 for ; Tue, 12 Dec 2023 05:47:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D18DC433C7; Tue, 12 Dec 2023 13:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702388821; bh=mqxh9zunvpb036JZEOLxMSrfLM8AML7StjISr8/NUDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UPDizaqpMsgAC2wnSd8hWh+uF/U5C1z1oKAH5P9f6P0IJXDjXBHa0BJJF6i2tfiNf keSo51yS8RBVKsLDWYkEpWFsCCdadst98HelLd695zkEMwY1C3gDAvLtopVA/ECXrf uwTfxOnAkA+Pps0AKRTPrc2kB5MuacVnNE8xYlHdVjOlYFoqL6MTZvnSOlr1DY+Eov 279NiCHsiGwme2XmVmu7HB0YSqUSmy6GBYMY1/3a6sQVzBpgi0xjvDo4eyRqWsmWNp CU/zAbXQznnX3/dj2e48O5Xp2boLbHWjdN1e69iGTs5k0krjDe/WMWotoLZW8Frv/M BASwnQ0dHZRuA== Date: Tue, 12 Dec 2023 14:46:58 +0100 From: Frederic Weisbecker To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Andrew Cooper , linux-tip-commits@vger.kernel.org, "Rafael J. Wysocki" , x86@kernel.org Subject: Re: [tip: x86/core] x86: Fix CPUIDLE_FLAG_IRQ_ENABLE leaking timer reprogram Message-ID: References: <20231115151325.6262-3-frederic@kernel.org> <170126975511.398.12493947150541739641.tip-bot2@tip-bot2> <20231130111519.GA20153@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130111519.GA20153@noisy.programming.kicks-ass.net> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 05:47:10 -0800 (PST) On Thu, Nov 30, 2023 at 12:15:19PM +0100, Peter Zijlstra wrote: > This is so, because all mwait users should be in __cpuidle section, > which itself is part of the noinstr section and as such > kprobes/hw-breakpoints etc.. are disallowed. > > Notable vmlinux.lds.h has: > > #define NOINSTR_TEXT \ > ALIGN_FUNCTION(); \ > __noinstr_text_start = .; \ > *(.noinstr.text) \ > __cpuidle_text_start = .; \ > *(.cpuidle.text) \ > __cpuidle_text_end = .; \ > __noinstr_text_end = .; So #DB aren't supposed to happen then, right? Or you noticed an mwait user that doesn't have __cpuidle? Thanks.