Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Tue, 12 Dec 2023 15:05:45 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Christophe Kerello <christophe.kerello@foss.st.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Chris Packham <chris.packham@alliedtelesis.co.nz>,
        Johan Jonker <jbx6244@gmail.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v6 20/40] mtd: rawnand: add support for ts72xx
Message-ID: <20231212150545.61806147@xps-13>
In-Reply-To: <29970d694d155dee0c76612f453eaa06a929e2c1.camel@maquefel.me>
References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me>
        <20231212-ep93xx-v6-20-c307b8ac9aa8@maquefel.me>
        <2023121220-shine-caviar-68dc@gregkh>
        <29970d694d155dee0c76612f453eaa06a929e2c1.camel@maquefel.me>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

nikita.shubin@maquefel.me wrote on Tue, 12 Dec 2023 11:35:48 +0300:

> Hello Greg!
>=20
> On Tue, 2023-12-12 at 09:30 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 12, 2023 at 11:20:37AM +0300, Nikita Shubin via B4 Relay
> > wrote: =20
> > > From: Nikita Shubin <nikita.shubin@maquefel.me>
> > >=20
> > > Technologic Systems has it's own nand controller implementation in
> > > CPLD.
> > >=20
> > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > > ---
> > > =C2=A0drivers/mtd/nand/raw/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 7 +
> > > =C2=A0drivers/mtd/nand/raw/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 +
> > > =C2=A0drivers/mtd/nand/raw/technologic-nand-controller.c | 220
> > > +++++++++++++++++++++
> > > =C2=A03 files changed, 228 insertions(+)
> > >=20
> > > diff --git a/drivers/mtd/nand/raw/Kconfig
> > > b/drivers/mtd/nand/raw/Kconfig
> > > index cbf8ae85e1ae..3937c10dea1c 100644
> > > --- a/drivers/mtd/nand/raw/Kconfig
> > > +++ b/drivers/mtd/nand/raw/Kconfig
> > > @@ -449,6 +449,13 @@ config MTD_NAND_RENESAS
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Enables suppor=
t for the NAND controller found on Renesas
> > > R-Car
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Gen3 and RZ/N1=
 SoC families.
> > > =C2=A0
> > > +config MTD_NAND_TS72XX
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0tristate "ts72xx NAND cont=
roller"
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends on ARCH_EP93XX && =
HAS_IOMEM
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Enables support for=
 NAND controller on ts72xx SBCs.
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 This is a legacy dr=
iver based on gen_nand. =20
> >=20
> > Why is a new "legacy driver" being written these days?=C2=A0 Why not do=
 it
> > properly? =20
>=20
> Sorry, my bad, description is a leftover from older description (when i
> was allowed to submit a legacy one).
>=20
> The driver is mostly new, shiny and approved by Miquel:
>=20
> https://lore.kernel.org/lkml/20231004103911.2aa65354@xps-13/
>=20
> The KConfig description should be fixed.

Indeed, later submissions carried a brand new implementation which no
longer leverages any legacy hook. The Kconfig description is wrong,
good catch.

Thanks,
Miqu=C3=A8l