Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 12 Dec 2023 08:44:21 -0600
From:   Andrew Halaney <ahalaney@redhat.com>
To:     'Guanjun' <guanjun@linux.alibaba.com>
Cc:     neil.armstrong@linaro.org, agross@kernel.org, andersson@kernel.org,
        konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/1] soc: qcom: Fix compile error caused by uncorrectable
 definition of TRACE_INCLUDE_PATH
Message-ID: <kulysgxsa2lazwpbmovqtide3kvt6qq2dwtxmmi3ugznteo233@67ayvx2lduhi>
References: <20231209074716.2689401-1-guanjun@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231209074716.2689401-1-guanjun@linux.alibaba.com>
Precedence: bulk

On Sat, Dec 09, 2023 at 03:47:16PM +0800, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 
> Compiler reports the error message when compiling the file drivers/soc/qcom/pmic_pdcharger_ulog.c:
>   - ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory
>       95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> 
> TRACE_INCLUDE_PATH shoule be relative to the path include/trace/define_trace.h, not
> the file including it. Fix it.
> 
> Fixes: 086fdb48bc65d(soc: qcom: add ADSP PDCharger ULOG driver)
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>

For what it is worth I sent a similar patch (which handled this by using
the CFLAG -I recommendation) over here about a week ago:

    https://lore.kernel.org/linux-arm-msm/20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com/

I keep disabling this driver locally when developing (or picking up that
patch) until something gets scooped up.

> ---
>  drivers/soc/qcom/pmic_pdcharger_ulog.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.h b/drivers/soc/qcom/pmic_pdcharger_ulog.h
> index 9d5d9af4fbe4..3ac994d160bd 100644
> --- a/drivers/soc/qcom/pmic_pdcharger_ulog.h
> +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.h
> @@ -28,7 +28,7 @@ TRACE_EVENT(pmic_pdcharger_ulog_msg,
>  /* This part must be outside protection */
>  
>  #undef TRACE_INCLUDE_PATH
> -#define TRACE_INCLUDE_PATH .
> +#define TRACE_INCLUDE_PATH ../../../drivers/soc/qcom/
>  
>  #undef TRACE_INCLUDE_FILE
>  #define TRACE_INCLUDE_FILE pmic_pdcharger_ulog
> -- 
> 2.39.3
> 
>