Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <ace772f1-475a-4d20-9bf3-3b9901d48dd7@amd.com>
Date:   Tue, 12 Dec 2023 09:00:24 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] PCI/AER: Use 'Correctable' and 'Uncorrectable' spec
 terms for errors
To:     Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org
Cc:     Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Oliver O'Halloran <oohall@gmail.com>,
        Robert Richter <rrichter@amd.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>
References: <20231206224231.732765-1-helgaas@kernel.org>
 <20231206224231.732765-2-helgaas@kernel.org>
Content-Language: en-US
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20231206224231.732765-2-helgaas@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2J1eUdkRTZYa3p6Q3c1OXVxdmxHeVZ0dW5IeTRpdHhFWUlkV2kxWTBjeDlu?=
 =?utf-8?B?akFLdjV0SXJNL3JDZy9oUUxNMWtncEhQcGFTeHhwaUxoSGtudDY3MFhOWTBj?=
 =?utf-8?B?Uis2S0dDT1JxZTlNdStyUEVCcUtSK05YdDNNNlRiZlRxSml0dVg3Ykx1bmEr?=
 =?utf-8?B?MHRzQzdzUlJRRGVSbU0xMTRLNFNFU0VsV3JHUlEzNXNHOVpGRGpoVVN0ck9D?=
 =?utf-8?B?dnNnY082TzUwNWh3VEYyN0x4c3JHekpnclh5UVBrTU5JVlhESXNqMUJpY2F2?=
 =?utf-8?B?V1M3T094NWhTWkhjeFU1OHNSeE9lUlRuV2dyV1hCUkFpVlk2U3UvbXRpeWx6?=
 =?utf-8?B?ZnE4Sm9PT3UyeFhMendSNkp2eEY5bUxlNWVyN0w4bHRYNlFBR095endFRzhv?=
 =?utf-8?B?d2xEK2JlSTBEL21QZmt5elpONXpSa0ZPWDNHaGI1Z1AxVjlqQ2xWekJyNXp0?=
 =?utf-8?B?US9BTWpkVlZ5VHdaUnV0Um1SMXplQzNSZFZzTlcrV3RyWVAwZmY2MXljNVlp?=
 =?utf-8?B?Ym5EbGJ3b29vd2ZQZi9KRmVSaG1GZDNKNmhIOGZTcXhaak5qTXk5OGczVGRD?=
 =?utf-8?B?SWtzWUg3ZlJUcWV6NWFlLzl5S2tLaHppMXBOcXlrWTZnU1FFKzQ1WlJmYXIw?=
 =?utf-8?B?M3liaURWOGcwTVk5Y2ZEWnFTRk1VMEMrV2RPeUcyQyt1akdHREo1K2lWOWtJ?=
 =?utf-8?B?TG9YSjRqMDJYY0V0bzZxUkViT2pYRmhXeWdJMkllL25Ud3FHR2Nxd3VEUFdx?=
 =?utf-8?B?RUFUWVdFMTBqQlU5YjFaai84MFVRWDMrTUN0YXl0TTE1bzhBZzFXejV0WEhL?=
 =?utf-8?B?R2o1MXNiUG9qRFArRlljSGVGZ0JzVUN0ZXZrUjluZWZFNE02QlVmSzNVL0pn?=
 =?utf-8?B?NDI4NTYvRUtnZzRsZ0JqNzF2Z0pLN21ocWh6bHQ4NFJqN1NxNzRmeGRkdGdR?=
 =?utf-8?B?dWRBV2RVWE5XT1J0UElkeW9Ma0dSZEJXaFpQdWd4RkZiYXNPWTIvWEQ2ZHgr?=
 =?utf-8?B?T3ZSd1NpNzQycTM1MXlLUjFiTUVmMDNtVm9za05NdVdvUk9wbHY5dUhiaTI1?=
 =?utf-8?B?dGo1Q2w4MTFzbkhSTkhyd0luOVBPOEIwbzhmWTBtQk0zRGRXL2kyaEFzRU1k?=
 =?utf-8?B?R2d2UlU1R01ZWDEvcitBcDVRcS9ybkZpSUdiazZIcUVEUHNkWG41Snh0MFA2?=
 =?utf-8?B?QWRjVXg4ZEl3RFBvRTVmemhWNzRUUVQzdGk3eWg1YWErR1o0WWl3bkhrUndI?=
 =?utf-8?B?YjlrbmRRL0FWNmxGL3pDUnJTWG0rdU1JUXZPU293aUV2OUFlcGcwYU81VEZh?=
 =?utf-8?B?NExxaTVPckhuOTEvSUZCaFFNcXhVZlh2SjgzT3dmRzQvL0VWMGY1WHB2cFZG?=
 =?utf-8?B?aE5xdk8rWk14UnArVXVLeWJDY0VzNVByNmJlZ0hZMkhCUnFNRS9ScHBBa2Ry?=
 =?utf-8?B?eWY4bEcvaXQ4dm9QM0hFeWNBdHp6QmtlQTk5Q3pGSURudWFneENYWTVhb3hj?=
 =?utf-8?B?ZjVzOVpRWGlscWYySFpPY3RqU2VTMUNTK2hGcVNRcU9uMkpSMEIwbXVkODB3?=
 =?utf-8?B?ODRGQ0JSQmJvVzZ5VkgxWExOUU4rd3dVdzBydGM4U3JtQmVNSTF4cllya3Qv?=
 =?utf-8?B?L0Y0dUV3SFJwc00vcVJwa0pkMjl0RjlDeHdiYmdLcEF0UlRuYVFCazNVaHdF?=
 =?utf-8?B?YlVkUjljUFFSK3FCaGlabHkyNzBYcEt0L3dya2s3S0JDU2s0b2oySFZBcEl5?=
 =?utf-8?B?RWI3Nmo4aTNZZ3pZR2lYaXRpNXBvSXFDdHRtUWRzdkF0WnM0TkkrYWhPK29N?=
 =?utf-8?B?N3RwYzZkWGhTd0NSdXRhazU4K0ZuOUMxbFp0NzJudUNUUkxldlJWdUIvSkVW?=
 =?utf-8?B?bThDV3c2MUg3ekJLMHh6UHFDeTJsQkx2RzNEd2hpK20vNldEYjJzb2VrNVBl?=
 =?utf-8?B?ZXM2RlhYaGtLWW1FakxER2lXOTJhR0I1ZWdtT3Q0VklraWVqdFAwQVl1R1Bn?=
 =?utf-8?B?R3Robjk4R1c2Qkg1WFNYc2xvY1RBM1hnSFUzRW9yUkdOak9VR2pEUWhSWFR3?=
 =?utf-8?B?d3J1akh2blRMVi9Pc1ZpVXBQaEJxQm16YjhSTnI3WGZORGJCaHh4Smoyb09I?=
 =?utf-8?Q?y2Fg121+PIJkw7RQ5RgBVv4tt?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e67b2f-7aea-4f02-c390-08dbfb23134d
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 15:00:27.1380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NTOjfmRZcAgJ/ND5JGKxSy9WJ5VtbCg7DzuNN0lJWbxFA9cGUP70bBKBGmy+R3L2g9rGg8BddKh7V0u4zmvXAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5440
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 12 Dec 2023 07:00:46 -0800 (PST)

Hi Bjorn,

Will help prevent confusion. LGTM. 

On 12/6/23 16:42, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> The PCIe spec classifies errors as either "Correctable" or "Uncorrectable".
> Previously we printed these as "Corrected" or "Uncorrected".  To avoid
> confusion, use the same terms as the spec.
> 
> One confusing situation is when one agent detects an error, but another
> agent is responsible for recovery, e.g., by re-attempting the operation.
> The first agent may log a "correctable" error but it has not yet been
> corrected.  The recovery agent must report an uncorrectable error if it is
> unable to recover.  If we print the first agent's error as "Corrected", it
> gives the false impression that it has already been resolved.
> 
> Sample message change:
> 
>   - pcieport 0000:00:1c.5: AER: Corrected error received: 0000:00:1c.5
>   + pcieport 0000:00:1c.5: AER: Correctable error received: 0000:00:1c.5
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/pci/pcie/aer.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 42a3bd35a3e1..20db80018b5d 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -436,9 +436,9 @@ void pci_aer_exit(struct pci_dev *dev)
>   * AER error strings
>   */
>  static const char *aer_error_severity_string[] = {
> -	"Uncorrected (Non-Fatal)",
> -	"Uncorrected (Fatal)",
> -	"Corrected"
> +	"Uncorrectable (Non-Fatal)",
> +	"Uncorrectable (Fatal)",
> +	"Correctable"
>  };
>  
>  static const char *aer_error_layer[] = {