Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <448c843e-b212-4b21-9c9a-1651a456f4bb@amd.com>
Date:   Tue, 12 Dec 2023 09:00:51 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] PCI/AER: Decode Requester ID when no error info found
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org
Cc:     Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Oliver O'Halloran <oohall@gmail.com>,
        Robert Richter <rrichter@amd.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>
References: <20231206224231.732765-1-helgaas@kernel.org>
 <20231206224231.732765-3-helgaas@kernel.org>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20231206224231.732765-3-helgaas@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1FiMlB1YUlzWndqWFdXUDM4ZzdnSVgreThzaTFuRitMbWo4bjBRNURuWTRY?=
 =?utf-8?B?SDVNODdscVNWUm9jK1ZRTFArcmdvV29sNzJFNkF4TnJLVENlaUhycUlsQ0xY?=
 =?utf-8?B?anYvRHE1c0IrdlZhZXg5YytqanVKNEk3RldENk04QUtneWZvTU1Ra1NxQUF2?=
 =?utf-8?B?ZmZuTlFqK2VMRlVhRnV0clZLNVBFOVg2eWEyREE2R2FNZDVHdGRmcVAwNnlL?=
 =?utf-8?B?ejRXYi9UNTlDaVF5WGtYZVB0ZUtqZUcyL21FVGR4ZUxFVnNvczR4K0FiN1pS?=
 =?utf-8?B?cGJURlViR1ZRSkI4UmNMaDAwUFFWUVBYdlR3REZnTFUyUTV4RTRVRy8vOFR1?=
 =?utf-8?B?aXYwMExRbWxTSHUzUWt0cGZuWFl5dlRpSzZMMUE0WUJpbHFrWkxoZFdNMVZr?=
 =?utf-8?B?bzVIc0x6emdhNkRBVnY3YVpaYjliL0tpMUR1MSs3RGQxbVBMOTVXZ1BjMjVK?=
 =?utf-8?B?QSs3Nzh0QVM1Z2szbGJmcE9vbWFFTzRUSmpaQ1JQaHNNd1p1cW1FRDBSQStp?=
 =?utf-8?B?K3R5MFpJOFlveEpUYnFHMnZ6dnZJTEYrQ2JIT2k0VTVrZGZnd21HdkNCVGRC?=
 =?utf-8?B?TTNsNWs4WldhWUtSVitVZnIrOXRsZ3VlS1BSTjB3S0wyNWpxbFpJN2p0eFJ6?=
 =?utf-8?B?dUxORW5DYThtNE5GdUtLdDhaa1k4QVJrUnlucEFYS3RNNHVXOVJFUUFzbnU1?=
 =?utf-8?B?MDc0YWwwekErQ0hxcFVZV0c0Z0R1bjFsOTVzT0RtMExCU0lIYUc0b0ZSK09U?=
 =?utf-8?B?blZNbmdVcktROW5IWk9jem8wT3ZrMVRVQWV2T0lENkhiQmg2bVI5QmRiVFZY?=
 =?utf-8?B?YjRIY0FzVmxGSEJKejF2UENuc3JrODI3L1JNZ2Q2NlI2QURsUnF3ejF0SCs1?=
 =?utf-8?B?SS9ZVHZzem1NN3NqeGx5YWlSWmRnaENxMkFWeEdGLzJjQUUyT3BhUEVDQnR1?=
 =?utf-8?B?alVJTUNkRU1EK2c4K2llcnM5YmQ1T251Q2lHYUtiZ1Ftc3JPeTBHdEh2UzdM?=
 =?utf-8?B?bVJubFZBSWc3MnZZQjBYclZKUC8vUEFtQ0JaVU9WNHpkL1Z2RWF5amN0T0Q3?=
 =?utf-8?B?ZzRuVlJSaFRxNHJSLzJ0bUl4Yy9WSDRRb0hhVHhSRW5TMEYvVVpqR0NjdjdB?=
 =?utf-8?B?MlBaZXpKWlVmT3JxR2JiZDlGSnE3Z1FISUlHYW1scUNhVWFWNmN3L1oyd3Br?=
 =?utf-8?B?bEJ6eXJtOXlUVFFxbW8zZzhkUGVCTEFjZWkzVzhONEhPWG05dFVRNnEzMWFG?=
 =?utf-8?B?MnNYWVNaSDVmSWRiNFpDb1VIZmNmaUhVRFA0dHJRQ252ejk5QkR4QUdKSUlE?=
 =?utf-8?B?YmMxbmZMR1h3SUFiZm5aMFRvbGt6RVJKRW1hWFM3R1FsRFdPSTc3NjRMZFNx?=
 =?utf-8?B?Y1BHRlJGOTc0WXNJZmdSMU9TdmpvRmR1VmN2MFlPSmhzOUpqNnRVNXVqd3A3?=
 =?utf-8?B?dkUzdW9vcVMrR0QwTnZDdGpFL1JPNktOK0NzZUVNVzlQOHZhSmtGLzRJeXNL?=
 =?utf-8?B?eU92UVNNbFd3L2VkaDN4bHNNaFZpUjJBVy9DZFpQaTR4dTdBUWRjaWkrUmo5?=
 =?utf-8?B?eG5vRTQ1bkkxRHhyYXJoZUdkV2x4eEJNa1BLZS8xQ0hXZHlxZU83UjJBVTNz?=
 =?utf-8?B?Wm9xZlhVRHlHYXJ4QUd4cS9XNGpPeG5xZTJQMlFvZkpqRW4rMTV1ZGxvUDFr?=
 =?utf-8?B?bEd1OEUvRzk1ak12b1ROTFpka0h0dWFhR0Irak9aNWVRM0Y2Zk9jR1lNMFQ2?=
 =?utf-8?B?RGpCTTMzVi8wZjlOQWc2cUN6Qkt1bFVXZ0trZDNTNnA5dzNLSTNsUjFMV1hF?=
 =?utf-8?B?UkpTbktGQ09WZHpUcE1GbVNBU3lPbFlqVWxVSUYwS3ZkVjZGTlFlaHFPek1W?=
 =?utf-8?B?TCs2aERKOHpybmNkZXdOTEFiWXIvb01RQUwwVnlYT1FFUWRwSnNMb0lWaGps?=
 =?utf-8?B?eS9BbTNRWmZuR0liWWpSd0pxRExTdVFjVWh0eGxnK0V2dzZXZ1l2TFBkY3FM?=
 =?utf-8?B?RXRRTVZ6VU54eEEvVC8rWmtGZnRWejg4RC9kV1ZxdzV2OFMxbGl5OVZwdnBY?=
 =?utf-8?B?UDByV0xSREgxUVpuUUNWaUtPUGN5UEtiaUZ4RVo0ZXFqNlFHWXRFZW13MDFj?=
 =?utf-8?Q?TjmVznRfk0eyWmezmrSjTQISD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d39cdef-5fd8-4b2d-07bb-08dbfb232200
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 15:00:51.7648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ayrfQCMep1zMuvz0A3NI3Fbadf8wWiZ2yMWiRIur5B1gD0Obu1fpxgFsHOzfMuBkont881OZzMOiBHwjuOtFBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5440
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 07:01:15 -0800 (PST)

LGTM

On 12/6/23 16:42, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> When a device with AER detects an error, it logs error information in its
> own AER Error Status registers.  It may send an Error Message to the Root
> Port (RCEC in the case of an RCiEP), which logs the fact that an Error
> Message was received (Root Error Status) and the Requester ID of the
> message source (Error Source Identification).
> 
> aer_print_port_info() prints the Requester ID from the Root Port Error
> Source in the usual Linux "bb:dd.f" format, but when find_source_device()
> finds no error details in the hierarchy below the Root Port, it printed the
> raw Requester ID without decoding it.
> 
> Decode the Requester ID in the usual Linux format so it matches other
> messages.
> 
> Sample message changes:
> 
>   - pcieport 0000:00:1c.5: AER: Correctable error received: 0000:00:1c.5
>   - pcieport 0000:00:1c.5: AER: can't find device of ID00e5
>   + pcieport 0000:00:1c.5: AER: Correctable error message received from 0000:00:1c.5
>   + pcieport 0000:00:1c.5: AER: found no error details for 0000:00:1c.5
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/pci/pcie/aer.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 20db80018b5d..2ff6bac9979f 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -740,7 +740,7 @@ static void aer_print_port_info(struct pci_dev *dev, struct aer_err_info *info)
>  	u8 bus = info->id >> 8;
>  	u8 devfn = info->id & 0xff;
>  
> -	pci_info(dev, "%s%s error received: %04x:%02x:%02x.%d\n",
> +	pci_info(dev, "%s%s error message received from %04x:%02x:%02x.%d\n",
>  		 info->multi_error_valid ? "Multiple " : "",
>  		 aer_error_severity_string[info->severity],
>  		 pci_domain_nr(dev->bus), bus, PCI_SLOT(devfn),
> @@ -929,7 +929,12 @@ static bool find_source_device(struct pci_dev *parent,
>  		pci_walk_bus(parent->subordinate, find_device_iter, e_info);
>  
>  	if (!e_info->error_dev_num) {
> -		pci_info(parent, "can't find device of ID%04x\n", e_info->id);
> +		u8 bus = e_info->id >> 8;
> +		u8 devfn = e_info->id & 0xff;
> +
> +		pci_info(parent, "found no error details for %04x:%02x:%02x.%d\n",
> +			 pci_domain_nr(parent->bus), bus, PCI_SLOT(devfn),
> +			 PCI_FUNC(devfn));
>  		return false;
>  	}
>  	return true;