Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4712636rdb; Tue, 12 Dec 2023 07:23:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkJluQCN0h4kvkMdCt/iQG5W69aKO6tsNQ7G7jKbApC0FmmScKi4f9SWo/rfkndlzuXg9p X-Received: by 2002:a17:903:22c1:b0:1d0:6ffd:9e2a with SMTP id y1-20020a17090322c100b001d06ffd9e2amr6807859plg.124.1702394616928; Tue, 12 Dec 2023 07:23:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702394616; cv=none; d=google.com; s=arc-20160816; b=aTztXAToER6xFNSSd9G6VYRNvDRVOv1bBGZCBUan+EP3vZ4Qv4dnl+IZ2K3GjESQ2h mnCSnT15ATruWkuxrU6tjw9gS0ijCpJXC6fWcgyaHluhoayXNQqgqgEnpQK2v0hNuFVE hOXF41kNbyrLOUcegBMhL/vGG0xBPu3Jvo8YhMrpS7hiDco4MET0vM1g4ieNIry6beqc Ytt+fDWnFOpAMpLRMGcbMxZN+gLwVGMWJYaidHJRKlXKjFCZ9TP4PaCSeZaJ2MLZmo+5 IvsWr3vrJGeTv3RC9u04TJ3CU3ip8TBkYcb0QBfkSLBPVdjXdvKTVbRh00LyKcbYS4cX DHow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:autocrypt:references:cc:to:content-language:subject :reply-to:from:user-agent:mime-version:date:message-id :dkim-signature; bh=zLveY+Pokx5uDRZES3S6PKB5X3Hgy390Dfo3ty9xqJ4=; fh=MxtchBM88bvzAyNHkdYTeScfEoKhL21kCwjCjqDudi8=; b=uWeg8n1MqoU9m4mUa9hdI1UEgsttPSgTH6OomPijCxqr4bsiAgqGHn0cCg84chU9um EOAPmGxsci0wMXXKpK2+1PWNEaIYEY3Ej4hAzaDB7tFQbPKCz4O1InIIXRiVBbfQqQYU o7+JU84dnWFbpTGORqH72G8wA+PEKBCt5nRF3i6iQWdry3eT2lrnEhssxx8g4m9SmpOX LZKq49DUr2W4Ank/qbJqk8Ayxiay4Mz49FSIJSblJMocjq2MFsybgm/4oG1s0RJRhJ5I YRHXMZacH6svJZA0nTgUYzaLWrHg5yg0f+ceCVBigI4/agTHnL6avbTztV5PxMFaZLsk vOfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vTQfc8U9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id p8-20020a170903248800b001d0c906f613si7724970plw.492.2023.12.12.07.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 07:23:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vTQfc8U9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6E6EF80C5C86; Tue, 12 Dec 2023 07:23:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376649AbjLLPXT (ORCPT + 99 others); Tue, 12 Dec 2023 10:23:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376637AbjLLPXR (ORCPT ); Tue, 12 Dec 2023 10:23:17 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE5B1D3 for ; Tue, 12 Dec 2023 07:23:23 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3334254cfa3so3289179f8f.1 for ; Tue, 12 Dec 2023 07:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702394602; x=1702999402; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zLveY+Pokx5uDRZES3S6PKB5X3Hgy390Dfo3ty9xqJ4=; b=vTQfc8U9HISCw/PAv10osMjSMrbCZ3gjwIghpMESVFD7adzzENdJUP9jY7sM+SfqKC 6C9DiaNYs9PGudMfqXGtrpVvUqaM+M5csReKiem1gce5ZJTD7bUo7XC+Xf7OTvG4pgjR hpt7LJ+p45E04emK0lVH8PKq8LCTxsN7JvEbGGD+gvd/7fia83IcPy8rZ9R9HsYAnaJA wBgNMhLQxmPMjkL5yhotuX7N1zIyUWruyy5rMf6gkzRryjsNGPLLapE29GJizcp8OFtg RmWAhdq6amie7ihb1B+GKXBusBeGEWeAbCHoE6vaZdo+/rYGrg5b/9rm3ZCdKxblFzxz FUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702394602; x=1702999402; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zLveY+Pokx5uDRZES3S6PKB5X3Hgy390Dfo3ty9xqJ4=; b=v0DTqjse7SXjyecI1CAg83EaSbV5JC7AX2qkyddEib+yjIlYXtErqPlvmLbPtnFxzG +ofTZdus1W7dwO5uKVrUPEMRM2sh7U3iQICMCkWPTiByRwtlmwOsmjj8RLNxDF8vlZA9 JHJtRAO0N40WhBX3UcxfpP8BZ76y4v7bfzMiHUMgl/qB7Wxjo9UbnxuSgreOR6aLFEpa Ua/H99A2Ei0eud/z5uCNspUEUgVh69VAOsLoEaVvZSmtkOnhLrZqWBL/XLULVZeZwNDY 74IHIaWu77xy6/gyck1ftFTTBY/PRIY1thJAOXkg8+J3hC5d1UPT6iYERab7YMfvVPja GJjw== X-Gm-Message-State: AOJu0YzVxfVoacEQnAfHdUNv+iLnz7RydTj06yYjyt3csgaAsIiT9LcC nzf6lyK3eVvBqF89XVHbOqMzXA== X-Received: by 2002:adf:fc07:0:b0:333:2fd7:960c with SMTP id i7-20020adffc07000000b003332fd7960cmr3221601wrr.71.1702394602171; Tue, 12 Dec 2023 07:23:22 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:5894:fa62:26b4:bf82? ([2a01:e0a:982:cbb0:5894:fa62:26b4:bf82]) by smtp.gmail.com with ESMTPSA id x15-20020a5d54cf000000b0033635d121besm725476wrv.52.2023.12.12.07.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 07:23:20 -0800 (PST) Message-ID: <320864f5-fdd2-4345-a0dd-b97bcf17f473@linaro.org> Date: Tue, 12 Dec 2023 16:23:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers Content-Language: en-US, fr To: Andrew Halaney , Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Dec 2023 07:23:34 -0800 (PST) Hi Andrew, On 06/12/2023 00:05, Andrew Halaney wrote: > As specified in samples/trace_events/Makefile: > > If you include a trace header outside of include/trace/events > then the file that does the #define CREATE_TRACE_POINTS must > have that tracer file in its main search path. This is because > define_trace.h will include it, and must be able to find it from > the include/trace directory. > > Without this the following compilation error is seen: > > CC drivers/soc/qcom/pmic_pdcharger_ulog.o > In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, > from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: > ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > | ^ > compilation terminated. I never experienced such error, and no CI even reported it, can you explain how you got this ? Thanks, Neil > > Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") > Signed-off-by: Andrew Halaney > --- > drivers/soc/qcom/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index 110108e23669..05b3d54e8dc9 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS) += pdr_interface.o > obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink.o > obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink_altmode.o > obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG) += pmic_pdcharger_ulog.o > +CFLAGS_pmic_pdcharger_ulog.o := -I$(src) > obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o > qmi_helpers-y += qmi_encdec.o qmi_interface.o > obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o >