Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 12 Dec 2023 11:27:25 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: Re: [PATCH 3/3] vfio: Report PASID capability via
 VFIO_DEVICE_FEATURE ioctl
Message-ID: <20231212152725.GJ3014157@nvidia.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-4-yi.l.liu@intel.com>
 <20231211110345.1b4526c6.alex.williamson@redhat.com>
 <SJ0PR11MB674458A8B7319F30A67FE55F928EA@SJ0PR11MB6744.namprd11.prod.outlook.com>
 <20231211203946.35552183.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231211203946.35552183.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5ngGbAmEXeevY3OtsuhtR9rrUJ59jBHpa44kYjJX7df9PAwIK/IdDu3yiN1m?=
 =?us-ascii?Q?SGDhHSd4ir/TWuFBzXj/vDYUfyoBcwOp1HkIUNIO3RMmqL5C3FztDhzDxN1T?=
 =?us-ascii?Q?GuvT7KPhsBBZdCatjNoUkr7mq7a+gHMpNUkr6PrAgcIS7QZMP1b/zu1zaUC0?=
 =?us-ascii?Q?fqVcECZwWpm8Or+VIDbahEP3O7b8cW5WpkufL+FW3CeCCJSjmrgCHrIX/teY?=
 =?us-ascii?Q?RSY/ISb6TuGja8GDtHKuGveOyLpU3rPJ81oV/EYJJybYGTMnhnPQeGBUhhw6?=
 =?us-ascii?Q?UHppHYgrDrq2A35oKNTdF43fTm9y9Ud51io0rgBCwhFGGkGI64pMISMXCrmC?=
 =?us-ascii?Q?9QPB7BnqiQuM6UorIk/TKQ/eC8clmIU37YQ0/m78mQh/Dc9gPVTYMR0VlROn?=
 =?us-ascii?Q?1Duo+/WfKjfETlxpGTfGrjEMgmzE3yEf3LxsAHlH94GD2Wjff9SDf90FPSXj?=
 =?us-ascii?Q?OtiGnfvm65vKBTEgOkI83gTF8k4QmUVqAyZzgh3HvczdFybT0Yqp9GfRs2bu?=
 =?us-ascii?Q?O52jlhrCfGTIq9rU56wzSWI3QYl3o0lIYliAYBurOvReGOkOIXzVUduIpYP/?=
 =?us-ascii?Q?rgUo2imUKCK8DSy9wwsf5t9aYWDHy9fDlc6QynZ8HM9eHZVd1F6Ll6wVBDsy?=
 =?us-ascii?Q?2NclVN66RRFMrxBH0tbMAaQ+kRJDe0gumSm1a0iebfWX6xzTBOKklOlSTTYM?=
 =?us-ascii?Q?o/CTDQqch83+lnii6P7F8S+Rx0sxx6f2HvpodkaO/lOO5ZZChuXRzBw//UPf?=
 =?us-ascii?Q?xjFiUuf2RnBlnUjtN8NY6Tqugw0Pa8t5zNvyX0cTLxAkkYujgEV5cBBnxzqM?=
 =?us-ascii?Q?/IIK8sRlbuyclhvXLq7UdSmJFptAjDYM9LBpBPLpq6OU1KCvPU/uC/L7t4fz?=
 =?us-ascii?Q?uPYqOYoizoMZE/aDofjvQsAD+b8/uApcnh/Aca5yvUjdv5cGujuPXGCeDSVY?=
 =?us-ascii?Q?O6bAHbJULBVOdohztaGbdhZ78CHm5JqDfK2IiKtLH1e54xGStC6a1EhDM+YV?=
 =?us-ascii?Q?s5dtcb/fSJRmxtjavj+1yUzr1CE5qlZ/dZL4CaX3YhWGUUMCq5m2sTTRcaj1?=
 =?us-ascii?Q?Pg6TXWbP7y/cJ3e7FNYqTbX9Plm8F9ndP/OTIlJX0X7jfSi92ey7nYSHb8nf?=
 =?us-ascii?Q?EBjQkUw9jc11e2RsMCjnvT6PKYsncPkI2l/HyL2aFbnReVojjvX12a7+JDvd?=
 =?us-ascii?Q?EVAk2m+sPI7HLY+AdHICgn/rKUebdCjya/l2ImLCKzORokuJ07XQu/zPC7qO?=
 =?us-ascii?Q?pDyGhlBQFrvfi7ATxz5EhY6b3LzLGdB7yfz73kS2QrqrXhAgmZbkDt0R5us2?=
 =?us-ascii?Q?mrQKLhdKB8XLxcfq9NNgtZ2zJGk8s9ygWta4uhA0B7Db4PuvgeW7JdIdZXuO?=
 =?us-ascii?Q?cdAae29HWR545mQjD2tUkqL/+USoORFJ72e7mBwhtLG4U7wUOaZNdS4zOXW8?=
 =?us-ascii?Q?xs58nLsNCf2XD32YFCd8CTvc040U6+pqCOxZqRvpeyzapTuOyulbgEe4VFfk?=
 =?us-ascii?Q?Lohct5hJstiXDgB3TUfE+1kTDTzfTLNC43D7zQVPNYH4tHB8LxtNsnYCY2lY?=
 =?us-ascii?Q?Ed32Dia7j+Q3RXp93vgUeOj0EclTfJG3DhegeeI8?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3146ec9d-f590-499e-d1df-08dbfb26d843
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 15:27:26.0151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9wzMEeQoibpKBM97xAB3NFdw6b3r1KSZGzCBDwngf+0TUORuDgsBjvISnUE93VlF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5103
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Dec 2023 07:28:08 -0800 (PST)

On Mon, Dec 11, 2023 at 08:39:46PM -0700, Alex Williamson wrote:

> So how do we keep up with PCIe spec updates relative to the PASID
> capability with this proposal?  Would it make more sense to report the
> raw capability register and capability version rather that a translated
> copy thereof?  Perhaps just masking the fields we're currently prepared
> to expose. 

I think the VMM must always create a cap based on the PCIe version it
understands. We don't know what future specs will put there so it
seems risky to forward it if we don't know that any possible
hypervisor support is present.

We have this problem on and off where stuff in PCI config space needs
explicit hypervisor support or it doesn't work in the VM and things
get confusing.

Jason