Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <a79a13b9-b4d1-45ba-a104-01e911631863@redhat.com>
Date:   Tue, 12 Dec 2023 16:45:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Failed to start Raise network interfaces error
Content-Language: en-US
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org
References: <alpine.DEB.2.22.394.2312102317350.3198@hadrien>
 <21977757-3a63-4586-ae03-e6630c1f009d@redhat.com>
 <d87c79b9-d0d2-2819-030-12c7df86eb38@inria.fr>
From:   Ivan Vecera <ivecera@redhat.com>
In-Reply-To: <d87c79b9-d0d2-2819-030-12c7df86eb38@inria.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12. 12. 23 16:08, Julia Lawall wrote:
> 
> 
> On Tue, 12 Dec 2023, Ivan Vecera wrote:
> 
>> On 10. 12. 23 23:28, Julia Lawall wrote:
>>> Hello,
>>>
>>> Starting with the commit:
>>>
>>> commit 9e479d64dc58f11792f638ea2e8eff3304edaabf
>>> Author: Ivan Vecera <ivecera@redhat.com>
>>> Date:   Fri Oct 13 19:07:51 2023 +0200
>>>
>>>       i40e: Add initial devlink support
>>>
>>> I am not able to boot normally.  The console shows the message
>>>
>>> Failed to start Raise network interfaces
>>>
>>> Searching for this message on th internet produces some old discussions
>>> that suggest to look at the file /etc/network/interfaces.  That file on my
>>> system contains:
>>>
>>> # This file describes the network interfaces available on your system
>>> # and how to activate them. For more information, see interfaces(5).
>>>
>>> source /etc/network/interfaces.d/*
>>>
>>> # The loopback network interface
>>> auto lo
>>> iface lo inet loopback
>>>
>>> auto enp24s0f0
>>> iface enp24s0f0 inet dhcp
>>
>> The problem is maybe with interface name... after this commit the interface
>> should contain port_name suffix. In your case the name should be
>> `enp24s0f0np0`.
>>
>> Could you please check it?
> 
> Thanks for the feedback.  But I'm not clear on how this would work.  Does
> there have to be one name for kernels before this patch and another name
> for kernels starting with this patch?  Or is the new name also acceptable
> for older kernels?

The name of a network interface is configured by udev. And it takes 
network interface attributes and compose a name for it. One of these 
attributes is phys_port_name [1] and if it is provided then its value is 
appended to the name.

Prior this commit the i40e driver didn't provided this attribute so the 
name is (in your case) enp24s0f0. After this commit the value is 
provided so it is appended -> enp24s0f0np0

Look at 'systemd.net-naming-scheme' man page for details how the 
interface names are composed.

Thanks,
Ivan

[1] /sys/class/net/enp2s0f0np0/phys_port_name