Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4740396rdb; Tue, 12 Dec 2023 08:05:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKrBMTF1bc+i63oC2P1L5Q32L6ykcms2RUqq9VxtxjuwYTDn3nZ1ah7cvMEV5dceJ4PDiH X-Received: by 2002:a17:90a:ba92:b0:286:4e07:11f8 with SMTP id t18-20020a17090aba9200b002864e0711f8mr3083005pjr.21.1702397145505; Tue, 12 Dec 2023 08:05:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702397145; cv=none; d=google.com; s=arc-20160816; b=D9nColFbpuG7q5/gxZshudIQYLyq+HHE4fnBkFEFvk9U0g6PmWOXfywgmT3cihLm5Q uBVXEGrVBXR/rvS4ZDoXArQ4jmUPpuczzM6W2RGulx0XNsRQxy5LDTjblHA0Sr/n4IYE Uhipp+gkdds6jYkS1uqaZtGYgASpIdrUY+G7pVYFmYSvQK2/idzpGDQAfDL0+qdxsI8s PqCqcjVqeKFtAhep1hkeKZe7ZHwuSTCYraun6yDUdgUXA77izpe5yvz+bWgrtV3+nXe9 7mQfe3HSO15Hv2H5uCFnKfq437CckHeIoo3Caz4OouxxikjLkm1vwyS/upCEYjFMrzWY wsRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=3eZaZjTc67RTXLFs3YqYbWWZsx/LfDLRaTgIs9OD/Fs=; fh=8ph1+nwqJveCREcwephG0G8Zh+hAwS4ei7vWkf/ZiiE=; b=MLBewwefbzQgXcpz4RPtAa55ohrpdbQSgfEjtLEcxqrIjAXxB/zXEISQn+3TlN48wO xtboKa8+rcPguxpS2N4BufxA+Wvjm9NaLeuNLzFLBQJlpLSbAvAueB8aCBcFuCTSpKI7 D2cmvrtb0tQyAmScKyevByFdPYzy6lbDgbCyltLjCidBWpLu+O9WzBahkxzQvKosZmzl Y1waEwEkkt/wsJCNY2XLfLI76t++bwvpB5oL9dssjE/s2/rSLaqkMaF6ETTTWqvjHCPc kd+pTjhMlWeKLBVSET2t93S9yKHsjoP4l4SRBHMXUAQpotoImG1f3GXbOCgEDa+zqmh2 Uuew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LCRmmo05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id j19-20020a17090a7e9300b0028699acfb2bsi9261445pjl.53.2023.12.12.08.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 08:05:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LCRmmo05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EE6568051B36; Tue, 12 Dec 2023 08:05:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232515AbjLLQFH (ORCPT + 99 others); Tue, 12 Dec 2023 11:05:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232528AbjLLQFF (ORCPT ); Tue, 12 Dec 2023 11:05:05 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B8FAD for ; Tue, 12 Dec 2023 08:05:11 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63252C433C8; Tue, 12 Dec 2023 16:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702397110; bh=shND2JWB5x3Z+S1RTbK6XSI5qan81/apFSZ9av6syEw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LCRmmo05GoXe35HGbVELJxl+iJSKsbGcS7DMz5/zRrwrkJ1Asc4O1ckCoCzGQm2Vo bnS/b8JK2m3bO/xGfj41wH03YUPrU1mOhXh5Wy3O7gwX1z1BYasvfAB3ffFyeH88Ba 6A3kLUpE0b0DaVkBStOVm135c+L49bR+zm90kuHQKMafGzNTghxHwSWlfMtROxmAYG 1tiMHGc9G1/W9zN5mcgqCzB+AzZMwG0Qn6n93X5QijNvpQYIo2EjPUMjfCzSFJGbuN BJjToaL+zoR7L0YJQX2DwS25QxM3xA99ATkdXZm97k0FQQ9Gnjrykxtvw4dBw3HRMM d5+Lvkq9CJ4ig== Date: Tue, 12 Dec 2023 08:05:09 -0800 From: Jakub Kicinski To: Justin Lai Cc: Paolo Abeni , davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, andrew@lunn.ch, pkshih@realtek.com, larry.chiu@realtek.com Subject: Re: [PATCH net-next v14 01/13] rtase: Add pci table supported in this module Message-ID: <20231212080509.48ec4931@kernel.org> In-Reply-To: <0d8195d3c1aaec85e74d7ae2bf5b1a5b9c1a0b78.camel@redhat.com> References: <20231208094733.1671296-1-justinlai0215@realtek.com> <20231208094733.1671296-2-justinlai0215@realtek.com> <0d8195d3c1aaec85e74d7ae2bf5b1a5b9c1a0b78.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Dec 2023 08:05:36 -0800 (PST) On Tue, 12 Dec 2023 10:36:16 +0100 Paolo Abeni wrote: > > +static void rtase_remove_one(struct pci_dev *pdev) > > +{ > > + struct net_device *dev = pci_get_drvdata(pdev); > > + struct rtase_private *tp = netdev_priv(dev); > > + struct rtase_int_vector *ivec; > > + u32 i; > > + > > + for (i = 0; i < tp->int_nums; i++) { > > + ivec = &tp->int_vector[i]; > > + netif_napi_del(&ivec->napi); > > + } > > You must unregister the netdev before napi_del or you will risk races. Or del them in the ndo_open / ndo_stop... Note that ndo_stop is always called if ndo_open was called.