Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4741907rdb; Tue, 12 Dec 2023 08:07:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+aDq2RRZfVvxVH5ebDRaa9QUgZ8hZ1DnJNpGkYDnBKZyhwqHddUVEuy8DRtF4yZYhTYwz X-Received: by 2002:a17:903:234c:b0:1d2:f856:8579 with SMTP id c12-20020a170903234c00b001d2f8568579mr3678409plh.95.1702397250646; Tue, 12 Dec 2023 08:07:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702397250; cv=none; d=google.com; s=arc-20160816; b=qaefv1xjdtIXM5EV/O2Vdr2HhnzuCOWCduMGYakDafjjXxrZQS5Q4aoSfHGRW5h0hm UWu8kdsOzfKwkqy6RGGu+rlcHhjBMlCRjmZwYy6mmELRi6M60URtDRDKw2Gd8cl44w0R zoE2VeUMi7vWroxh8ekpNoVUOnimLQf45FcSE393iJBSiPPtAIJzrJ6VmGfZ2gB3zsLi oA5GmzRioTmpwyUavIbs/mFA/aoINsA5WSPl7RH2cjzMcKvmFXw1s75BSMZRl+LnJryc +7PSEJYDnZq8b+J5C6pzQ2fJhMvECvYUy26fEMtiDXt35y7ffWl1NeOOI02hDisx9kgB 9GFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=CJpdj69LX9IEhqohq156R8WukFK3OJVd0O9X4X2+26Y=; fh=Bd07Nsc/H6raZm/RAWh3fvYmiHlgBrjmxdIX4xchpRI=; b=tm3a/MA1Ik269up31cs8XFkvTjX3v+rmxNViWioGsFx0i7zlmgYWNJkHahYWz+O13M l8oKDjaouO3MGlurRUsApfG+5oMv9daum2I3zvh/rZzLcVamZMQBO2iU1uS3+KnkaMgm UJzbH1tD0s+/+wMkudpRZ2RwD51UxiVVHmLrCWCyy55WHrdpF00Oyn1fUBsIAgjVKFvs kAto85bFDteWvz9nneluhvkqMf0V9WQvvgBGEErj56mdVHgOTilNT2vKQ6dN7B5WPN3H Unp4ziytlOz+Mtm372O9PIily76NAELdGfmEtg4TqMKXonIWbJ7MReLzezD4ze1Oe8RS xtXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="ExG/pMwB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id u8-20020a170902b28800b001d34748e8fbsi244331plr.147.2023.12.12.08.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 08:07:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="ExG/pMwB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8DC6D803C454; Tue, 12 Dec 2023 08:07:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232592AbjLLQHD (ORCPT + 99 others); Tue, 12 Dec 2023 11:07:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232453AbjLLQHC (ORCPT ); Tue, 12 Dec 2023 11:07:02 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC559A; Tue, 12 Dec 2023 08:07:07 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BF8F1E0006; Tue, 12 Dec 2023 16:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702397226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CJpdj69LX9IEhqohq156R8WukFK3OJVd0O9X4X2+26Y=; b=ExG/pMwBBumC4QhP5vNOjlnVV8KqPLC136SVSVEYTsijZN/SA06MhMXAal58wtGcNHldD6 Cshygd0aPgzABApx931nXxMFNn+x5AVJ3PvvpV+/VwKT4fG3Ko7OwKMDQ2Uq79eYCUH1Dq w4gn/6mqaBezusxxrAvb0M2wzznz0CIfuawXAuhhhNWIy1CdrHCfvfvnEG+uab5AKx9o3+ rODyBlgGn2vtxJ87A1WjnN47yCkiIMgFJcd7c+WcfFamHY4VxFVz3LQVB34ocxMMN2oCbt jdmlOiEODcPCRajnrnGDNyQiDurVP1/XcKwYuov2Er1yZisjPF2BbNyM6aFlGw== Date: Tue, 12 Dec 2023 17:07:04 +0100 From: Maxime Chevallier To: Stefan Eichenberger Cc: mw@semihalf.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: mvpp2: add support for mii Message-ID: <20231212170704.74565969@device.home> In-Reply-To: <20231212141200.62579-1-eichest@gmail.com> References: <20231212141200.62579-1-eichest@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 08:07:19 -0800 (PST) Hi Stefan, On Tue, 12 Dec 2023 15:12:00 +0100 Stefan Eichenberger wrote: > Currently, mvpp2 only supports RGMII. This commit adds support for MII. > The description in Marvell's functional specification seems to be wrong. > To enable MII, we need to set GENCONF_CTRL0_PORT3_RGMII, while for RGMII > we need to clear it. This is also how U-Boot handles it. > > Signed-off-by: Stefan Eichenberger Reviewed-by: Maxime Chevallier Thanks for the patch, Maxime