Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 12 Dec 2023 17:07:25 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org, avadhut.naik@amd.com,
        john.allen@amd.com, william.roche@oracle.com,
        muralidhara.mk@amd.com
Subject: Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library
Message-ID: <20231212160725.GFZXiFPSeoGwmRenpq@fat_crate.local>
References: <20231210194932.43992-1-yazen.ghannam@amd.com>
 <20231210194932.43992-2-yazen.ghannam@amd.com>
 <20231212132907.GJZXhgIyss9eT1MsNb@fat_crate.local>
 <a3305a97-4936-4cfd-b706-10b7792acdad@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a3305a97-4936-4cfd-b706-10b7792acdad@amd.com>
Precedence: bulk

On Tue, Dec 12, 2023 at 09:33:44AM -0500, Yazen Ghannam wrote:
> That's mostly how it was in the previous revision. Should I go back to that
> then?

Yes please. We should avoid doing homegrown stuff and use the kernel
facilities which are already there.

> Okay, can do. This can drop the assert_*() helpers like the comments above.

Yap.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette