Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 12 Dec 2023 17:08:38 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Sean Young <sean@mess.org>
Cc:     linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in
 atomic context
Message-ID: <20231212160838.k4z4csy455a7qnje@pengutronix.de>
References: <cover.1702369869.git.sean@mess.org>
 <e9e32c9789da3c90b5a2aa7d5a093120b76421fb.1702369869.git.sean@mess.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wlqgufhnyonivmrn"
Content-Disposition: inline
In-Reply-To: <e9e32c9789da3c90b5a2aa7d5a093120b76421fb.1702369869.git.sean@mess.org>
Precedence: bulk


--wlqgufhnyonivmrn
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Sean,

On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote:
> @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev)
>  {
>  	struct bcm2835_pwm *pc =3D dev_get_drvdata(dev);
> =20
> +	clk_rate_exclusive_put(pc->clk);
>  	clk_disable_unprepare(pc->clk);

I thought this was the remove function, but that's suspend. Adding
clk_rate_exclusive_put() there is wrong.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--wlqgufhnyonivmrn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmV4hYUACgkQj4D7WH0S
/k7CGwf8CNDJo8J8DGsUCNsNPFcJnPGhEI5nHgeeIHjn5tWVeMMh4VTcS5OPtH2b
lVGGS2AKxudNdoodSJ/x50nT0o/PdjrcXmWX2V6WVx2P3kmHrPk7lvExuQlaWmhd
LmdKyjfjUXEJ3Cr+TEZ2MwmVxyvrqhvEqqKHKE88hxeb+WU6pz3Jc9bivEEoQttV
PbLO5ghpdc5JjT4TR/q0Tfm/bOfQpLx7fIodBvZ7pzqLWO7/ExmK9ektbG60oJXq
sVSjGYJta2hqOzGxcfXZgBpBDtXvGB0fl5O/c7vyG59aLZkwcSQpp2y9L8NXe54r
C/R7Dp4x1L/tF2BExdxbEZ7sXvOJWA==
=Shxu
-----END PGP SIGNATURE-----

--wlqgufhnyonivmrn--