Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <6c331be3-350d-4840-acbd-144a65efa954@ti.com>
Date:   Tue, 12 Dec 2023 10:16:59 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc: ti: k3-socinfo: Add JTAG ID for J722S
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>
CC:     Vaishnav Achath <vaishnav.a@ti.com>, <ssantosh@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
        <u-kumar1@ti.com>, <j-choudhary@ti.com>
References: <20231211132600.25289-1-vaishnav.a@ti.com>
 <81f90d13-da10-4a68-a0e7-95212f40b3e8@ti.com>
 <20231212154238.3sn5fxpestaqacrc@defog>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <20231212154238.3sn5fxpestaqacrc@defog>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/12/23 9:42 AM, Nishanth Menon wrote:
> On 09:19-20231212, Andrew Davis wrote:
>> On 12/11/23 7:26 AM, Vaishnav Achath wrote:
>>> Add JTAG ID info for the J722S SoC family to enable SoC detection.
>>>
>>> More details about this SoC can be found in the TRM:
>>> 	https://www.ti.com/lit/zip/sprujb3
>>>
>>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>>> ---
>>
>> Simple enough,
>>
>> Reviewed-by: Andrew Davis <afd@ti.com>
>>
>> Although I do question our use of the J7x names. All of our parts here
>> also have a "Sitara AMxx" branding. For instance here we could call
>> this new device by its "AM67" name, then J784S4 renamed as AM69, etc.
>> Then we would have a consistent naming (internally we will have to deal
>> with the part name madness, but why expose that externally if we don't
>> have to).
> 
> J722S is a new die and the core part, what rebranding/spins happens to it is
> subject to mktg group, not going to hold this series with that.
> 

Never said to hold the series (I even gave my R-B), just a suggestion for
later. Or more important when we add the DTB and other names to be consistent
and use the correct part names and not always use the parent/die/family name.

Andrew