Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4755619rdb; Tue, 12 Dec 2023 08:27:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxqTmGx67MSbo+oPezJtfvfMl10yJaea9hh+xLG0qWsWlsZ1W0sANZSg+BFZk5zXAfU1ct X-Received: by 2002:a17:903:244e:b0:1d0:b6d1:d442 with SMTP id l14-20020a170903244e00b001d0b6d1d442mr9309471pls.62.1702398455029; Tue, 12 Dec 2023 08:27:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702398455; cv=none; d=google.com; s=arc-20160816; b=R9dokEPVeOU6JUW15qas7HGrIpJPBC5rVvWM3/KrmxNDxoOQ1L1s/T+iKGHtyfU5Di W1cHQxE1VQRNnjvHYuSGiptvtrN0K0e+XCF7UqWKc4g7dasJIDZ/gVscaTnWHmbr1JgN FVig1ANraJPImd+RkjghKYq5PTx/o34HSeYD6nzfTaP/lWvLc7ZqdV20MANB0wHKNbJS PAK7CkqvaAOEkAMpQL5P46nyrT4GbM8NgZyO2P0F2UGyy4om5vNSzgTMcfTwpsBVoCZO Bp8sWVRMjZhS6VzQFFZZTP8dCi6QvC/rooWZG4nVPprHJMXKtENicLVO/HLGRoDhqTE+ 8p0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=5vQVypmTK3SX10qp0Gi50SAmu7tfZcwgkQfn1qWA4g8=; fh=4ACXwp4kZXiO+h3/kGxdw2CK3XpjZ2QDir/E8qcBO3E=; b=Y9nuyPvfLaKssgmsr8LYSPBYLPKgfS/0ubV1WTc8ZVpCv/BShje9UBAvhdy8wVE41q EAeZYXJkANaKBdDwrNDnQ8tMa3WHX3Xfgh5HUbqNllskqUCWHP+NbXFw12eVxiGT7MLg x6Vr6Xn01aHm3CcAAeInsosFD2XsxDTRh2PVbOfEXoSe//N+BTrfaTiZyNiQYVRqnpCY nmneqQSOkoA62vDncfqGZPO6iZyy0aMU4L90yFFJJ+3vaMraOhdCKCr3NtctLBvXCBq/ lH8wSEJagDU11z88QvAr4LoScYjGvy5MwL3FkUJC7gbQSg5CtXH3m8R5j3BC5Bl9a7dv fwuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FmrX47b7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id y38-20020a634966000000b005c666ab748bsi7059265pgk.335.2023.12.12.08.27.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 08:27:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FmrX47b7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0300F80A9D7B; Tue, 12 Dec 2023 08:27:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbjLLQ1S (ORCPT + 99 others); Tue, 12 Dec 2023 11:27:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbjLLQ1R (ORCPT ); Tue, 12 Dec 2023 11:27:17 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AD99AD for ; Tue, 12 Dec 2023 08:27:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D207C433C7; Tue, 12 Dec 2023 16:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702398443; bh=t3KKiYi0IdU2y9j91oE71YEklgKddavq7ESsXn9uET4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FmrX47b7FO9QssAD09a7oHhvNJ1/DSXBvjQ4RvCYchuZ6/sTAh9XBDG970mIzERJp TTo902Q+yAcmPS1hPuve25ZZ4rI0Mz6S66LXqWrUYSqaoCxBkx6XcimchzuR06NnkM fS3Q/VztSu9++JBc+V14I/GMbW9RQyg439T3PihA= Date: Tue, 12 Dec 2023 08:27:22 -0800 From: Andrew Morton To: Ryan Roberts Cc: David Hildenbrand , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song Subject: Re: [PATCH v9 03/10] mm: thp: Introduce multi-size THP sysfs interface Message-Id: <20231212082722.13e857daf589bd49d5e877d9@linux-foundation.org> In-Reply-To: References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-4-ryan.roberts@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Dec 2023 08:27:33 -0800 (PST) On Tue, 12 Dec 2023 15:32:29 +0000 Ryan Roberts wrote: > > Why not perform lock/unlock only once in surrounding code? :) > > I was nervous that sysfs_streq() may be unhappy in atomic context... Unfounded? > Yes, unfounded.