Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 12 Dec 2023 08:34:02 -0800
From:   Yury Norov <yury.norov@gmail.com>
To:     Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com,
        leon@kernel.org, cai.huoqing@linux.dev,
        ssengar@linux.microsoft.com, vkuznets@redhat.com,
        tglx@linutronix.de, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, schakrabarti@microsoft.com,
        paulros@microsoft.com
Subject: Re: [PATCH V5 net-next] net: mana: Assigning IRQ affinity on HT cores
Message-ID: <ZXiLetPnY5TlAQGY@yury-ThinkPad>
References: <1702029754-6520-1-git-send-email-schakrabarti@linux.microsoft.com>
 <ZXMiOwK3sOJNXHxd@yury-ThinkPad>
 <20231211063726.GA4977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <ZXcrHc5QGPTZtXKf@yury-ThinkPad>
 <20231212113856.GA17123@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231212113856.GA17123@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Precedence: bulk

> > > > > +	rcu_read_lock();
> > > > > +	for_each_numa_hop_mask(next, next_node) {
> > > > > +		cpumask_andnot(curr, next, prev);
> > > > > +		for (w = cpumask_weight(curr), cnt = 0; cnt < w; ) {
> > > > > +			cpumask_copy(cpus, curr);
> > > > > +			for_each_cpu(cpu, cpus) {
> > > > > +				irq_set_affinity_and_hint(irqs[i], topology_sibling_cpumask(cpu));
> > > > > +				if (++i == nvec)
> > > > > +					goto done;
> > > > 
> > > > Think what if you're passed with irq_setup(NULL, 0, 0).
> > > > That's why I suggested to place this check at the beginning.
> > > > 
> > > irq_setup() is a helper function for mana_gd_setup_irqs(), which already takes
> > > care of no NULL pointer for irqs, and 0 number of interrupts can not be passed.
> > > 
> > > nvec = pci_alloc_irq_vectors(pdev, 2, max_irqs, PCI_IRQ_MSIX);
> > > if (nvec < 0)
> > > 	return nvec;
> > 
> > I know that. But still it's a bug. The common convention is that if a
> > 0-length array is passed to a function, it should not dereference the
> > pointer.
> > 
> I will add one if check in the begining of irq_setup() to verify the pointer
> and the nvec number.

Yes you can, but what for? This is an error anyways, and you don't
care about early return. So instead of adding and bearing extra logic,
I'd just swap 2 lines of existing code.