Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4766775rdb; Tue, 12 Dec 2023 08:45:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQFPd1se5g3O/oN+VeXB5mIoRy7D2ElaK/rMv0DskBlnpF+tUuoRkYTAhsjbYYNFFbyGyV X-Received: by 2002:a05:6e02:1b85:b0:35d:68a3:a659 with SMTP id h5-20020a056e021b8500b0035d68a3a659mr6768740ili.16.1702399554758; Tue, 12 Dec 2023 08:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702399554; cv=none; d=google.com; s=arc-20160816; b=QcDfY3hcVTO+tLkk8gQUcKcpDROcTzbP2FsMZD06H9115UHseJhbMMon7ovWNRZskL HGFZCQzAHmbXYeiqxAPy/eHg+nrReAz/Rf9vnTMjaoNsXOfRXR0EYRA9t0meLpy89zhp vze5lxlr6IEEH3fw6odscOtpEew8imO3tvBLnNJO8fl+6Leh+S9xVfWqnHOd/T6I0WiD pDlRr3lxgXi8OMCYlBk24gd6yo/VHSKysatsNX3f9COLPe89rbzBxxcUbT0vi3cz8Mc/ /jGGnUt/NBkqmpuPdPPaOLR9cSMRlOrDm9t95LMUpxltsedmXjkOGaytD5Wtl9yO30gn Qk+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=f72rnhLGCj7YeXxJ2uAZSlHFuNQHutdzqzKTHCk0k28=; fh=XJ0Y3cig+qv+534UnUrzMLQbmZNngTumcKDr0yj9Yxs=; b=yc3va87Zsi1JLv8MepOUjYjuDSgmzhtbBonIAG4xza5JfoHJFnGv+BzFt68RyreOQv Hgv8cTF2gCdXF77f4B8netDllAcGiQUj9NVzwkDFU1Von8tkWj0G/Ugu91CblXVwDc+9 kg58UfrLO0s8EGx/r9X+04Hjf21pxeCC4tY9vdj0wurjaAhEyv51tAP5eEhPV0Cn6tBM zD0c3u4S1XfA5g8jI78yljcDxuCAcKVlMuLUibdkRGpdA/KF3GK3fA+ujdK//gPTyoLw COmU/PFe5TX24j+Te4S4scQN1510A3H/IdOriCinNXBs92s3+FOfHMQUlvpPpQVgk9sw rSoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=e2fftcZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id m8-20020a63ed48000000b005c6673e2c72si7809744pgk.213.2023.12.12.08.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 08:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=e2fftcZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id DDACB807DE0B; Tue, 12 Dec 2023 08:45:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232792AbjLLQou (ORCPT + 99 others); Tue, 12 Dec 2023 11:44:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232570AbjLLQou (ORCPT ); Tue, 12 Dec 2023 11:44:50 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF39CCA; Tue, 12 Dec 2023 08:44:55 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3333074512bso3734010f8f.1; Tue, 12 Dec 2023 08:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702399494; x=1703004294; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f72rnhLGCj7YeXxJ2uAZSlHFuNQHutdzqzKTHCk0k28=; b=e2fftcZ3W3jZ8+lB3bO+fWSQFYhVe9ErWy3E7zjMmVxkdEmHaBt9KroM/75n6wQBA9 wt2T5XBb6spvvHU8fTPXbq1wtx1hwSSCJjCBKG2rR0Hh80ctd3hGpF3c0EGIGtvbcFE1 XnunYWOkE9E/nakovRvMUlgvS3dpLt7zdlDfzLKuDF0wFXEs2Mm8GOaPc4ouUpfA729b LLVk30yocQ6+akKQEmJxvHiMltIMzqh/+1ZP6zB4qf4Z8V8DqrFw8MeJZ7PGHzBEFqXB pdq5RvCw0lVz7gZd92DuUORfTGmyqQJF+PtdJzucVcEE61q18jSP2fQwmXaNRehlb5aO W0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702399494; x=1703004294; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f72rnhLGCj7YeXxJ2uAZSlHFuNQHutdzqzKTHCk0k28=; b=a0nKNF5fadOtQGmSCx08N3d9PBZgN6QgTqo9kT6DzEmfo/pMZ0DUoSXk7AHrxMraZ4 PvoDZkcd9W3v0L5HVJgkOWVtJWDfu/3ylKDiccIG3QYSoId2aehDoPuP/PYW1jun7+Z/ dmJeEJejztooiAdGUjxDkrLBu+trXiLBpsUilkiW2R8cnLe0TZNlqlgSSTD4G9eB3nQt L+eSswtSQDquwSBr2fdFhybZQT0rW7ncO82WUQYRl/Gmu6gkXZCeFRTikPe9E9L2Eq9p Kmv2CWM5D3IhNVhfJw/w3NQc9fao58Zt4T/0aA0Uel6AgbUW1xL6loMPAwuDC/lt+nhV oY6w== X-Gm-Message-State: AOJu0Yx/adthG4spR04sipg6nIr4PUn/IYBJ+oVDGbtlxNjPnN9FKNLV oq7unj11jkoUMCSw05JL8klPLOp1xSw0xUAfCkM= X-Received: by 2002:a05:600c:4897:b0:40c:1de7:41d5 with SMTP id j23-20020a05600c489700b0040c1de741d5mr3522673wmp.87.1702399493727; Tue, 12 Dec 2023 08:44:53 -0800 (PST) MIME-Version: 1.0 References: <8ec1b885d2e13fcd20944cce9edc0340d993d044.1702325874.git.dxu@dxuuu.xyz> <7yjkfhrwdphtcljq3odv4jc6lucd32wcg277hfsf4ve2jbo7hp@vuqzwbq5nxjw> In-Reply-To: From: Alexei Starovoitov Date: Tue, 12 Dec 2023 08:44:42 -0800 Message-ID: Subject: Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state() To: Daniel Xu Cc: Eyal Birger , Daniel Borkmann , "David S. Miller" , Shuah Khan , Alexei Starovoitov , John Fastabend , Jakub Kicinski , Andrii Nakryiko , Jesper Dangaard Brouer , Steffen Klassert , antony.antony@secunet.com, Yonghong Song , Eddy Z , Mykola Lysenko , Martin KaFai Lau , Song Liu , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Network Development , devel@linux-ipsec.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 08:45:06 -0800 (PST) On Tue, Dec 12, 2023 at 8:17=E2=80=AFAM Daniel Xu wrote: > > > If you don't mind (and there no more comments), I would prefer to send a > follow up fixing the nits in this revision. So that I stop blasting the > list (as well as people who may not be as concerned with these details). Resending patches is little effort while follow up patches double the commits, more code churn, increase in code reviews, etc. Always address feedback by resending.